Revision e9338abf0e186336022293d2e454c106761f262b authored by Linus Torvalds on 15 July 2021, 20:57:31 UTC, committed by Linus Torvalds on 15 July 2021, 20:57:31 UTC
Pull fallthrough fixes from Gustavo Silva:
 "This fixes many fall-through warnings when building with Clang and
  -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for
  Clang, globally.

  It's also important to notice that since we have adopted the use of
  the pseudo-keyword macro fallthrough, we also want to avoid having
  more /* fall through */ comments being introduced. Contrary to GCC,
  Clang doesn't recognize any comments as implicit fall-through markings
  when the -Wimplicit-fallthrough option is enabled.

  So, in order to avoid having more comments being introduced, we use
  the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang,
  will cause a warning in case a code comment is intended to be used as
  a fall-through marking. The patch for Makefile also enforces this.

  We had almost 4,000 of these issues for Clang in the beginning, and
  there might be a couple more out there when building some
  architectures with certain configurations. However, with the recent
  fixes I think we are in good shape and it is now possible to enable
  the warning for Clang"

* tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits)
  Makefile: Enable -Wimplicit-fallthrough for Clang
  powerpc/smp: Fix fall-through warning for Clang
  dmaengine: mpc512x: Fix fall-through warning for Clang
  usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang
  powerpc/powernv: Fix fall-through warning for Clang
  MIPS: Fix unreachable code issue
  MIPS: Fix fall-through warnings for Clang
  ASoC: Mediatek: MT8183: Fix fall-through warning for Clang
  power: supply: Fix fall-through warnings for Clang
  dmaengine: ti: k3-udma: Fix fall-through warning for Clang
  s390: Fix fall-through warnings for Clang
  dmaengine: ipu: Fix fall-through warning for Clang
  iommu/arm-smmu-v3: Fix fall-through warning for Clang
  mmc: jz4740: Fix fall-through warning for Clang
  PCI: Fix fall-through warning for Clang
  scsi: libsas: Fix fall-through warning for Clang
  video: fbdev: Fix fall-through warning for Clang
  math-emu: Fix fall-through warning
  cpufreq: Fix fall-through warning for Clang
  drm/msm: Fix fall-through warning in msm_gem_new_impl()
  ...
2 parent s dd9c7df + b7eb335
History
File Mode Size
blink
flash
trigger
Kconfig -rw-r--r-- 28.3 KB
Makefile -rw-r--r-- 4.6 KB
TODO -rw-r--r-- 2.6 KB
led-class-flash.c -rw-r--r-- 10.7 KB
led-class-multicolor.c -rw-r--r-- 5.0 KB
led-class.c -rw-r--r-- 12.8 KB
led-core.c -rw-r--r-- 12.7 KB
led-triggers.c -rw-r--r-- 11.3 KB
leds-88pm860x.c -rw-r--r-- 5.7 KB
leds-aat1290.c -rw-r--r-- 14.4 KB
leds-acer-a500.c -rw-r--r-- 3.4 KB
leds-adp5520.c -rw-r--r-- 4.8 KB
leds-an30259a.c -rw-r--r-- 8.6 KB
leds-apu.c -rw-r--r-- 6.2 KB
leds-ariel.c -rw-r--r-- 3.0 KB
leds-as3645a.c -rw-r--r-- 19.4 KB
leds-asic3.c -rw-r--r-- 4.4 KB
leds-aw2013.c -rw-r--r-- 9.4 KB
leds-bcm6328.c -rw-r--r-- 12.7 KB
leds-bcm6358.c -rw-r--r-- 5.2 KB
leds-bd2802.c -rw-r--r-- 20.4 KB
leds-blinkm.c -rw-r--r-- 18.1 KB
leds-clevo-mail.c -rw-r--r-- 5.4 KB
leds-cobalt-qube.c -rw-r--r-- 1.6 KB
leds-cobalt-raq.c -rw-r--r-- 2.2 KB
leds-cpcap.c -rw-r--r-- 4.9 KB
leds-cr0014114.c -rw-r--r-- 6.7 KB
leds-da903x.c -rw-r--r-- 3.6 KB
leds-da9052.c -rw-r--r-- 4.4 KB
leds-dac124s085.c -rw-r--r-- 2.4 KB
leds-el15203000.c -rw-r--r-- 8.6 KB
leds-fsg.c -rw-r--r-- 4.3 KB
leds-gpio-register.c -rw-r--r-- 1.2 KB
leds-gpio.c -rw-r--r-- 8.1 KB
leds-hp6xx.c -rw-r--r-- 1.8 KB
leds-ip30.c -rw-r--r-- 1.8 KB
leds-ipaq-micro.c -rw-r--r-- 3.5 KB
leds-is31fl319x.c -rw-r--r-- 12.0 KB
leds-is31fl32xx.c -rw-r--r-- 13.0 KB
leds-ktd2692.c -rw-r--r-- 11.1 KB
leds-lm3530.c -rw-r--r-- 12.6 KB
leds-lm3532.c -rw-r--r-- 18.5 KB
leds-lm3533.c -rw-r--r-- 17.5 KB
leds-lm355x.c -rw-r--r-- 12.4 KB
leds-lm3601x.c -rw-r--r-- 11.8 KB
leds-lm36274.c -rw-r--r-- 4.2 KB
leds-lm3642.c -rw-r--r-- 10.1 KB
leds-lm3692x.c -rw-r--r-- 12.9 KB
leds-lm3697.c -rw-r--r-- 9.5 KB
leds-locomo.c -rw-r--r-- 1.9 KB
leds-lp3944.c -rw-r--r-- 10.5 KB
leds-lp3952.c -rw-r--r-- 6.6 KB
leds-lp50xx.c -rw-r--r-- 16.7 KB
leds-lp5521.c -rw-r--r-- 15.4 KB
leds-lp5523.c -rw-r--r-- 23.6 KB
leds-lp5562.c -rw-r--r-- 14.6 KB
leds-lp55xx-common.c -rw-r--r-- 16.1 KB
leds-lp55xx-common.h -rw-r--r-- 6.0 KB
leds-lp8501.c -rw-r--r-- 9.2 KB
leds-lp8788.c -rw-r--r-- 3.7 KB
leds-lp8860.c -rw-r--r-- 12.0 KB
leds-lt3593.c -rw-r--r-- 3.2 KB
leds-max77650.c -rw-r--r-- 3.6 KB
leds-max77693.c -rw-r--r-- 26.9 KB
leds-max8997.c -rw-r--r-- 7.4 KB
leds-mc13783.c -rw-r--r-- 7.4 KB
leds-menf21bmc.c -rw-r--r-- 2.5 KB
leds-mlxcpld.c -rw-r--r-- 11.9 KB
leds-mlxreg.c -rw-r--r-- 8.8 KB
leds-mt6323.c -rw-r--r-- 12.3 KB
leds-net48xx.c -rw-r--r-- 1.8 KB
leds-netxbig.c -rw-r--r-- 15.4 KB
leds-nic78bx.c -rw-r--r-- 4.5 KB
leds-ns2.c -rw-r--r-- 6.5 KB
leds-ot200.c -rw-r--r-- 2.7 KB
leds-pca9532.c -rw-r--r-- 14.1 KB
leds-pca955x.c -rw-r--r-- 14.7 KB
leds-pca963x.c -rw-r--r-- 10.6 KB
leds-pm8058.c -rw-r--r-- 4.2 KB
leds-powernv.c -rw-r--r-- 8.8 KB
leds-pwm.c -rw-r--r-- 4.1 KB
leds-rb532.c -rw-r--r-- 1.5 KB
leds-regulator.c -rw-r--r-- 4.4 KB
leds-s3c24xx.c -rw-r--r-- 2.0 KB
leds-sc27xx-bltc.c -rw-r--r-- 8.9 KB
leds-sgm3140.c -rw-r--r-- 7.4 KB
leds-spi-byte.c -rw-r--r-- 4.4 KB
leds-ss4200.c -rw-r--r-- 14.0 KB
leds-sunfire.c -rw-r--r-- 5.5 KB
leds-syscon.c -rw-r--r-- 3.2 KB
leds-tca6507.c -rw-r--r-- 20.7 KB
leds-ti-lmu-common.c -rw-r--r-- 3.8 KB
leds-tlc591xx.c -rw-r--r-- 5.4 KB
leds-tps6105x.c -rw-r--r-- 2.3 KB
leds-turris-omnia.c -rw-r--r-- 7.3 KB
leds-wm831x-status.c -rw-r--r-- 6.7 KB
leds-wm8350.c -rw-r--r-- 5.0 KB
leds-wrap.c -rw-r--r-- 2.7 KB
leds.h -rw-r--r-- 1.1 KB
uleds.c -rw-r--r-- 4.7 KB

back to top