Revision e9338abf0e186336022293d2e454c106761f262b authored by Linus Torvalds on 15 July 2021, 20:57:31 UTC, committed by Linus Torvalds on 15 July 2021, 20:57:31 UTC
Pull fallthrough fixes from Gustavo Silva: "This fixes many fall-through warnings when building with Clang and -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for Clang, globally. It's also important to notice that since we have adopted the use of the pseudo-keyword macro fallthrough, we also want to avoid having more /* fall through */ comments being introduced. Contrary to GCC, Clang doesn't recognize any comments as implicit fall-through markings when the -Wimplicit-fallthrough option is enabled. So, in order to avoid having more comments being introduced, we use the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang, will cause a warning in case a code comment is intended to be used as a fall-through marking. The patch for Makefile also enforces this. We had almost 4,000 of these issues for Clang in the beginning, and there might be a couple more out there when building some architectures with certain configurations. However, with the recent fixes I think we are in good shape and it is now possible to enable the warning for Clang" * tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits) Makefile: Enable -Wimplicit-fallthrough for Clang powerpc/smp: Fix fall-through warning for Clang dmaengine: mpc512x: Fix fall-through warning for Clang usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang powerpc/powernv: Fix fall-through warning for Clang MIPS: Fix unreachable code issue MIPS: Fix fall-through warnings for Clang ASoC: Mediatek: MT8183: Fix fall-through warning for Clang power: supply: Fix fall-through warnings for Clang dmaengine: ti: k3-udma: Fix fall-through warning for Clang s390: Fix fall-through warnings for Clang dmaengine: ipu: Fix fall-through warning for Clang iommu/arm-smmu-v3: Fix fall-through warning for Clang mmc: jz4740: Fix fall-through warning for Clang PCI: Fix fall-through warning for Clang scsi: libsas: Fix fall-through warning for Clang video: fbdev: Fix fall-through warning for Clang math-emu: Fix fall-through warning cpufreq: Fix fall-through warning for Clang drm/msm: Fix fall-through warning in msm_gem_new_impl() ...
netvsc_trace.h
/* SPDX-License-Identifier: GPL-2.0 */
#if !defined(_NETVSC_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
#define _NETVSC_TRACE_H
#include <linux/tracepoint.h>
#undef TRACE_SYSTEM
#define TRACE_SYSTEM netvsc
#define TRACE_INCLUDE_FILE netvsc_trace
TRACE_DEFINE_ENUM(RNDIS_MSG_PACKET);
TRACE_DEFINE_ENUM(RNDIS_MSG_INDICATE);
TRACE_DEFINE_ENUM(RNDIS_MSG_INIT);
TRACE_DEFINE_ENUM(RNDIS_MSG_INIT_C);
TRACE_DEFINE_ENUM(RNDIS_MSG_HALT);
TRACE_DEFINE_ENUM(RNDIS_MSG_QUERY);
TRACE_DEFINE_ENUM(RNDIS_MSG_QUERY_C);
TRACE_DEFINE_ENUM(RNDIS_MSG_SET);
TRACE_DEFINE_ENUM(RNDIS_MSG_SET_C);
TRACE_DEFINE_ENUM(RNDIS_MSG_RESET);
TRACE_DEFINE_ENUM(RNDIS_MSG_RESET_C);
TRACE_DEFINE_ENUM(RNDIS_MSG_KEEPALIVE);
TRACE_DEFINE_ENUM(RNDIS_MSG_KEEPALIVE_C);
#define show_rndis_type(type) \
__print_symbolic(type, \
{ RNDIS_MSG_PACKET, "PACKET" }, \
{ RNDIS_MSG_INDICATE, "INDICATE", }, \
{ RNDIS_MSG_INIT, "INIT", }, \
{ RNDIS_MSG_INIT_C, "INIT_C", }, \
{ RNDIS_MSG_HALT, "HALT", }, \
{ RNDIS_MSG_QUERY, "QUERY", }, \
{ RNDIS_MSG_QUERY_C, "QUERY_C", }, \
{ RNDIS_MSG_SET, "SET", }, \
{ RNDIS_MSG_SET_C, "SET_C", }, \
{ RNDIS_MSG_RESET, "RESET", }, \
{ RNDIS_MSG_RESET_C, "RESET_C", }, \
{ RNDIS_MSG_KEEPALIVE, "KEEPALIVE", }, \
{ RNDIS_MSG_KEEPALIVE_C, "KEEPALIVE_C", })
DECLARE_EVENT_CLASS(rndis_msg_class,
TP_PROTO(const struct net_device *ndev, u16 q,
const struct rndis_message *msg),
TP_ARGS(ndev, q, msg),
TP_STRUCT__entry(
__string( name, ndev->name )
__field( u16, queue )
__field( u32, req_id )
__field( u32, msg_type )
__field( u32, msg_len )
),
TP_fast_assign(
__assign_str(name, ndev->name);
__entry->queue = q;
__entry->req_id = msg->msg.init_req.req_id;
__entry->msg_type = msg->ndis_msg_type;
__entry->msg_len = msg->msg_len;
),
TP_printk("dev=%s q=%u req=%#x type=%s msg_len=%u",
__get_str(name), __entry->queue, __entry->req_id,
show_rndis_type(__entry->msg_type), __entry->msg_len)
);
DEFINE_EVENT(rndis_msg_class, rndis_send,
TP_PROTO(const struct net_device *ndev, u16 q,
const struct rndis_message *msg),
TP_ARGS(ndev, q, msg)
);
DEFINE_EVENT(rndis_msg_class, rndis_recv,
TP_PROTO(const struct net_device *ndev, u16 q,
const struct rndis_message *msg),
TP_ARGS(ndev, q, msg)
);
TRACE_DEFINE_ENUM(NVSP_MSG_TYPE_INIT);
TRACE_DEFINE_ENUM(NVSP_MSG_TYPE_INIT_COMPLETE);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_NDIS_VER);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_RECV_BUF);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_RECV_BUF_COMPLETE);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_REVOKE_RECV_BUF);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_SEND_BUF);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_SEND_BUF_COMPLETE);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_REVOKE_SEND_BUF);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_RNDIS_PKT);
TRACE_DEFINE_ENUM(NVSP_MSG1_TYPE_SEND_RNDIS_PKT_COMPLETE);
TRACE_DEFINE_ENUM(NVSP_MSG2_TYPE_SEND_NDIS_CONFIG);
TRACE_DEFINE_ENUM(NVSP_MSG4_TYPE_SEND_VF_ASSOCIATION);
TRACE_DEFINE_ENUM(NVSP_MSG4_TYPE_SWITCH_DATA_PATH);
TRACE_DEFINE_ENUM(NVSP_MSG5_TYPE_SUBCHANNEL);
TRACE_DEFINE_ENUM(NVSP_MSG5_TYPE_SEND_INDIRECTION_TABLE);
#define show_nvsp_type(type) \
__print_symbolic(type, \
{ NVSP_MSG_TYPE_INIT, "INIT" }, \
{ NVSP_MSG_TYPE_INIT_COMPLETE, "INIT_COMPLETE" }, \
{ NVSP_MSG1_TYPE_SEND_NDIS_VER, "SEND_NDIS_VER" }, \
{ NVSP_MSG1_TYPE_SEND_RECV_BUF, "SEND_RECV_BUF" }, \
{ NVSP_MSG1_TYPE_SEND_RECV_BUF_COMPLETE, "SEND_RECV_BUF_COMPLETE" }, \
{ NVSP_MSG1_TYPE_REVOKE_RECV_BUF, "REVOKE_RECV_BUF" }, \
{ NVSP_MSG1_TYPE_SEND_SEND_BUF, "SEND_SEND_BUF" }, \
{ NVSP_MSG1_TYPE_SEND_SEND_BUF_COMPLETE, "SEND_SEND_BUF_COMPLETE" }, \
{ NVSP_MSG1_TYPE_REVOKE_SEND_BUF, "REVOKE_SEND_BUF" }, \
{ NVSP_MSG1_TYPE_SEND_RNDIS_PKT, "SEND_RNDIS_PKT" }, \
{ NVSP_MSG1_TYPE_SEND_RNDIS_PKT_COMPLETE, "SEND_RNDIS_PKT_COMPLETE" },\
{ NVSP_MSG2_TYPE_SEND_NDIS_CONFIG, "SEND_NDIS_CONFIG" }, \
{ NVSP_MSG4_TYPE_SEND_VF_ASSOCIATION, "SEND_VF_ASSOCIATION" }, \
{ NVSP_MSG4_TYPE_SWITCH_DATA_PATH, "SWITCH_DATA_PATH" }, \
{ NVSP_MSG5_TYPE_SUBCHANNEL, "SUBCHANNEL" }, \
{ NVSP_MSG5_TYPE_SEND_INDIRECTION_TABLE, "SEND_INDIRECTION_TABLE" })
TRACE_EVENT(nvsp_send,
TP_PROTO(const struct net_device *ndev,
const struct nvsp_message *msg),
TP_ARGS(ndev, msg),
TP_STRUCT__entry(
__string( name, ndev->name )
__field( u32, msg_type )
),
TP_fast_assign(
__assign_str(name, ndev->name);
__entry->msg_type = msg->hdr.msg_type;
),
TP_printk("dev=%s type=%s",
__get_str(name),
show_nvsp_type(__entry->msg_type))
);
TRACE_EVENT(nvsp_send_pkt,
TP_PROTO(const struct net_device *ndev,
const struct vmbus_channel *chan,
const struct nvsp_1_message_send_rndis_packet *rpkt),
TP_ARGS(ndev, chan, rpkt),
TP_STRUCT__entry(
__string( name, ndev->name )
__field( u16, qid )
__field( u32, channel_type )
__field( u32, section_index )
__field( u32, section_size )
),
TP_fast_assign(
__assign_str(name, ndev->name);
__entry->qid = chan->offermsg.offer.sub_channel_index;
__entry->channel_type = rpkt->channel_type;
__entry->section_index = rpkt->send_buf_section_index;
__entry->section_size = rpkt->send_buf_section_size;
),
TP_printk("dev=%s qid=%u type=%s section=%u size=%d",
__get_str(name), __entry->qid,
__entry->channel_type ? "CONTROL" : "DATA",
__entry->section_index, __entry->section_size)
);
TRACE_EVENT(nvsp_recv,
TP_PROTO(const struct net_device *ndev,
const struct vmbus_channel *chan,
const struct nvsp_message *msg),
TP_ARGS(ndev, chan, msg),
TP_STRUCT__entry(
__string( name, ndev->name )
__field( u16, qid )
__field( u32, msg_type )
),
TP_fast_assign(
__assign_str(name, ndev->name);
__entry->qid = chan->offermsg.offer.sub_channel_index;
__entry->msg_type = msg->hdr.msg_type;
),
TP_printk("dev=%s qid=%u type=%s",
__get_str(name), __entry->qid,
show_nvsp_type(__entry->msg_type))
);
#endif /* _NETVSC_TRACE_H */
/* This part must be outside protection */
#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH ../../drivers/net/hyperv
#include <trace/define_trace.h>
Computing file changes ...
