Revision e9338abf0e186336022293d2e454c106761f262b authored by Linus Torvalds on 15 July 2021, 20:57:31 UTC, committed by Linus Torvalds on 15 July 2021, 20:57:31 UTC
Pull fallthrough fixes from Gustavo Silva: "This fixes many fall-through warnings when building with Clang and -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for Clang, globally. It's also important to notice that since we have adopted the use of the pseudo-keyword macro fallthrough, we also want to avoid having more /* fall through */ comments being introduced. Contrary to GCC, Clang doesn't recognize any comments as implicit fall-through markings when the -Wimplicit-fallthrough option is enabled. So, in order to avoid having more comments being introduced, we use the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang, will cause a warning in case a code comment is intended to be used as a fall-through marking. The patch for Makefile also enforces this. We had almost 4,000 of these issues for Clang in the beginning, and there might be a couple more out there when building some architectures with certain configurations. However, with the recent fixes I think we are in good shape and it is now possible to enable the warning for Clang" * tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits) Makefile: Enable -Wimplicit-fallthrough for Clang powerpc/smp: Fix fall-through warning for Clang dmaengine: mpc512x: Fix fall-through warning for Clang usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang powerpc/powernv: Fix fall-through warning for Clang MIPS: Fix unreachable code issue MIPS: Fix fall-through warnings for Clang ASoC: Mediatek: MT8183: Fix fall-through warning for Clang power: supply: Fix fall-through warnings for Clang dmaengine: ti: k3-udma: Fix fall-through warning for Clang s390: Fix fall-through warnings for Clang dmaengine: ipu: Fix fall-through warning for Clang iommu/arm-smmu-v3: Fix fall-through warning for Clang mmc: jz4740: Fix fall-through warning for Clang PCI: Fix fall-through warning for Clang scsi: libsas: Fix fall-through warning for Clang video: fbdev: Fix fall-through warning for Clang math-emu: Fix fall-through warning cpufreq: Fix fall-through warning for Clang drm/msm: Fix fall-through warning in msm_gem_new_impl() ...
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 8.7 KB |
Makefile | -rw-r--r-- | 2.4 KB |
bcm-ocotp.c | -rw-r--r-- | 8.0 KB |
brcm_nvram.c | -rw-r--r-- | 1.7 KB |
core.c | -rw-r--r-- | 43.5 KB |
imx-iim.c | -rw-r--r-- | 3.0 KB |
imx-ocotp-scu.c | -rw-r--r-- | 5.4 KB |
imx-ocotp.c | -rw-r--r-- | 18.0 KB |
jz4780-efuse.c | -rw-r--r-- | 6.1 KB |
lpc18xx_eeprom.c | -rw-r--r-- | 7.0 KB |
lpc18xx_otp.c | -rw-r--r-- | 2.8 KB |
meson-efuse.c | -rw-r--r-- | 2.8 KB |
meson-mx-efuse.c | -rw-r--r-- | 6.6 KB |
mtk-efuse.c | -rw-r--r-- | 2.1 KB |
mxs-ocotp.c | -rw-r--r-- | 4.0 KB |
qcom-spmi-sdam.c | -rw-r--r-- | 4.3 KB |
qfprom.c | -rw-r--r-- | 12.5 KB |
rave-sp-eeprom.c | -rw-r--r-- | 9.4 KB |
rmem.c | -rw-r--r-- | 2.3 KB |
rockchip-efuse.c | -rw-r--r-- | 7.6 KB |
rockchip-otp.c | -rw-r--r-- | 6.3 KB |
sc27xx-efuse.c | -rw-r--r-- | 7.2 KB |
snvs_lpgpr.c | -rw-r--r-- | 3.7 KB |
sprd-efuse.c | -rw-r--r-- | 10.7 KB |
stm32-romem.c | -rw-r--r-- | 4.8 KB |
sunxi_sid.c | -rw-r--r-- | 5.2 KB |
uniphier-efuse.c | -rw-r--r-- | 1.9 KB |
vf610-ocotp.c | -rw-r--r-- | 6.0 KB |
zynqmp_nvmem.c | -rw-r--r-- | 1.8 KB |
Computing file changes ...