https://github.com/torvalds/linux
Revision e9dbebae2e3c338122716914fe105458f41e3a4a authored by Simon Horman on 23 July 2024, 13:29:27 UTC, committed by David S. Miller on 24 July 2024, 14:11:44 UTC
The perfect_match parameter of the update_vlan_hash operation is __le16,
and is correctly converted from host byte-order in the lone caller,
stmmac_vlan_update().
However, the implementations of this caller, dwxgmac2_update_vlan_hash()
and dwxgmac2_update_vlan_hash(), both treat this parameter as host byte
order, using the following pattern:
u32 value = ...
...
writel(value | perfect_match, ...);
This is not correct because both:
1) value is host byte order; and
2) writel expects a host byte order value as it's first argument
I believe that this will break on big endian systems. And I expect it
has gone unnoticed by only being exercised on little endian systems.
The approach taken by this patch is to update the callback, and it's
caller to simply use a host byte order value.
Flagged by Sparse.
Compile tested only.
Fixes: c7ab0b8088d7 ("net: stmmac: Fallback to VLAN Perfect filtering if HASH is not available")
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 863ff54
Tip revision: e9dbebae2e3c338122716914fe105458f41e3a4a authored by Simon Horman on 23 July 2024, 13:29:27 UTC
net: stmmac: Correct byte order of perfect_match
net: stmmac: Correct byte order of perfect_match
Tip revision: e9dbeba
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| LICENSES | ||
| arch | ||
| block | ||
| certs | ||
| crypto | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| io_uring | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| rust | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .clang-format | -rw-r--r-- | 21.7 KB |
| .cocciconfig | -rw-r--r-- | 59 bytes |
| .editorconfig | -rw-r--r-- | 575 bytes |
| .get_maintainer.ignore | -rw-r--r-- | 194 bytes |
| .gitattributes | -rw-r--r-- | 105 bytes |
| .gitignore | -rw-r--r-- | 2.0 KB |
| .mailmap | -rw-r--r-- | 40.0 KB |
| .rustfmt.toml | -rw-r--r-- | 369 bytes |
| COPYING | -rw-r--r-- | 496 bytes |
| CREDITS | -rw-r--r-- | 102.5 KB |
| Kbuild | -rw-r--r-- | 2.5 KB |
| Kconfig | -rw-r--r-- | 555 bytes |
| MAINTAINERS | -rw-r--r-- | 750.7 KB |
| Makefile | -rw-r--r-- | 66.5 KB |
| README | -rw-r--r-- | 726 bytes |
Computing file changes ...
