Skip to main content

Browse the archive

Revision e9f36aa0be6522db24e0d27b293a78ba68214d02 authored by Ehsan Karamad on 25 April 2018, 15:35:03 UTC, committed by Blink WPT Bot on 25 April 2018, 15:45:19 UTC 
'vertical-scroll' for programmatic scrolling
 
If 'vertical-scroll' is disabled for an <iframe>, then it should not be
able to affect the vertical scroll position. One way to block is to use
scripted scrolling by calling "element.scrollIntoView()".

To block such frames (whose feature's disabled), programmatic recursive
scroll calls are not forwarded to parent frames. This means if a given
<iframe> is blocked, then all the calls to scrollIntoView() are limited
to the scope of frame (i.e., elements becoming visible in the frame).
This applies to all the nested <iframe>'s of a disabled frame as well
since they would have the feature disabled as part of propagating the
container policy.

Link to explainer/design document for "vertical-scroll":
https://docs.google.com/document/d/1qiWelnMlsOHuT_CQ0Zm_qEAf54HS5DhoIvEDHBlfqps/edit?usp=sharing

Bug: 611982
Change-Id: I0e06b399ad890e263128b997cfbb04eb3bdd1494
Reviewed-on: https://chromium-review.googlesource.com/1014191
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553561}
1 parent 6c62c5b
Raw File
deleteFromDocument.html 
<!doctype html>
<title>Selection.deleteFromDocument() tests</title>
<link rel=author title="Aryeh Gregor" href=ayg@aryeh.name>
<p>To debug test failures, add a query parameter with the test id (like
"?5").  Only that test will be run.  Then you can look at the resulting
iframes in the DOM.
<div id=log></div>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src=common.js></script>
<script>
"use strict";

// We need to use explicit_done, because in Chrome 16 dev and Opera 12.00, the
// second iframe doesn't block the load event -- even though it is added before
// the load event.
setup({explicit_done: true});

// Specified by WebIDL
test(function() {
    assert_equals(Selection.prototype.deleteFromDocument.length, 0,
        "Selection.prototype.deleteFromDocument.length must equal 0");
}, "Selection.prototype.deleteFromDocument.length must equal 0");

testDiv.parentNode.removeChild(testDiv);

// Test an empty selection too
testRanges.unshift("empty");

var actualIframe = document.createElement("iframe");

var expectedIframe = document.createElement("iframe");

var referenceDoc = document.implementation.createHTMLDocument("");
referenceDoc.removeChild(referenceDoc.documentElement);

actualIframe.onload = function() {
    expectedIframe.onload = function() {
        for (var i = 0; i < testRanges.length; i++) {
            if (location.search && i != Number(location.search)) {
                continue;
            }

            test(function() {
                initializeIframe(actualIframe, testRanges[i]);
                initializeIframe(expectedIframe, testRanges[i]);

                var actualRange = actualIframe.contentWindow.testRange;
                var expectedRange = expectedIframe.contentWindow.testRange;

                assert_equals(actualIframe.contentWindow.unexpectedException, null,
                    "Unexpected exception thrown when setting up Range for actual deleteFromDocument");
                assert_equals(expectedIframe.contentWindow.unexpectedException, null,
                    "Unexpected exception thrown when setting up Range for simulated deleteFromDocument");

                actualIframe.contentWindow.getSelection().removeAllRanges();
                if (testRanges[i] != "empty") {
                    assert_equals(typeof actualRange, "object",
                        "Range produced in actual iframe must be an object");
                    assert_equals(typeof expectedRange, "object",
                        "Range produced in expected iframe must be an object");
                    assert_true(actualRange instanceof actualIframe.contentWindow.Range,
                        "Range produced in actual iframe must be instanceof Range");
                    assert_true(expectedRange instanceof expectedIframe.contentWindow.Range,
                        "Range produced in expected iframe must be instanceof Range");
                    actualIframe.contentWindow.getSelection().addRange(actualIframe.contentWindow.testRange);
                    expectedIframe.contentWindow.testRange.deleteContents();
                }
                actualIframe.contentWindow.getSelection().deleteFromDocument();

                assertNodesEqual(actualIframe.contentDocument, expectedIframe.contentDocument, "DOM contents");
            }, "Range " + i + ": " + testRanges[i]);
        }
        actualIframe.style.display = "none";
        expectedIframe.style.display = "none";
        done();
    };
    expectedIframe.src = "test-iframe.html";
    document.body.appendChild(expectedIframe);
    referenceDoc.appendChild(actualIframe.contentDocument.documentElement.cloneNode(true));
};
actualIframe.src = "test-iframe.html";
document.body.appendChild(actualIframe);

function initializeIframe(iframe, endpoints) {
    while (iframe.contentDocument.firstChild) {
        iframe.contentDocument.removeChild(iframe.contentDocument.lastChild);
    }
    iframe.contentDocument.appendChild(iframe.contentDocument.implementation.createDocumentType("html", "", ""));
    iframe.contentDocument.appendChild(referenceDoc.documentElement.cloneNode(true));
    iframe.contentWindow.setupRangeTests();
    if (endpoints != "empty") {
        iframe.contentWindow.testRangeInput = endpoints;
        iframe.contentWindow.run();
    }
}
</script>
back to top