Skip to main content

Browse the archive

Revision ebcc8ae1d3875aa9529b05b31c3da396cdf0c7bc authored by Siying Dong on 02 April 2019, 16:57:35 UTC, committed by Facebook Github Bot on 02 April 2019, 17:00:38 UTC 
Revert "Avoid per-key upper bound check in BlockBasedTableIterator (#5101)" (#5132)
 
Summary:
This reverts commit f29dc1b90641e7f44b14f932e3866c5840391cd5.

In BlockBasedTableIterator, index_iter_->key() is sometimes a user key, so it is wrong to call ExtractUserKey() against it. This is a bug introduced by #5101.
Temporarily revert the diff to keep the branch clean.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5132

Differential Revision: D14718584

Pulled By: siying

fbshipit-source-id: 0ac55dc9b5dbc18c7809092146bdf7eb9364b9ad
1 parent fa1b558
Raw File
.lgtm.yml 
extraction:
  cpp:
    index:
      build_command: make static_lib
back to top