Revision ebfddb3d447f5267c76680ea4d242e6f9bcafa87 authored by Arnd Bergmann on 13 September 2017, 23:28:23 UTC, committed by Linus Torvalds on 14 September 2017, 01:53:15 UTC
gcc points out a minor bug in the handling of unknown cookie types,
which could result in a string overflow when the integer is copied into
a 3-byte string:
fs/fscache/object-list.c: In function 'fscache_objlist_show':
fs/fscache/object-list.c:265:19: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
sprintf(_type, "%02u", cookie->def->type);
^~~~~~
fs/fscache/object-list.c:265:4: note: 'sprintf' output between 3 and 4 bytes into a destination of size 3
This is currently harmless as no code sets a type other than 0 or 1, but
it makes sense to use snprintf() here to avoid overflowing the array if
that changes.
Link: http://lkml.kernel.org/r/20170714120720.906842-22-arnd@arndb.de
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 8185f57
| File | Mode | Size |
|---|---|---|
| 00-INDEX | -rw-r--r-- | 368 bytes |
| README | -rw-r--r-- | 2.7 KB |
| abi.txt | -rw-r--r-- | 1.4 KB |
| fs.txt | -rw-r--r-- | 12.4 KB |
| kernel.txt | -rw-r--r-- | 37.4 KB |
| net.txt | -rw-r--r-- | 14.0 KB |
| sunrpc.txt | -rw-r--r-- | 784 bytes |
| user.txt | -rw-r--r-- | 2.2 KB |
| vm.txt | -rw-r--r-- | 33.0 KB |
Computing file changes ...
