Revision ebfddb3d447f5267c76680ea4d242e6f9bcafa87 authored by Arnd Bergmann on 13 September 2017, 23:28:23 UTC, committed by Linus Torvalds on 14 September 2017, 01:53:15 UTC
gcc points out a minor bug in the handling of unknown cookie types,
which could result in a string overflow when the integer is copied into
a 3-byte string:
fs/fscache/object-list.c: In function 'fscache_objlist_show':
fs/fscache/object-list.c:265:19: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
sprintf(_type, "%02u", cookie->def->type);
^~~~~~
fs/fscache/object-list.c:265:4: note: 'sprintf' output between 3 and 4 bytes into a destination of size 3
This is currently harmless as no code sets a type other than 0 or 1, but
it makes sense to use snprintf() here to avoid overflowing the array if
that changes.
Link: http://lkml.kernel.org/r/20170714120720.906842-22-arnd@arndb.de
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 8185f57
| File | Mode | Size |
|---|---|---|
| .gitignore | -rw-r--r-- | 20 bytes |
| 00-INDEX | -rw-r--r-- | 1.4 KB |
| active_mm.txt | -rw-r--r-- | 3.7 KB |
| balance | -rw-r--r-- | 5.2 KB |
| cleancache.txt | -rw-r--r-- | 13.8 KB |
| frontswap.txt | -rw-r--r-- | 15.0 KB |
| highmem.txt | -rw-r--r-- | 5.7 KB |
| hmm.txt | -rw-r--r-- | 18.1 KB |
| hugetlbfs_reserv.txt | -rw-r--r-- | 28.1 KB |
| hugetlbpage.txt | -rw-r--r-- | 16.8 KB |
| hwpoison.txt | -rw-r--r-- | 5.8 KB |
| idle_page_tracking.txt | -rw-r--r-- | 4.8 KB |
| ksm.txt | -rw-r--r-- | 10.2 KB |
| numa | -rw-r--r-- | 8.5 KB |
| numa_memory_policy.txt | -rw-r--r-- | 22.6 KB |
| overcommit-accounting | -rw-r--r-- | 2.5 KB |
| page_frags | -rw-r--r-- | 2.2 KB |
| page_migration | -rw-r--r-- | 11.4 KB |
| page_owner.txt | -rw-r--r-- | 3.7 KB |
| pagemap.txt | -rw-r--r-- | 6.8 KB |
| remap_file_pages.txt | -rw-r--r-- | 1.5 KB |
| slub.txt | -rw-r--r-- | 12.9 KB |
| soft-dirty.txt | -rw-r--r-- | 1.7 KB |
| split_page_table_lock | -rw-r--r-- | 3.5 KB |
| swap_numa.txt | -rw-r--r-- | 2.9 KB |
| transhuge.txt | -rw-r--r-- | 22.8 KB |
| unevictable-lru.txt | -rw-r--r-- | 29.5 KB |
| userfaultfd.txt | -rw-r--r-- | 11.2 KB |
| z3fold.txt | -rw-r--r-- | 1.2 KB |
| zsmalloc.txt | -rw-r--r-- | 3.0 KB |
| zswap.txt | -rw-r--r-- | 5.2 KB |
Computing file changes ...
