Revision ebff65473f56e6c30de928fd6a4f1ce5ae36e8c5 authored by Shawn Guo on 02 December 2013, 05:26:50 UTC, committed by Mark Brown on 02 December 2013, 11:50:53 UTC
Since devm_card_release() expects parameter 'res' to be a pointer to struct snd_soc_card, devm_snd_soc_register_card() should really pass such a pointer rather than the one to struct device. This bug causes the kernel Oops below with imx-sgtl500 driver when we remove the module. It happens because with 'card' pointing to the wrong structure, card->num_rtd becomes 0 in function soc_remove_dai_links(). Consequently, soc_remove_link_components() and in turn soc_cleanup_codec[platform]_debugfs() will not be called on card removal. It results in that debugfs_card_root is being removed while its child entries debugfs_codec_root and debugfs_platform_root are still there, and thus the kernel Oops. Fix the bug by correcting the parameter 'res' to be the pointer to struct snd_soc_card. $ lsmod Module Size Used by snd_soc_imx_sgtl5000 3506 0 snd_soc_sgtl5000 13677 2 snd_soc_imx_audmux 5324 1 snd_soc_imx_sgtl5000 snd_soc_fsl_ssi 8139 2 imx_pcm_dma 1380 1 snd_soc_fsl_ssi $ rmmod snd_soc_imx_sgtl5000 Unable to handle kernel paging request at virtual address e594025c pgd = be134000 [e594025c] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Modules linked in: snd_soc_imx_sgtl5000(-) snd_soc_sgtl5000 snd_soc_imx_audmux snd_soc_fsl_ssi imx_pcm_dma CPU: 0 PID: 1793 Comm: rmmod Not tainted 3.13.0-rc1 #1570 task: bee28900 ti: bfbec000 task.ti: bfbec000 PC is at debugfs_remove_recursive+0x28/0x154 LR is at snd_soc_unregister_card+0xa0/0xcc pc : [<80252b38>] lr : [<80496ac4>] psr: a0000013 sp : bfbede00 ip : bfbede28 fp : bfbede24 r10: 803281d4 r9 : bfbec000 r8 : 803271ac r7 : bef54440 r6 : 00000004 r5 : bf9a4010 r4 : bf9a4010 r3 : e5940224 r2 : 00000000 r1 : bef54450 r0 : 803271ac Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user Control: 10c53c7d Table: 4e13404a DAC: 00000015 Process rmmod (pid: 1793, stack limit = 0xbfbec240) Stack: (0xbfbede00 to 0xbfbee000) de00: 00000000 bf9a4010 bf9a4010 00000004 bef54440 bec89000 bfbede44 bfbede28 de20: 80496ac4 80252b1c 804a4b60 bfbede60 bf9a4010 00000004 bfbede54 bfbede48 de40: 804a4b74 80496a30 bfbede94 bfbede58 80328728 804a4b6c bfbede94 a0000013 de60: bf1b5800 bef54440 00000002 bf9a4010 7f0169f8 bf9a4044 00000081 8000e9c4 de80: bfbec000 00000000 bfbedeac bfbede98 80328cb0 80328618 7f016000 bf9a4010 dea0: bfbedec4 bfbedeb0 8032561c 80328c84 bf9a4010 7f0169f8 bfbedee4 bfbedec8 dec0: 80325e84 803255a8 bee28900 7f0169f8 00000000 78208d30 bfbedefc bfbedee8 dee0: 80325410 80325dd4 beca8100 7f0169f8 bfbedf14 bfbedf00 803264f8 803253c8 df00: 7f01635c 7f016a3c bfbedf24 bfbedf18 80327098 803264d4 bfbedf34 bfbedf28 df20: 7f016370 80327090 bfbedfa4 bfbedf38 80085ef0 7f016368 bfbedf54 5f646e73 df40: 5f636f73 5f786d69 6c746773 30303035 00000000 78208008 bfbedf84 bfbedf68 df60: 800613b0 80061194 fffffffe 78208d00 7efc2f07 00000081 7f016a3c 00000800 df80: bfbedf84 00000000 00000000 fffffffe 78208d00 7efc2f07 00000000 bfbedfa8 dfa0: 8000e800 80085dcc fffffffe 78208d00 78208d30 00000800 a8c82400 a8c82400 dfc0: fffffffe 78208d00 7efc2f07 00000081 00000002 00000000 78208008 00000800 dfe0: 7efc2e1c 7efc2ba8 76f5ca47 76edec7c 80000010 78208d30 00000000 00000000 Backtrace: [<80252b10>] (debugfs_remove_recursive+0x0/0x154) from [<80496ac4>] (snd_soc_unregister_card+0xa0/0xcc) r8:bec89000 r7:bef54440 r6:00000004 r5:bf9a4010 r4:bf9a4010 r3:00000000 [<80496a24>] (snd_soc_unregister_card+0x0/0xcc) from [<804a4b74>] (devm_card_release+0x14/0x18) r6:00000004 r5:bf9a4010 r4:bfbede60 r3:804a4b60 [<804a4b60>] (devm_card_release+0x0/0x18) from [<80328728>] (release_nodes+0x11c/0x1dc) [<8032860c>] (release_nodes+0x0/0x1dc) from [<80328cb0>] (devres_release_all+0x38/0x54) [<80328c78>] (devres_release_all+0x0/0x54) from [<8032561c>] (__device_release_driver+0x80/0xd4) r4:bf9a4010 r3:7f016000 [<8032559c>] (__device_release_driver+0x0/0xd4) from [<80325e84>] (driver_detach+0xbc/0xc0) r5:7f0169f8 r4:bf9a4010 [<80325dc8>] (driver_detach+0x0/0xc0) from [<80325410>] (bus_remove_driver+0x54/0x98) r6:78208d30 r5:00000000 r4:7f0169f8 r3:bee28900 [<803253bc>] (bus_remove_driver+0x0/0x98) from [<803264f8>] (driver_unregister+0x30/0x50) r4:7f0169f8 r3:beca8100 [<803264c8>] (driver_unregister+0x0/0x50) from [<80327098>] (platform_driver_unregister+0x14/0x18) r4:7f016a3c r3:7f01635c [<80327084>] (platform_driver_unregister+0x0/0x18) from [<7f016370>] (imx_sgtl5000_driver_exit+0x14/0x1c [snd_soc_imx_sgtl5000]) [<7f01635c>] (imx_sgtl5000_driver_exit+0x0/0x1c [snd_soc_imx_sgtl5000]) from [<80085ef0>] (SyS_delete_module+0x130/0x18c) [<80085dc0>] (SyS_delete_module+0x0/0x18c) from [<8000e800>] (ret_fast_syscall+0x0/0x48) r6:7efc2f07 r5:78208d00 r4:fffffffe Code: 889da9f8 e5983020 e3530000 089da9f8 (e5933038) ---[ end trace 825e7e125251a225 ]--- Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org>
1 parent 8f1ec93
File | Mode | Size |
---|---|---|
ac97_codec.h | -rw-r--r-- | 28.2 KB |
aci.h | -rw-r--r-- | 2.4 KB |
ad1816a.h | -rw-r--r-- | 5.4 KB |
ad1843.h | -rw-r--r-- | 1.5 KB |
adau1373.h | -rw-r--r-- | 699 bytes |
aess.h | -rw-r--r-- | 1.6 KB |
ak4113.h | -rw-r--r-- | 10.6 KB |
ak4114.h | -rw-r--r-- | 9.9 KB |
ak4117.h | -rw-r--r-- | 9.0 KB |
ak4531_codec.h | -rw-r--r-- | 3.1 KB |
ak4641.h | -rw-r--r-- | 622 bytes |
ak4xxx-adda.h | -rw-r--r-- | 3.3 KB |
alc5623.h | -rw-r--r-- | 497 bytes |
asequencer.h | -rw-r--r-- | 3.6 KB |
asound.h | -rw-r--r-- | 1.3 KB |
asoundef.h | -rw-r--r-- | 16.7 KB |
atmel-abdac.h | -rw-r--r-- | 626 bytes |
atmel-ac97c.h | -rw-r--r-- | 1.4 KB |
compress_driver.h | -rw-r--r-- | 6.2 KB |
control.h | -rw-r--r-- | 8.3 KB |
core.h | -rw-r--r-- | 15.5 KB |
cs4231-regs.h | -rw-r--r-- | 8.3 KB |
cs4271.h | -rw-r--r-- | 1.4 KB |
cs42l52.h | -rw-r--r-- | 854 bytes |
cs42l73.h | -rw-r--r-- | 507 bytes |
cs8403.h | -rw-r--r-- | 8.6 KB |
cs8427.h | -rw-r--r-- | 10.3 KB |
da7213.h | -rw-r--r-- | 1.2 KB |
da9055.h | -rw-r--r-- | 914 bytes |
designware_i2s.h | -rw-r--r-- | 2.0 KB |
dmaengine_pcm.h | -rw-r--r-- | 5.5 KB |
emu10k1.h | -rw-r--r-- | 89.3 KB |
emu10k1_synth.h | -rw-r--r-- | 1.3 KB |
emu8000.h | -rw-r--r-- | 4.0 KB |
emu8000_reg.h | -rw-r--r-- | 10.2 KB |
emux_legacy.h | -rw-r--r-- | 5.4 KB |
emux_synth.h | -rw-r--r-- | 7.5 KB |
es1688.h | -rw-r--r-- | 3.6 KB |
gus.h | -rw-r--r-- | 20.3 KB |
hda_hwdep.h | -rw-r--r-- | 1.4 KB |
hwdep.h | -rw-r--r-- | 2.6 KB |
i2c.h | -rw-r--r-- | 3.5 KB |
info.h | -rw-r--r-- | 7.1 KB |
initval.h | -rw-r--r-- | 3.1 KB |
jack.h | -rw-r--r-- | 2.6 KB |
l3.h | -rw-r--r-- | 287 bytes |
max9768.h | -rw-r--r-- | 729 bytes |
max98088.h | -rw-r--r-- | 1.3 KB |
max98090.h | -rw-r--r-- | 754 bytes |
max98095.h | -rw-r--r-- | 1.5 KB |
memalloc.h | -rw-r--r-- | 4.7 KB |
minors.h | -rw-r--r-- | 4.3 KB |
mixer_oss.h | -rw-r--r-- | 2.4 KB |
mpu401.h | -rw-r--r-- | 4.5 KB |
opl3.h | -rw-r--r-- | 12.4 KB |
opl4.h | -rw-r--r-- | 1.1 KB |
pcm-indirect.h | -rw-r--r-- | 5.6 KB |
pcm.h | -rw-r--r-- | 39.7 KB |
pcm_oss.h | -rw-r--r-- | 2.6 KB |
pcm_params.h | -rw-r--r-- | 8.2 KB |
pt2258.h | -rw-r--r-- | 1.2 KB |
pxa2xx-lib.h | -rw-r--r-- | 1.5 KB |
rawmidi.h | -rw-r--r-- | 6.1 KB |
rcar_snd.h | -rw-r--r-- | 1.7 KB |
rt5640.h | -rw-r--r-- | 514 bytes |
s3c24xx_uda134x.h | -rw-r--r-- | 212 bytes |
sb.h | -rw-r--r-- | 11.1 KB |
sb16_csp.h | -rw-r--r-- | 2.7 KB |
seq_device.h | -rw-r--r-- | 2.5 KB |
seq_kernel.h | -rw-r--r-- | 4.2 KB |
seq_midi_emul.h | -rw-r--r-- | 7.3 KB |
seq_midi_event.h | -rw-r--r-- | 2.2 KB |
seq_oss.h | -rw-r--r-- | 2.9 KB |
seq_oss_legacy.h | -rw-r--r-- | 1.0 KB |
seq_virmidi.h | -rw-r--r-- | 2.7 KB |
sh_dac_audio.h | -rw-r--r-- | 587 bytes |
sh_fsi.h | -rw-r--r-- | 847 bytes |
simple_card.h | -rw-r--r-- | 831 bytes |
snd_wavefront.h | -rw-r--r-- | 5.5 KB |
soc-dai.h | -rw-r--r-- | 9.1 KB |
soc-dapm.h | -rw-r--r-- | 26.6 KB |
soc-dpcm.h | -rw-r--r-- | 3.7 KB |
soc.h | -rw-r--r-- | 39.9 KB |
soundfont.h | -rw-r--r-- | 4.5 KB |
spear_dma.h | -rw-r--r-- | 1.0 KB |
spear_spdif.h | -rw-r--r-- | 1010 bytes |
sta32x.h | -rw-r--r-- | 912 bytes |
tas5086.h | -rw-r--r-- | 171 bytes |
tea6330t.h | -rw-r--r-- | 1.1 KB |
timer.h | -rw-r--r-- | 5.4 KB |
tlv.h | -rw-r--r-- | 4.0 KB |
tlv320aic32x4.h | -rw-r--r-- | 900 bytes |
tlv320aic3x.h | -rw-r--r-- | 1.9 KB |
tlv320dac33-plat.h | -rw-r--r-- | 720 bytes |
tpa6130a2-plat.h | -rw-r--r-- | 900 bytes |
uda134x.h | -rw-r--r-- | 1.2 KB |
uda1380.h | -rw-r--r-- | 481 bytes |
util_mem.h | -rw-r--r-- | 2.3 KB |
vx_core.h | -rw-r--r-- | 15.4 KB |
wavefront.h | -rw-r--r-- | 18.8 KB |
wm0010.h | -rw-r--r-- | 679 bytes |
wm1250-ev1.h | -rw-r--r-- | 656 bytes |
wm2000.h | -rw-r--r-- | 625 bytes |
wm2200.h | -rw-r--r-- | 1.5 KB |
wm5100.h | -rw-r--r-- | 1.2 KB |
wm8903.h | -rw-r--r-- | 15.2 KB |
wm8904.h | -rw-r--r-- | 7.4 KB |
wm8955.h | -rw-r--r-- | 662 bytes |
wm8960.h | -rw-r--r-- | 603 bytes |
wm8962.h | -rw-r--r-- | 1.8 KB |
wm8993.h | -rw-r--r-- | 1.2 KB |
wm8996.h | -rw-r--r-- | 1.4 KB |
wm9081.h | -rw-r--r-- | 661 bytes |
wm9090.h | -rw-r--r-- | 780 bytes |
wss.h | -rw-r--r-- | 8.5 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...