| ec35b03 | Rune Lillesveen | 29 June 2018, 22:17:37 UTC | [Squad] Generate ::before/::after/::backdrop in style recalc. We used to create these pseudo elements and their computed styles in Element::AttachLayoutTree when building the layout tree. Now we create or dispose these elements from style recalc, that is, UpdatePseudoElement. To make pseudo elements live through a style recalc with a layout tree re-attach we no longer clear the pseudo elements during DetachLayoutTree for performing_reattach=true. We do however need to clear the pseudo elements which do not get a layout object for the re-attach. That is done in AttachLayoutTree for the originating element when the originating element does not generate a layout box. We stop using the pseudo style cache on ComputedStyle for PseudoElements and instead return the ComputedStyle when creating the pseudo element and store it as non-attached style which can later be retrieved when attaching the layout object. An effect of this change is that we can detect transitions on pseudo elements when ancestors display types changes and causes re-attachment. That is issue 836140. ::first-letter may still be generated during layout tree building, and the ::first-letter layout structure may still be updated during style recalc. Bug: 836126, 836140 Change-Id: Iafad705b7a7b988d4c1598e8a126ce0d79c5873d Reviewed-on: https://chromium-review.googlesource.com/1112244 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571665} | 29 June 2018, 22:26:52 UTC |
| c360ca0 | Koji Ishii | 29 June 2018, 21:50:07 UTC | [LayoutNG] Allow epsilon when fitting into a line When NGLineBreaker tries to fit items into a line, rounding errors are hard to avoid. One case is to fit `monospace` font into a container whose `width` is set by `ch` unit. Blink computes `ch` units in float, then round to LayoutUnit. This rounding often prevents the specified number of characters to fit into the line. All 4 impls pass this test for `3ch` to `100ch`. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9fe68a8bb44820aa15c7eb8c564776688c8320ee Reviewed-on: https://chromium-review.googlesource.com/1116409 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#571642} | 29 June 2018, 21:59:50 UTC |
| 8b8082f | jugglinmike | 29 June 2018, 17:28:24 UTC | [testdriver.js] Implement `bless` method (#11511) A common use case for the testdriver.js library is to create a task that was triggered by user interaction [1]. Doing so using the current API requires a fair amount of logic which is unrelated to the behavior under test. This has a number of drawbacks: - it makes tests less descriptive - it makes tests less uniform both in terms of implementation and in terms of user experience (in non-automated scenarios, human operators may be prompted to provide the necessary input) - it makes tests more susceptible to bugs Define a utility method as a consistent and concise way to facilitate the common use case. Require descriptive text via the `intent` parameter in order to encourage test authors to explicitly describe the rationale for requesting additional privileges. [1] https://html.spec.whatwg.org/#triggered-by-user-activation | 29 June 2018, 17:28:24 UTC |
| 02cfdfe | Rune Lillesveen | 29 June 2018, 16:53:44 UTC | Make sure stacking context is always updated for ::first-letter. ::first-letter sadly has at least three code paths for computing its computed style. Two of them were lacking stacking context update. There is work in progress for Squad to mend this, but let's fix the current code paths for now. Bug: 856806 Change-Id: Ifeea799643bfa266e58c948f476bc23481fcdd5e Reviewed-on: https://chromium-review.googlesource.com/1120249 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571512} | 29 June 2018, 17:11:19 UTC |
| 7706fe6 | Luke Bjerring | 29 June 2018, 16:07:09 UTC | Update trivial IDL changes (#11732) | 29 June 2018, 16:07:09 UTC |
| 7567605 | Ms2ger | 29 June 2018, 15:02:49 UTC | Fix make_hosts_file tests in python 3. (#11727) | 29 June 2018, 15:02:49 UTC |
| 4512702 | Luke Bjerring | 29 June 2018, 13:37:17 UTC | Update payment-handler IDL file (#9796) | 29 June 2018, 13:37:17 UTC |
| d2986bb | Geoffrey Sneddon | 29 June 2018, 12:16:51 UTC | Add reviewers for css/css-box (#11710) | 29 June 2018, 12:16:51 UTC |
| b0bc380 | Ms2ger | 29 June 2018, 12:03:24 UTC | Support python 3 in InputFile. (#11729) | 29 June 2018, 12:03:24 UTC |
| e639f5b | Emilio Cobos Álvarez | 28 June 2018, 18:09:06 UTC | Allow specifying the mozilla tree via argument. | 29 June 2018, 11:26:26 UTC |
| 8b61c28 | Emilio Cobos Álvarez | 28 June 2018, 18:07:07 UTC | Make sync-tests.sh work with git. | 29 June 2018, 11:26:26 UTC |
| b23f2ac | Luke Bjerring | 28 June 2018, 00:34:18 UTC | Update the WebIDL file | 29 June 2018, 11:26:03 UTC |
| dc30257 | Emilio Cobos Álvarez | 28 June 2018, 18:14:22 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/6041c030780420b6205cf2d6640513606609884c This contains two changes: * One by Mihir Iyer from [bug 1398483](https://bugzil.la/1398483), reviewed by @dholbert, adding flexbox column-{row,gap} reftests. * One by myself from [bug 1464782](https://bugzil.la/1464782), replacing the usage of offset-* logical properties by the standard name inset-*, reviewed by @upsuper. | 29 June 2018, 11:24:41 UTC |
| a4b7841 | Ms2ger | 29 June 2018, 10:00:39 UTC | Prepare ReplacementTokenizer for Python 3 (#11685) | 29 June 2018, 10:00:39 UTC |
| 36fb033 | Henrik Boström | 29 June 2018, 09:09:04 UTC | Update external/wpt/webrtc/RTCRtpParameters* tests. This is in preparation for get/setParameters[1] and RTCRtpTransceiver[2]. Tests are updated to use promise_test and async/await to make them easier to write and to execute sequentially. Tests are updated to set up a call before getParameters() because many parameters are defined as "that has been negotiated". If we want to test what is returned before negotiation we should add that as separate tests. For now, this is necessary for the tests to run on [1][2]. Some tests are removed because they no longer reflect the spec. Because get/setParameters() and RTCRtpTransceiver has not landed yet, the tests are still expected to fail. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1102436 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771 Bug: 803494, 777617 Change-Id: I3f14a37925837576a602d91bb67e48181c56a946 Reviewed-on: https://chromium-review.googlesource.com/1102502 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#571430} | 29 June 2018, 09:17:37 UTC |
| a2c108f | Hiroki Nakagawa | 29 June 2018, 04:07:03 UTC | Worker: Add WPTs for module loading with blob, data, and file URLs Bug: 680046 Change-Id: I8b3894bfbc8df999952fa82e8f2b3abb4088f434 Reviewed-on: https://chromium-review.googlesource.com/1114566 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#571378} | 29 June 2018, 04:33:57 UTC |
| 7a6f567 | Geoffrey Sneddon | 28 June 2018, 22:28:05 UTC | Revert "Lint that META.yml files exist (#11092)" (#11723) This reverts commit 93dceabca4f79ced2a35fa480f78d30d4123ffaa. | 28 June 2018, 22:28:05 UTC |
| 535f7e1 | Luke Bjerring | 28 June 2018, 22:07:09 UTC | Auto-update the DOM-Parsing IDL file (#11720) | 28 June 2018, 22:07:09 UTC |
| 93dceab | Simon Pieters | 28 June 2018, 17:29:40 UTC | Lint that META.yml files exist (#11092) Fixes #10552. | 28 June 2018, 17:29:40 UTC |
| a6ea08f | Geoffrey Sneddon | 28 June 2018, 16:50:15 UTC | Add css-env reviewers (#11709) | 28 June 2018, 16:50:15 UTC |
| 04cccd1 | Simon Pieters | 28 June 2018, 15:55:21 UTC | Add lifecycle/META.yml (#11559) | 28 June 2018, 15:55:21 UTC |
| d60079a | Ian Clelland | 27 June 2018, 21:51:45 UTC | Update links to feature policy documentation. The documentation in the Feature Policy spec repository was moved to the 'master' branch from the 'gh-pages' branch. This updates several references in the Chromium codebase with the new locations. TBR=kinuko To-be-reviewed-by: kinuko@chromium.org Bug: 857055 Change-Id: I10b4c55608a218b1767a4990832d86e460cd37d5 Reviewed-on: https://chromium-review.googlesource.com/1116868 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#570906} | 28 June 2018, 15:22:05 UTC |
| fdc6e08 | Ehsan Karamad | 28 June 2018, 14:54:59 UTC | Mark a vertical-scroll test as 'slow' The test has been previously disabled (skipped) on Windows due to recurrent timeouts. Running the test locally leads to an average of ~ 3.7 sec runtime on a high-performance Windows 10 rig (Z840). The test is not skipped on Linux right now, but since its runtime exceeds the 2 sec rule of thumb (from the comments in SlowTests), this CL will make it slow on Linux as well. Bug: 850964 Change-Id: Ib478c0f59313da4302325578d9b768e1070bdcb6 Reviewed-on: https://chromium-review.googlesource.com/1115214 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571116} | 28 June 2018, 15:04:24 UTC |
| 9704386 | Ms2ger | 28 June 2018, 12:46:12 UTC | Support python 3 in wptserve.config.Config. (#11692) | 28 June 2018, 12:46:12 UTC |
| e7aa302 | Aleks Totic | 28 June 2018, 11:42:37 UTC | [LayoutNG] bugfix for NG painting in vertical-rl with scrollbars. This bug occurs when painting NG child inside non-inline vertical-rl parent with scrollbars. Root cause is extra scrollbar offset that Paint applies to Legacy painting that is not needed for NG. The fix is hacky: NG applies reverse offset. This fix does not make any additional tests pass or fail. Bug: 852395 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7dda2cdbf682485ab30c048987ae683981731886 Reviewed-on: https://chromium-review.googlesource.com/1115863 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571080} | 28 June 2018, 11:51:43 UTC |
| aed0e09 | Yusuf Sermet | 28 June 2018, 02:10:32 UTC | Fix a contain:paint web platform test by addressing an inconsistency between testcase & reference case. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1471452 gecko-commit: 5b2c8eebbb03e63de0788988275f2f4a31825980 gecko-integration-branch: autoland gecko-reviewers: dholbert | 28 June 2018, 11:21:28 UTC |
| 1942276 | Luke Bjerring | 28 June 2018, 09:53:01 UTC | Update the webappsec-subresource-integrity IDL file (#9849) * Add webappsec-subresource-integrity idl file * Updated webappsec-subresource-integrity IDL file * Add test | 28 June 2018, 09:53:01 UTC |
| 89e834c | Luke Bjerring | 28 June 2018, 09:51:38 UTC | Update the webappsec-credential-management IDL file (#9844) * Add webappsec-credential-management idl file * Updated webappsec-credential-management IDL file * Clean up tests | 28 June 2018, 09:51:38 UTC |
| e347325 | Eric Willigers | 28 June 2018, 09:49:38 UTC | Merge pull request #11613 from ewilligers/css-writing-modes-parsing [css-writing-modes] Parsing of writing modes properties | 28 June 2018, 09:49:38 UTC |
| 12b9b4c | Morten Stenshorne | 28 June 2018, 09:28:19 UTC | [LayoutNG] Non-"inline" abspos needs to ignore floats and text-indent. This fixes two tests, but will also eventually benefit floats-wrap-inside-inline-00[1234].htm in fast/block/float/, which are currently passing because the absolutely positioned box in the test forces its container to have block children. There's special-code for NG (which we should remove) in LayoutBlockFlow::AddChild() that forces this (and causes other problems). Added a new test, to make it clear what this fix is about. Bug: 734554 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia2c0e0b2ab61999207114fdf935880fabc2e677c Reviewed-on: https://chromium-review.googlesource.com/1116959 Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571054} | 28 June 2018, 09:37:17 UTC |
| 484872d | Emilio Cobos Álvarez | 27 June 2018, 14:38:34 UTC | Rename offset-* logical properties to inset-*. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1464782 gecko-commit: 7be80c866e8421fca8d879e7b08eb1b0254928fa gecko-integration-branch: mozilla-inbound gecko-reviewers: xidorn | 28 June 2018, 01:12:22 UTC |
| 5392b81 | Victor Costan | 28 June 2018, 00:39:01 UTC | Async Cookies: Implement sameSite attribute. This CL modifies RestrictedCookieManager to allow renderers to set the SameSite and Priority CanonicalCookie attributes. Renderers must be allowed to set the SameSite and Priority attributes so that RestrictedCookieManager can be used to implement the document.cookie setter. Bug: 856364, 729800 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic0a520bc6c02c259ef22175c9eb161086fa18782 Reviewed-on: https://chromium-review.googlesource.com/1115586 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570976} | 28 June 2018, 00:48:04 UTC |
| 4d9bf95 | Raymond Toy | 27 June 2018, 20:46:45 UTC | Move AudioBufferSourceNode tests to WPT These tests basically pass on Firefox. If they don't, it's because Firefox is incorrect and issues have been filed for these. During the testing, we discovered that an incorrect assumption was made that calling start() would always work. Because of test failures in Firefox, this assumption is incorrect. Updated audit.js to latest Chrome version (to get loadFileFromURL) and add wpt lint exception for a console message in audit.js. Needed to update audiocontext-getoutputtimestamp.html to make bots happy because the AudioContext is running now on the bots, so time is progressing, so the time stamps aren't always zero. Bug: 745778 Change-Id: I5f9ee01498678db0feb57051f682772ca7bd9fbb Reviewed-on: https://chromium-review.googlesource.com/1040865 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570890} | 27 June 2018, 22:43:12 UTC |
| bb801df | Geoffrey Sneddon | 27 June 2018, 20:03:42 UTC | Test for all: initial on unknown :root (#11682) | 27 June 2018, 20:03:42 UTC |
| 4a983bf | jugglinmike | 27 June 2018, 18:03:05 UTC | [wptrunner] Correct profile installation for Fx 61 (#11693) Extend the profile installation logic to account for a transitional phase in the format of the Firefox profile directory. More detail is available at: https://bugzilla.mozilla.org/show_bug.cgi?id=1471419 | 27 June 2018, 18:03:05 UTC |
| 0b578c1 | youennf | 27 June 2018, 17:38:12 UTC | Merge pull request #11666 from youennf/wpt-export-for-webkit-187030 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=187030 | 27 June 2018, 17:38:12 UTC |
| b0f0ef9 | Mustaq Ahmed | 27 June 2018, 15:33:46 UTC | Fix the clicked iframe in two wpt fullscreen tests. With User Activation v2, activating a parent frame doesn't activate its subframes. We fixed these two tests by sending the click to subframes. This needed a workaround in auto-click.js because the mutation observer there in doesn't seem to work when a button element is added to a subframe. Bug: 802371 Change-Id: I786668c87b802565e99ad16223cafc8ac1fd6296 Reviewed-on: https://chromium-review.googlesource.com/868323 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570778} | 27 June 2018, 15:42:47 UTC |
| b44c265 | Hwanseung Lee | 27 June 2018, 14:54:34 UTC | [WebAudio] throw an error when buffer has been already set. should throw an InvalidStateError when buffer has been already set in ConvolverNode Bug: 709656 Change-Id: Ia0826f9ffa2e180da1311f4cded8ff7fe5461147 Reviewed-on: https://chromium-review.googlesource.com/1077713 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#570767} | 27 June 2018, 15:05:01 UTC |
| 2a423b0 | Koji Ishii | 27 June 2018, 13:14:53 UTC | Add test for the removal of trailing spaces when preceding <br> Blink and WebKit fails to remove trailing spaces preceding `<br>`. This patch adds a test for that case. Gecko, Edge, and the current build of LayoutNG passes this test. This was originally reported at http://crbug.com/40634. It turns out that fast/text/emphasis-overlap.html relies on this behavior. Before removing the reliance, adding this test to ensure this case is covered and to prevent regressions in LayoutNG. TBR=eae@chromium.org Bug: 40634 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iff877bac1c27c8689bdbc6949d01a9ea380463bd Reviewed-on: https://chromium-review.googlesource.com/1116622 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570744} | 27 June 2018, 13:23:13 UTC |
| 783a219 | Philipp Hancke | 27 June 2018, 11:17:57 UTC | webrtc wpt: stop tracks returned from getUserMedia stops tracks acquired from getUserMedia BUG=836871 Change-Id: I828189da35b0c842078cdd4c1b4b38f7e7fbf355 Reviewed-on: https://chromium-review.googlesource.com/1113450 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570727} | 27 June 2018, 11:28:13 UTC |
| a8d56db | Geoffrey Sneddon | 27 June 2018, 10:11:59 UTC | Start running wptserve/serve tests on Py3 (#11669) While this may seem pointless when almost all of them are marked as xfail on Py3, it does at least mean we have to keep them importable and should mean we don't regress code that currently works on Py3. | 27 June 2018, 10:11:59 UTC |
| dcc9962 | Victor Costan | 27 June 2018, 02:16:40 UTC | Async Cookies: The API is only available on secure origins. Bug: 856362 Change-Id: Icaddfb82b2c41924cca7f058dea2e8da03183ae9 Reviewed-on: https://chromium-review.googlesource.com/1114379 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570628} | 27 June 2018, 02:38:09 UTC |
| adf8392 | Ben Kelly | 23 June 2018, 17:17:11 UTC | Fix performance-timeline.https.html to not timeout if bufferfull event is not fired in service worker. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1469988 gecko-commit: c74adc90978c1a2182fc89909499e9d4c3075c1f gecko-integration-branch: mozilla-inbound gecko-reviewers: mrbkap | 27 June 2018, 02:26:56 UTC |
| 865d9b4 | Geoffrey Sneddon | 27 June 2018, 02:17:51 UTC | Loosen assumptions so actual implementations match them (#11677) | 27 June 2018, 02:17:51 UTC |
| 8780e84 | Dominic Farolino | 27 June 2018, 01:56:48 UTC | Correctly generate <script> referrerPolicy tests (#11671) | 27 June 2018, 01:56:48 UTC |
| 79f334b | Marcos Cáceres | 27 June 2018, 00:29:15 UTC | fix: missing closing script tags (#11680) | 27 June 2018, 00:29:15 UTC |
| cf0bcea | Luke Bjerring | 26 June 2018, 21:53:45 UTC | Auto-update the image-capture IDL file (#11674) | 26 June 2018, 21:53:45 UTC |
| e1cdfb8 | Luke Bjerring | 26 June 2018, 21:28:03 UTC | Update the permissions IDL file (#9810) | 26 June 2018, 21:28:03 UTC |
| cea6203 | Simon Pieters | 23 June 2018, 19:54:44 UTC | Refactor and split up quirks tests The unitless-length test was a flaky timeout in chromium. https://bugs.chromium.org/p/chromium/issues/detail?id=646133 | 26 June 2018, 19:44:27 UTC |
| f240b8f | Jacob Trimble | 26 June 2018, 19:07:20 UTC | [encrypted-media] Add segmented clear-to-encrypted test. (#11308) This adds a test that tests transitioning from clear to encrypted content when it appears in different segments. This can happen when streaming and the first content is a clear ad and the encrypted content will be appended later. This kind of content wasn't playable on Firefox until recently and I think this wouldn't work on Edge if they supported clear-key. https://bugzilla.mozilla.org/show_bug.cgi?id=1454630 | 26 June 2018, 19:07:20 UTC |
| e50750a | Marcos Cáceres | 26 June 2018, 18:37:51 UTC | immediate repeated calls to .complete() (#11665) | 26 June 2018, 18:37:51 UTC |
| 829ef55 | Simon Pieters | 04 June 2018, 20:03:57 UTC | Shadow DOM: Run the next test even if the current fails Part of #11269. | 26 June 2018, 18:07:24 UTC |
| 3aaef8d | Zirro | 26 June 2018, 17:27:39 UTC | The hashchange event should not bubble This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: https://github.com/whatwg/html/pull/3737. Other tests were changed to reflect this in https://github.com/web-platform-tests/wpt/pull/11355. | 26 June 2018, 17:27:39 UTC |
| 6ac7b64 | L. David Baron | 26 June 2018, 15:57:27 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/ca98b6f47b4e33673291a4dc2a4ebca28ce6db00 . (#11670) | 26 June 2018, 15:57:27 UTC |
| 8de3fcb | Emilio Cobos Álvarez | 25 June 2018, 20:25:17 UTC | Test updates. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1422225 gecko-commit: 24575413384ae7a49bafb9fb398d348eeda5e597 gecko-integration-branch: mozilla-inbound gecko-reviewers: xidorn | 26 June 2018, 15:18:19 UTC |
| d7d545a | Ms2ger | 26 June 2018, 12:39:43 UTC | Fix Python 3 errors when doing ./wpt make-hosts-file (#11516) | 26 June 2018, 12:39:43 UTC |
| cc6c95d | Žan Doberšek | 26 June 2018, 11:11:45 UTC | webkit: GTK port should whitelist the web-platform.test host certificate (#11615) For testing purposes, the TLS certificate for the web-platform.test host should be whitelisted for the GTK port of WebKit in order to avoid TLS errors when loading test cases via HTTPS. This is done by listing the host and certificate file path pair in the port-specific capabilities. This pair is then used for whitelisting the certificate for the given host in the WebDriver-automated browsing session. | 26 June 2018, 11:11:45 UTC |
| 04cd06d | Kagami Sascha Rosylight | 26 June 2018, 10:28:35 UTC | remove noqa annotation | 26 June 2018, 10:28:35 UTC |
| 0a3e5fa | Rakina Zata Amni | 26 June 2018, 08:30:43 UTC | Implement Element.toggleAttribute Add a new method Element.toggleAttribute(string qualifiedName, optional bool force) that allow toggling the existence of an element’s attribute, similar to Element.classList.toggle. Spec https://dom.spec.whatwg.org/#dom-element-toggleattribute Intent to Implement and Ship https://groups.google.com/a/chromium.org/d/msg/blink-dev/mAWBTaANvmE/OgaCRH04BAAJ Bug: 854960 Change-Id: Iab8a1a97dd4e2f8b377bcf590401699f9013aa8a Reviewed-on: https://chromium-review.googlesource.com/1111761 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#570348} | 26 June 2018, 08:39:10 UTC |
| c08dc4d | Manuel Rego Casasnovas | 26 June 2018, 05:49:37 UTC | Merge pull request #11661 from Loirooriol/css-logical-border-shorthands Add tests for some logical border shorthand properties | 26 June 2018, 05:49:37 UTC |
| df5463e | Youenn Fablet | 26 June 2018, 03:11:23 UTC | WebKit export of https://bugs.webkit.org/show_bug.cgi?id=187030 | 26 June 2018, 03:11:23 UTC |
| cf4a6e9 | Makoto Shimazu | 26 June 2018, 02:26:34 UTC | Add a layout test for redirects with referrer-policy via service worker Redirects with referrer-policy header need to respect a new referrer policy. This tries to check if it's working when the request is in a service worker's scope. Bug: 855948 Change-Id: Icb923fa8b8345c128f02c41e042775ba5bf499ad Reviewed-on: https://chromium-review.googlesource.com/1113171 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570298} | 26 June 2018, 02:36:09 UTC |
| c390a6a | Eric Willigers | 26 June 2018, 02:19:02 UTC | Merge pull request #11647 from ewilligers/css-box-3-parsing [css-box] Parsing tests for CSS Box properties | 26 June 2018, 02:19:02 UTC |
| 83c3363 | Sandra Sun | 26 June 2018, 00:25:02 UTC | Allows panning inside overflowing snap areas. According to the spec[1], if an overflowing snap area covers the snapport in one axis and the distance between the previous snap position and the next snap position is larger than the size of the snapport, the current scroll position is a valid snap position. This patch also rewrites the data structure of SnapAreaData and SnapContainerData so that they only keep the rect and calculate the snap points, visible region, overflow condition only when scroll occurs. [1] https://drafts.csswg.org/css-scroll-snap-1/#snap-overflow Bug: 826359 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec1ebe48abe8d2653128ac2af4e6137a14c05502 Reviewed-on: https://chromium-review.googlesource.com/1075558 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570255} | 26 June 2018, 00:35:28 UTC |
| 69a3b95 | Eric Willigers | 18 June 2018, 00:25:03 UTC | [css-box] Parsing tests for CSS Box properties Spec: https://drafts.csswg.org/css-box-3/ Omits properties and values that are not yet supported by browsers. | 25 June 2018, 22:30:14 UTC |
| 72048cd | Victor Costan | 25 June 2018, 20:42:25 UTC | Async Cookies: Address feedback from spec repository. This CL integrates the following issues: https://github.com/WICG/cookie-store/issues/54 - startsWith -> starts-with https://github.com/WICG/cookie-store/issues/51 - remove cookieStore.has Bug: 729800 Change-Id: If296a9e1eb896cb0ef344a889b1715836610bc6d Reviewed-on: https://chromium-review.googlesource.com/1112912 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570157} | 25 June 2018, 21:03:17 UTC |
| 3b0bbac | youennf | 25 June 2018, 20:46:47 UTC | Merge pull request #11663 from youennf/wpt-export-for-webkit-186939 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=186939 | 25 June 2018, 20:46:47 UTC |
| f6846cf | Youenn Fablet | 25 June 2018, 20:03:55 UTC | WebKit export of https://bugs.webkit.org/show_bug.cgi?id=186939 | 25 June 2018, 20:03:55 UTC |
| 69a3483 | Eric Willigers | 25 June 2018, 19:51:44 UTC | CSS: transform-origin does not accept top <length> Spec: https://drafts.csswg.org/css-transforms/#propdef-transform-origin Blink no longer accepts transform-origin 'top 1px'. We previously parsed it as 'top center 1px'. Edge/Firefox/WebKit already reject such values. BUG=855787 Change-Id: I8ac8745d41c867a2ef659ce9afe17143d60a1806 Reviewed-on: https://chromium-review.googlesource.com/1112883 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#570139} | 25 June 2018, 20:01:29 UTC |
| 775bb3b | Becca Hughes | 25 June 2018, 19:10:02 UTC | Reland "[CSS Env Vars] Add some WPT tests" This is a reland of 981a543f9e743001a6e492a006873de3a5953747 This adds a bugfix that adds a DetachFromParent method that we call in StyleEngine. This stops the global environment variables instance holding a reference to the document one after the document has been disposed. Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG=825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} Bug: 825890 Change-Id: If828b977d62145fb1ea9bb710a48d76307a054d5 Reviewed-on: https://chromium-review.googlesource.com/1113877 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570117} | 25 June 2018, 19:22:16 UTC |
| 2aef175 | Dirk Schulze | 25 June 2018, 19:18:49 UTC | Merge pull request #11633 from ewilligers/transform-parsing [css-transforms] Parsing transforms-1 properties | 25 June 2018, 19:18:49 UTC |
| 528420c | Oriol Brufau | 25 June 2018, 19:12:35 UTC | Add tests for some logical border shorthand properties | 25 June 2018, 19:16:36 UTC |
| ce2196e | Peng Huang | 25 June 2018, 19:00:39 UTC | Revert "Move a test for min-content for a soft-hyphen to wpt" This reverts commit d37409a17a223249ee661ae504def53bf51b4ce9. Reason for revert: external/wpt/css/css-sizing/min-content-soft-hyphen-001.html failed on Windows 10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36928 Original change's description: > Move a test for min-content for a soft-hyphen to wpt > > This tests when the inline-size is [min-content]: > * A `­` produces a break opportunity when computing the > min-content inline size. > * The hyphen character generated by `­` is included into > the min-content inline size. > > Originally developed in [CL:1111895]. > > [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content > [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895 > > Bug: 636993 > Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/1113085 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570066} TBR=cbiesinger@chromium.org,kojii@chromium.org Change-Id: I3fb91c7c2d66e775a12994734a14afc566d05a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1113667 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570109} | 25 June 2018, 19:09:58 UTC |
| cb53793 | Koji Ishii | 25 June 2018, 16:53:57 UTC | Move a test for min-content for a soft-hyphen to wpt This tests when the inline-size is [min-content]: * A `­` produces a break opportunity when computing the min-content inline size. * The hyphen character generated by `­` is included into the min-content inline size. Originally developed in [CL:1111895]. [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895 Bug: 636993 Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1113085 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#570066} | 25 June 2018, 17:30:21 UTC |
| 5efecac | Simon Pieters | 25 June 2018, 16:44:33 UTC | [testharness.js][docs] Improve and document assert_object_equals (#11642) Fixes #10262. | 25 June 2018, 16:44:33 UTC |
| ee53369 | Philipp Hancke | 25 June 2018, 11:22:37 UTC | webrtc wpt: make getUserMedia calls await removes the last directly promise-based usage of getUserMedia BUG=836871 Change-Id: Ib0ef41b58c2fc3930d068d915cb569064db4542d Reviewed-on: https://chromium-review.googlesource.com/1106618 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570005} | 25 June 2018, 11:38:02 UTC |
| 9d5ca97 | Manuel Rego Casasnovas | 25 June 2018, 09:16:45 UTC | Merge pull request #11653 from mrego/contain-size-image-alt [css-contain] Add alt on image at contain-size-013.html | 25 June 2018, 09:16:45 UTC |
| cc0999e | Raphael Kubo da Costa | 25 June 2018, 09:14:53 UTC | sensors: Yield to the event loop in GenericSensorTestChromium.reset() (#11625) Do so there instead of in `MockSensorProvider.reset()`, which is now a regular function. This brings the code more in line with Blink's own `sensor-helpers.js`, and fixes one of the issues described in #10906: when a test failed, we'd end up with the following code path 1. `sensor_tests()`'s calls `GenericSensorTestChromium.reset()` 2. `GenericSensorTestChromium.reset()` calls `MockSensorProvider.reset()` 3. This function `await`s on a promise that resolves inside `setTimeout()` and yields control back to the event loop 4. The next test is run, and it fails because `GenericSensorTest.testInternal` hasn't been reset yet. 5. After all tests run, we go back to the `setTimeout()` callbacks and finish running `GenericSensorTest.reset()`. which essentially caused all subsequent tests to failure because `1initialize()` would complain `reset()` had not been run. We now simplify things, and a test failure results in: 1. `sensor_tests()`'s calls `GenericSensorTestChromium.reset()` 2. `GenericSensorTestChromium.reset()` calls `MockSensorProvider.reset()`, which runs synchronously and where we close the mojo binding and stop the mojo interceptor 3. This function `await`s on a promise that resolves inside `setTimeout()` and yields control back to the event loop to let the mojo shutdown process finish. The next test may start running before this `sensor_test` fully finishes, but it's not a problem since we're not running anything after calling `GenericSensorTestChromium.reset()` 4. The next test runs as expected because `testInternal` has already been reset With this change, running `wpt run` with a recent Chromium master build on accelerometer, generic-sensor, geolocation-sensor, gyroscope, magnetometer and orientation-sensor yields 249 failures, down from 286. | 25 June 2018, 09:14:53 UTC |
| f17d9ee | Simon Pieters | 25 June 2018, 08:11:41 UTC | Fetch: split up fetch/api/request/request-keepalive-quota.html Part of #11571. | 25 June 2018, 08:11:41 UTC |
| 59384fa | Harald Alvestrand | 25 June 2018, 06:48:50 UTC | Merge pull request #11524 from fippo/codemods-are-awesome webrtc: add tooling to allow using jscodeshift codemods | 25 June 2018, 06:48:50 UTC |
| 50b0943 | Hiroki Nakagawa | 25 June 2018, 05:27:40 UTC | ES Modules: Use an appropriate referrer policy for module script loading This CL fixes ReferrerPolicy handling in module script loading. Before this CL, FetchClientSettingsObjectSnapshot's referrer policy is used, but this is wrong. The spec requires to use ScriptFetchOptions' referrer policy. // The "set up the module script request" algorithm: "Set request's cryptographic nonce metadata to options's cryptographic nonce, ..., and its referrer policy to options's referrer policy." https://html.spec.whatwg.org/multipage/webappapis.html#set-up-the-module-script-request Specifically, this CL introduces |referrer_policy_| field in ScriptFetchOptions class as spec'ed and propagates it to the entire path of module script loading. ScriptFetchOptions's referrer policy can be set to following values: - <script>'s "referrerpolicy" attribute is used for <script type='module'>. This hasn't been implemented yet (see https://crbug.com/841673), so the current document's referrer policy is used to keep the backward compatibility. // The "prepare a script" algorithm: "20. Let referrer policy be the current state of the element's referrerpolicy content attribute." "22. Let options be a script fetch options whose cryptographic nonce is cryptographic nonce, ..., and referrer policy is referrer policy." https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script - <link>'s "referrerpolicy" attribute is used for modulepreload. // The "Link type "modulepreload"" algorithm: "9. Let referrer policy be the current state of the element's referrerpolicy attribute." "10. Let options be a script fetch options whose cryptographic nonce is cryptographic nonce, ..., and referrer policy is referrer policy." https://html.spec.whatwg.org/multipage/links.html#link-type-modulepreload - The default referrer policy is used for module workers and worklets. This is the reason why this CL changes test expectations of workers and worklets. // The "fetch a module worker script graph" algorithm: "2. Let options be a script fetch options whose cryptographic nonce is the empty string, ..., and referrer policy is the empty string." https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-module-worker-script-tree Change-Id: Ic0f9e6667cd1b84f74d86fcc948451c1d2f8191f Bug: 842553, 855963 Reviewed-on: https://chromium-review.googlesource.com/1111743 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#569967} | 25 June 2018, 05:59:35 UTC |
| afeb41a | Manuel Rego Casasnovas | 25 June 2018, 05:35:27 UTC | [css-contain] Add alt on image at contain-size-013.html | 25 June 2018, 05:35:27 UTC |
| 676a964 | Staphany Park | 24 June 2018, 14:23:51 UTC | Async Cookies: More service worker subscription tests. Bug: 729800 Change-Id: Ie216054a92e223c29120226b645b2c10b208dde0 Reviewed-on: https://chromium-review.googlesource.com/1073080 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#569930} | 24 June 2018, 14:39:41 UTC |
| 48c5cb9 | Emilio Cobos Álvarez | 22 June 2018, 08:34:37 UTC | noscript rules should not apply to non-HTML elements. Differential Revision: https://phabricator.services.mozilla.com/D1749 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470150 gecko-commit: e27f16329c725d807150863588ed572b2990c60c gecko-integration-branch: mozilla-inbound gecko-reviewers: heycam | 24 June 2018, 09:45:19 UTC |
| 86e620c | Nico Weber | 23 June 2018, 23:54:34 UTC | Revert "[CSS Env Vars] Add some WPT tests" This reverts commit 981a543f9e743001a6e492a006873de3a5953747. Reason for revert: These tests have been failing since they were added: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/20683 Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG=825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} TBR=mlamouri@chromium.org,beccahughes@chromium.org,futhark@chromium.org Change-Id: I32fbe3682558bdd2d117c8f647750e5d8bcbf740 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825890 Reviewed-on: https://chromium-review.googlesource.com/1112982 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569916} | 24 June 2018, 00:03:25 UTC |
| 9ac054e | L. David Baron | 23 June 2018, 15:55:33 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/5bbe54174894e1b71aaf83006c2744bb8836816e . (#11628) | 23 June 2018, 15:55:33 UTC |
| c8262a7 | jimevans | 23 June 2018, 15:39:41 UTC | webdriver: correct expected error response in element_click test (#11638) | 23 June 2018, 15:39:41 UTC |
| f9d0147 | jimevans | 23 June 2018, 15:38:35 UTC | webdriver: remove ES6 constructs from WebDriver tests for IE support (#11637) IE does not support array destructuring in a `let` statement. This commit allows the newly added element_click tests to run on IE 11. | 23 June 2018, 15:38:35 UTC |
| f0b7c11 | Philip Jägenstedt | 22 February 2018, 09:06:52 UTC | Make percentage height calculation quirk tests match implementations These tests are all failing in the same way in Chrome, Edge, Firefox and Safari: https://wpt.fyi/quirks/percentage-height-calculation.html They came up when looking at tests that have been failing for a very long time: https://docs.google.com/document/d/1kFYTqUMEbo9p87i6wAzORoicMWgHsuYwL2CgtvdhDaE/edit?usp=sharing | 23 June 2018, 15:18:55 UTC |
| 667bdfe | Eric Willigers | 19 June 2018, 10:47:25 UTC | [css-transforms] Parsing transforms-1 properties Parsing/serialization tests for - transform - transform-box - transform-origin Spec: https://drafts.csswg.org/css-transforms/ Found bugs: https://bugs.chromium.org/p/chromium/issues/detail?id=855787 https://bugs.webkit.org/show_bug.cgi?id=186965 Tests include recently added transform-box values content-box and stroke-box. | 23 June 2018, 10:22:22 UTC |
| 4333a1d | Becca Hughes | 23 June 2018, 00:28:57 UTC | [CSS Env Vars] Add some WPT tests Adds some WPT tests to test env() with @supports as well as fallback values. BUG=825890 Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d Reviewed-on: https://chromium-review.googlesource.com/1111023 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569852} | 23 June 2018, 00:38:40 UTC |
| 05fcdea | Matt Wolenetz | 22 June 2018, 22:55:08 UTC | MSE: Add SourceBuffer.changeType() web-platform-tests Adds external/wpt tests for the SourceBuffer.changeType() method being incubated in WICG/media-source spec repo's codec-switching branch. BUG=605134 Change-Id: I52879fdff07473fbec6f5b44296dedd42619455c Reviewed-on: https://chromium-review.googlesource.com/1111275 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569812} | 22 June 2018, 23:06:48 UTC |
| a5facbd | Ian Clelland | 22 June 2018, 21:29:52 UTC | Update Web Platform Tests for Feature Policy integration into HTML spec. Change-Id: Ibfcc3e8bc217aff8782d2aec4c1b73bb4a193e1e Reviewed-on: https://chromium-review.googlesource.com/1053106 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#569778} | 22 June 2018, 21:39:22 UTC |
| 95c2419 | Manuel Rego Casasnovas | 22 June 2018, 19:35:24 UTC | [css-grid] Fix positioned items in a grid with calc() gutters In r543079 we added support for calc() in grid gutters. In that patch we modified LayoutGrid::GridGap() but we forgot to do the same in LayoutGrid::AvailableSpaceForGutters(). This patch just changes the IsPercent() call by IsPercentOrCalc() that way calc() gutters are considered too when looking for the available space. BUG=816300 TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002.html TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html Change-Id: I3237d5dc73f508cea6d904b9f1fd3822bb9efe55 Reviewed-on: https://chromium-review.googlesource.com/1112237 Reviewed-by: Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#569733} | 22 June 2018, 19:45:19 UTC |
| 644c413 | David Grogan | 22 June 2018, 18:33:20 UTC | [css-tables] Make scrollbars visible on mac screenshots wpt.fyi showed Safari passing these recently-added tests because the scrollbars don't show in either the tests or their refs. https://wpt.fyi/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html Aside: Edge matches Safari's current and Chrome's previous behavior. But they've confirmed it's a bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17505131/ Firefox has a mostly-unrelated incompatibility that doesn't allow us to check it. Bug: 837408,838144 Change-Id: I82058d3c22d7668711e9a9a1c977047033d64b46 Reviewed-on: https://chromium-review.googlesource.com/1054770 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#569698} | 22 June 2018, 18:43:18 UTC |
| 5bb78f0 | Luke Bjerring | 22 June 2018, 18:41:14 UTC | Update the push-api IDL file (#9815) | 22 June 2018, 18:41:14 UTC |
| 372c7ad | Anders Hartvoll Ruud | 22 June 2018, 17:07:30 UTC | Correctly resolve relative URLs for registered custom properties. Relative URLs in registered custom properties must resolve against the base URL of the originating stylesheet. For instance, consider a style- sheet at /style/mystyle.css: --foo: url("myimage.jpg"); And a document at /index.html: <style> background-image: var(--foo); </style> If the property --foo is registered with syntax <url>, then the background- image should be /style/myimage.jpg. This is contrary to non-registered properties, in which case the background-image would be /myimage.jpg. To implement this, this patch scans for URL tokens and 'url('-function tokens after (var-)resolving the registered custom property (see CSSVariableResolver::ResolveCustomProperty). The token containing the relative URL is then rewritten (in-place) to contain an absolute URL instead. To avoid doing unnecessary work, we only scan the token stream if CSSVariableData::needs_variable_resolution_ is set. This is set either if needs_url_resolution_ is set (because var-references could produce relative URLs), or if the token stream contains URL/function-tokens. When a resolved CSSVariableData is created (::CreateResolved), it is assumed that the incoming token stream contains no URLs that need to be resolved. R=futhark@chromium.org, timloh@chromium.org Bug: 851490 Change-Id: I25b1e839fc92eb538f30670fe91fc92a1ad9d5ea Reviewed-on: https://chromium-review.googlesource.com/1109975 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569663} | 22 June 2018, 17:16:49 UTC |
| 46c8d39 | Manuel Rego Casasnovas | 22 June 2018, 14:40:57 UTC | [css-contain] Size containment replaced elements intrinsic size is zero The spec is very clear about this (https://drafts.csswg.org/css-contain/#containment-size): "Replaced elements must be treated as having an intrinsic width and height of 0." The patch modifies LayoutReplaced::ComputeIntrinsicSizingInfo() so that it returns zero for elements with "contain: size". BUG=853441 TEST=external/wpt/css/css-contain/contain-size-013.html Change-Id: I91490b120a110be20a91d564da4fdc3d9a11b70a Reviewed-on: https://chromium-review.googlesource.com/1110819 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#569610} | 22 June 2018, 15:00:17 UTC |
| fb04aed | Andy Paicu | 22 June 2018, 13:46:13 UTC | Completed 'unsafe-hashes' per spec 'unsafe-hashed-attributes' renamed to 'unsafe-hashes' 'unsafe-hashes' matches style attributes correctly now 'unsafe-hashes' works for javascript: URLs 'unsafe-hashes' tests added and ammended spec (approved and to be submitted at the same time as this CR): https://github.com/w3c/webappsec-csp/pull/311 I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4dohVXDfEI4/tO6rhuv4AwAJ Bug: 771922 Change-Id: I018cc0f73d492cb4057ff4c41d9be4df8438036c Reviewed-on: https://chromium-review.googlesource.com/1095217 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569593} | 22 June 2018, 14:12:52 UTC |
| ebbac7a | Emilio Cobos Álvarez | 22 June 2018, 08:30:28 UTC | Tests for getComputedStyle on display: none subtrees. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470087 gecko-commit: 393be8743349aa97b9c3413cdc164f2d976cf34d gecko-integration-branch: mozilla-inbound gecko-reviewers: heycam | 22 June 2018, 12:48:58 UTC |
