Skip to main content

Browse the archive

Revision ecc5b95a2ba5b8b8fdbe35ad4ef97535fd22927a authored by will-cern on 15 June 2024, 06:52:10 UTC, committed by Danilo Piparo on 15 June 2024, 10:20:08 UTC 
[RF] Improve binBoundaries method of ParamHistFunc (#15650)
 
ParamHistFunc currently does not adhere to the convention that if it is
independent of the variable passed to binBoundaries method that it should
return `nullptr`. This is fixed, along with more correct obtaining of the bin
boundaries, from the RooDataHist itself.
1 parent c632980
Raw File
tidy_script.sh 
#!/usr/bin/env bash

set -ex

CLANG_TIDY_CHECKS='-*'
if [[ $TOOL == clang-tidy-analyzer ]]; then
  CLANG_TIDY_CHECKS+=',clang-analyzer-*,-clang-analyzer-alpha*,bugprone*'
elif [[ $TOOL == clang-tidy-modernize ]]; then
  CLANG_TIDY_CHECKS+=',modernize*'
fi

echo "Running clang-tidy only against the changes in branch $TRAVIS_BRANCH."

cd ../root/

# Workaround for travis issue: travis-ci/travis-ci#6069
git remote set-branches --add origin master
git fetch

# clang-tidy-diff.py not installed on travis
wget https://raw.githubusercontent.com/llvm-mirror/clang-tools-extra/release_50/clang-tidy/tool/clang-tidy-diff.py

RESULT_OUTPUT="$(git diff -U0 origin/master | python clang-tidy-diff.py -p1 -clang-tidy-binary $(which clang-tidy) \
                 -checks=$CLANG_TIDY_CHECKS)"
if [[ $? -eq 0 ]]; then
  echo "$TOOL passed."
  exit 0
else
  echo "To reproduce it locally please run"
  echo -e "\tgit checkout $TRAVIS_BRANCH"
  echo -e "Command: git diff -U0 $TRAVIS_BRANCH..origin/master | clang-tidy-diff.py -p1 -clang-tidy-binary \$(which clang-tidy) -checks=$CLANG_TIDY_CHECKS"
  echo "$RESULT_OUTPUT"
  exit 1
fi
back to top