https://github.com/JuliaLang/julia
Revision ee50411e925e912a64088acbf79c2975db0a4cad authored by Cody Tapscott on 05 September 2023, 15:31:34 UTC, committed by Cody Tapscott on 05 September 2023, 15:36:52 UTC
The unreachable here seems to be caused by the fact that (as of #50299) we
re-use a more narrow type from Inference that correctly ignores these
edges, but when inserting the `φᶜ` node in `slot2reg` we were including
extra edges that never get exercised at runtime.

I'm not sure _why_ this causes us to hit an unreachable, since the narrow
type from inference is technically still valid (the catch block will never
observe these spurious assignments at runtime), but this seems to fix the
issue and anyway improves the quality of the IRCode generated by `slot2ssa`.

Resolves #51159
1 parent 933ea1d
History
Tip revision: ee50411e925e912a64088acbf79c2975db0a4cad authored by Cody Tapscott on 05 September 2023, 15:31:34 UTC
slot2ssa: Fix spurious φᶜ edges
Tip revision: ee50411
File Mode Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version -rw-r--r-- 5 bytes
.clang-format -rw-r--r-- 3.3 KB
.clangd -rw-r--r-- 114 bytes
.codecov.yml -rw-r--r-- 52 bytes
.git-blame-ignore-revs -rw-r--r-- 371 bytes
.gitattributes -rw-r--r-- 65 bytes
.gitignore -rw-r--r-- 523 bytes
.mailmap -rw-r--r-- 12.7 KB
CITATION.bib -rw-r--r-- 513 bytes
CITATION.cff -rw-r--r-- 940 bytes
CONTRIBUTING.md -rw-r--r-- 23.4 KB
HISTORY.md -rw-r--r-- 372.5 KB
LICENSE.md -rw-r--r-- 1.3 KB
Make.inc -rw-r--r-- 55.7 KB
Makefile -rw-r--r-- 30.5 KB
NEWS.md -rw-r--r-- 2.1 KB
README.md -rw-r--r-- 7.3 KB
THIRDPARTY.md -rw-r--r-- 3.8 KB
VERSION -rw-r--r-- 11 bytes
julia.spdx.json -rw-r--r-- 35.8 KB
pkgimage.mk -rw-r--r-- 6.3 KB
sysimage.mk -rw-r--r-- 4.3 KB

README.md

back to top