Revision ef15ddeeb6bee87c044bf7754fac524545bf71e8 authored by Aleksandr Mishin on 28 March 2024, 16:55:05 UTC, committed by David S. Miller on 03 April 2024, 10:00:33 UTC
In rvu_map_cgx_lmac_pf() the 'iter', which is used as an array index, can reach
value (up to 14) that exceed the size (MAX_LMAC_COUNT = 8) of the array.
Fix this bug by adding 'iter' value check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c53fe72
Raw File
crc64_rocksoft_generic.c
// SPDX-License-Identifier: GPL-2.0-only

#include <linux/crc64.h>
#include <linux/module.h>
#include <crypto/internal/hash.h>
#include <asm/unaligned.h>

static int chksum_init(struct shash_desc *desc)
{
	u64 *crc = shash_desc_ctx(desc);

	*crc = 0;

	return 0;
}

static int chksum_update(struct shash_desc *desc, const u8 *data,
			 unsigned int length)
{
	u64 *crc = shash_desc_ctx(desc);

	*crc = crc64_rocksoft_generic(*crc, data, length);

	return 0;
}

static int chksum_final(struct shash_desc *desc, u8 *out)
{
	u64 *crc = shash_desc_ctx(desc);

	put_unaligned_le64(*crc, out);
	return 0;
}

static int __chksum_finup(u64 crc, const u8 *data, unsigned int len, u8 *out)
{
	crc = crc64_rocksoft_generic(crc, data, len);
	put_unaligned_le64(crc, out);
	return 0;
}

static int chksum_finup(struct shash_desc *desc, const u8 *data,
			unsigned int len, u8 *out)
{
	u64 *crc = shash_desc_ctx(desc);

	return __chksum_finup(*crc, data, len, out);
}

static int chksum_digest(struct shash_desc *desc, const u8 *data,
			 unsigned int length, u8 *out)
{
	return __chksum_finup(0, data, length, out);
}

static struct shash_alg alg = {
	.digestsize	= 	sizeof(u64),
	.init		=	chksum_init,
	.update		=	chksum_update,
	.final		=	chksum_final,
	.finup		=	chksum_finup,
	.digest		=	chksum_digest,
	.descsize	=	sizeof(u64),
	.base		=	{
		.cra_name		=	CRC64_ROCKSOFT_STRING,
		.cra_driver_name	=	"crc64-rocksoft-generic",
		.cra_priority		=	200,
		.cra_blocksize		=	1,
		.cra_module		=	THIS_MODULE,
	}
};

static int __init crc64_rocksoft_init(void)
{
	return crypto_register_shash(&alg);
}

static void __exit crc64_rocksoft_exit(void)
{
	crypto_unregister_shash(&alg);
}

module_init(crc64_rocksoft_init);
module_exit(crc64_rocksoft_exit);

MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Rocksoft model CRC64 calculation.");
MODULE_ALIAS_CRYPTO("crc64-rocksoft");
MODULE_ALIAS_CRYPTO("crc64-rocksoft-generic");
back to top