sort by:
Revision Author Date Message Commit Date
ef772ba Revert "[cxx-interop] Overhaul virtual method support" 02 March 2024, 19:17:45 UTC
683f681 Merge pull request #72037 from hborla/global-actor-cursor-info [Concurrency] Never skip global actor attributes in the ASTPrinter. 02 March 2024, 18:21:34 UTC
70f4202 Merge pull request #72026 from tshortli/resolve-astgen-warnings 02 March 2024, 17:38:40 UTC
19fbe5b Merge pull request #72034 from nate-chandler/rdar123560548-onone [IRGen] Outlined consume functions call noncopyable deinits. 02 March 2024, 16:52:21 UTC
c2eb9cc Merge pull request #72039 from al45tair/al45tair/add-missing-eol [Test][IRGen] Add missing EOL. 02 March 2024, 16:39:38 UTC
48e65c6 Merge pull request #72030 from ahoppen/ahoppen/test-sourcekitlsp-in-swiftsyntax-job [build-presets] Test SourceKit-LSP in the swift-syntax macOS job 02 March 2024, 15:29:15 UTC
230bf6a [Test][IRGen] Add missing EOL. 02 March 2024, 13:54:45 UTC
0860953 Merge pull request #72011 from al45tair/eng/PR-23335318 [IRGen] Don't call objc_retainAutoreleasedReturnValue() without interop. 02 March 2024, 13:52:24 UTC
a68adb9 Merge pull request #72008 from rjmccall/isolated-any-feature-suppression Allow declarations to opt in to suppressing `@isolated(any)` instead of suppressing the entire declaration 02 March 2024, 08:07:20 UTC
6c798a2 Merge pull request #72027 from DougGregor/top-level-closure-discriminators-in-macros Ensure that we assign discriminators for closures from top-level macros 02 March 2024, 08:02:41 UTC
80c858f Merge pull request #72031 from ahoppen/ahoppen/lsan-documentation Improve documentation on how to debug LSAN failures 02 March 2024, 07:53:48 UTC
71651b0 Merge pull request #72032 from DougGregor/full-throws-is-experimental Move `FullTypedThrows` from "upcoming" to "experimental" 02 March 2024, 07:38:25 UTC
ba76c3c [Concurrency] Never skip global actor attributes in the ASTPrinter. Custom attributes like global actors carry crucial semantic information and should never be suppressed in the ASTPrinter. In particular, `printQuickHelpDeclaration()` sets `PrintImplicitAttrs` to false, but it's important for quick help / cursor info to include global actors. 02 March 2024, 06:23:51 UTC
f638918 [IRGen] Multi payload enum consumes call deinits. They include the necessary metadata. 02 March 2024, 05:01:50 UTC
0075682 [IRGen] Single payload enums consumes call deinits The include the necessary metadata. 02 March 2024, 05:01:50 UTC
04d0680 [NFC] IRGen: Extracted method. 02 March 2024, 05:01:50 UTC
f37d2a2 [Gardening] IRGen: Doc'd method. 02 March 2024, 05:01:50 UTC
9a8c814 [Outlining] Pass polymorphic args of type. If any deinit must be called, just pass the full generic environment of the type being destroyed. 02 March 2024, 05:01:50 UTC
b83085b [NFC] IRGen: Extracted function. 02 March 2024, 05:01:49 UTC
3f6bd9d [NFC] IRGen: Store SILType in metadata collector. 02 March 2024, 05:01:49 UTC
babdbda [NFC] IRGen: Moved constructor to cpp. 02 March 2024, 05:01:49 UTC
73ccf1c [NFC] IRGen: Extracted method. 02 March 2024, 05:01:49 UTC
a82140b [NFC] IRGen: Renamed method. Not all metadata that the OutliningMetdataCollector collects is for layout anymore. 02 March 2024, 05:01:49 UTC
765d23b [NFC] IRGen: Clarify metadata collection helper. Gather the circumstances under which the collector should be used and what it should collect separately and then collect only in one place if collection should happen. 02 March 2024, 05:01:49 UTC
1253dba [NFC] IRGen: Renamed outlining helpers. In preparation for them handling more polymorphic arguments than merely metadata. 02 March 2024, 05:01:49 UTC
5d8dfde [NFC] IRGen: Added debugging info. In debug builds, provide some context when an archetype fails to be found. 02 March 2024, 05:01:49 UTC
195046a [NFC] IRGen: Marked member const. 02 March 2024, 05:01:49 UTC
379beab [Gardening] IRGen: Changed a variable name. 02 March 2024, 05:01:49 UTC
c867e4c [NFC] IRGen: Marked some functions public. 02 March 2024, 05:01:49 UTC
fefd793 [NFC] IRGen: Renamed method. 02 March 2024, 05:01:49 UTC
ae9d501 [Test] Mix in another experimental feature. 02 March 2024, 05:01:49 UTC
6fbc06e Merge pull request #72015 from DougGregor/attr-weaklinked-coff-ifdef Move diagnostic about `@_weakLinked` not working for COFF into the type checker 02 March 2024, 03:37:54 UTC
fc538f3 Allow declarations to opt in to suppressing @isolated(any). 02 March 2024, 03:10:15 UTC
1437acd Implement conditional feature suppression. Our standard conception of suppressible features assumes we should always suppress the feature if the compiler doesn't support it. This presumes that there's no harm in suppressing the feature, and that's a fine assumption for features that are just adding information or suppressing new diagnostics. Features that are semantically relevant, maybe even ABI-breaking, are not a good fit for this, and so instead of reprinting the decl with the feature suppressed, we just have to hide the decl entirely. The missing middle here is that it's sometimes useful to be able to adopt a type change to an existing declaration, and we'd like older compilers to be able to use the older version of the declaration. Making a type change this way is, of course, only really acceptable for @_alwaysEmitIntoClient declarations; but those represent quite a few declarations that we'd like to be able to refine the types of. Rather than trying to come up with heuristics based on @_alwaysEmitIntoClient or other sources of information, this design just requires the declaration to opt in with a new attribute, @_allowFeatureSuppress. When a declaration opts in to suppression for a conditionally-suppressible feature, the printer uses the suppression serially-print-with-downgraded-options approach; otherwise it uses the print-only-if-feature-is-available approach. 02 March 2024, 03:10:14 UTC
976f149 [NFC] Introduce DiagRef and use it throughout the parser The goal is to have a lightweight way to pass an unapplied diagnostic to general routines. Constructing a Diagnostic is quite expensive as something we're potentially doing in hot paths, as opposed to just when we're actually emitting the diagnostic. This design allows the expense to be delayed until we need it. I've also optimized the Diagnostic constructor to avoid copying arguments unnecessarily; this is a relatively small expense, since arguments are POD, but there's really no good reason not to do it. 02 March 2024, 03:09:47 UTC
138b33f Re-instate awful AST dumping hack 02 March 2024, 01:52:04 UTC
78df826 Merge pull request #72020 from slavapestov/ncgenerics-fixes-7 Non-copyable generics fixes 02 March 2024, 01:48:17 UTC
e0619c7 Merge pull request #72022 from gottesmm/pr-9701fb99d81b11909c779e433f1257d7b18f1d76 [lit] Remove unused import. 02 March 2024, 01:33:45 UTC
eac6405 Improve documentation on how to debug LSAN failures 02 March 2024, 01:31:01 UTC
6fb91b3 [build-presets] Test SourceKit-LSP in the swift-syntax macOS job SourceKit-LSP depends on swift-syntax sufficiently much that changed runtime behavior of swift-syntax can make sourcekit-lsp fail, as it happened in https://github.com/apple/sourcekit-lsp/pull/1110. Only testing sourcekit-lsp on macOS, not Linux for now. Testing on one platform should be sufficient. 02 March 2024, 01:29:55 UTC
2ad0c1a Merge pull request #71998 from gottesmm/pr-ca981c22b983cdfc472ae9c1d737c76dae955aed [region-isolation] Refactor out the stubify dead function if no longer used functionality from move only checker into its own pass and put it before region based isolation. 02 March 2024, 01:21:45 UTC
2e7e33d Ensure that we assign discriminators for closures from top-level macros In top-level code, we were incorrectly pulling closure discriminators from TopLevelCodeDecls, not from the enclosing source file, which could lead to the same discriminators being assigned to different closures that come from macro expansions at the top level. Hilarity ensures, yet I am not amused. Adjust the DeclContext appropriately when computing discriminators. Fixes rdar://123836908. 02 March 2024, 01:15:03 UTC
a337eaa ASTGen: Resolve a 'may have additional unknown values' warning. 02 March 2024, 01:11:09 UTC
1a5a721 ASTGen: Resolve 'was never mutated' warnings. 02 March 2024, 01:01:10 UTC
d10f6f9 ASTGen: Resolve 'was defined but never used' warnings. 02 March 2024, 01:01:10 UTC
7c1cdaf ASTGen: Resolve 'may have additional unknown values' warnings. 02 March 2024, 01:01:10 UTC
7685371 Merge pull request #71939 from augusto2112/fix-specify-of-2 [DebugInfo] Fix bound generic types debug info generation 02 March 2024, 00:40:31 UTC
59153a0 Merge pull request #72019 from meg-gupta/instdeleterassertfix Update canTriviallyDeleteOSSAEndScopeInst and a related assertion 01 March 2024, 23:54:30 UTC
d83d046 Merge pull request #72002 from hborla/adjust-language-mode-warning [Diagnostics] Clarify the wording of `error_in_future_swift_version`. 01 March 2024, 23:53:00 UTC
e5f80d1 Merge pull request #72018 from DougGregor/implicit-open-existentials-swift6 Add upcoming feature `ImplicitOpenExistentials` for SE-0352 01 March 2024, 23:31:52 UTC
9178c4a Merge pull request #71962 from augusto2112/embedded-flag [DebugInfo] Emit embedded swift into DW_AT_APPLE_flags 01 March 2024, 23:12:39 UTC
70cf5d4 Merge pull request #72001 from xymus/restrict-to-channel Serialization: Restrict swiftmodules to distribution channels 01 March 2024, 22:54:50 UTC
6110ab9 Merge pull request #72017 from apple/az/fix/se-0422/dylib-not-found 01 March 2024, 22:39:45 UTC
5c2ae73 Merge pull request #71994 from apple/egorzhdan/virtual-methods [cxx-interop] Overhaul virtual method support 01 March 2024, 22:19:38 UTC
0250603 Merge pull request #71877 from ahoppen/ahoppen/better-formatting [SourceKit] Test adjustments for improved formatting in BasicFormat 01 March 2024, 22:04:49 UTC
0d7c575 [IRGen][Test] Update tests for non-Linux platform support. Tweak the tests slightly for WASM, Windows and Darwin. rdar://23335318 01 March 2024, 21:28:38 UTC
c818e54 [lit] Remove unused import. I normally wouldn't care about this sort of thing, but on my system that import seems to fail and I noticed we aren't actually using it... so it makes sense to just remove it. 01 March 2024, 21:18:56 UTC
5e623d7 Remove moveonly_delete_if_unused. This test made sure that the move checker stubbified tests... but I am now doing it in a separate pass... so there is nothing to test here. 01 March 2024, 21:13:24 UTC
3236bc2 [region-isolation] Refactor out the stubify dead function if no longer used functionality from move only checker into its own pass and put it before region based isolation. I am doing this since region based isolation hit the same issue that the move checker did. So it makes sense to refactor the functionality into its own pass and move it into a helper pass that runs before both. It is very conservative and only stubifies functions that the specialization passes explicitly mark as this being ok to be done to. 01 March 2024, 21:11:07 UTC
9e3e6e8 Use an early exit 01 March 2024, 21:02:00 UTC
e85f8e1 ASTMangler: Fix conformance path mangling for noncopyable generics 01 March 2024, 20:46:59 UTC
d88faf3 AST: Move a couple of declarations to a more logical location 01 March 2024, 20:46:59 UTC
861d8eb Serialization: Don't reconstruct inheritance clause of protocol 01 March 2024, 20:46:59 UTC
d86a301 Index: Don't look at getInherited() on deserialized protocol 01 March 2024, 20:46:59 UTC
6934046 Serialization: Fix associated conformance deserialization for EnableDeserializationRecovery This was using the wrong predicate. Make it consistent with type witness deserialization. 01 March 2024, 20:46:59 UTC
95274b1 Sema: Fix availability checking for noncopyable generics 01 March 2024, 20:46:59 UTC
d0c35cf [IRGen] Don't call objc_retainAutoreleasedReturnValue() without interop. When ObjC interop is not enabled, we shouldn't be emitting calls to `objc_retainAutoreleasedReturnValue()` as that function might not exist. Call `swift_retain()` instead, to balance the `swift_release()` of the returned value. Fixes #47846, #45359. rdar://23335318 01 March 2024, 20:34:43 UTC
1171505 Move `FullTypedThrows` from "upcoming" to "experimental" This feature is not fully implemented, and cannot be considered to be "upcoming" until it is. 01 March 2024, 20:24:19 UTC
ed6b713 Move diagnostic about `@_weakLinked` not working for COFF into the type checker This allows us to use `@_weakLinked` inside of a `#if` properly. 01 March 2024, 20:18:58 UTC
eb7772c Update canTriviallyDeleteOSSAEndScopeInst and a related assertion A destroy_value of Optional.none can be deleted. A move-only struct with deinit has a non trivial SILType but OwnershipKind::None, such values cannot be deleted. 01 March 2024, 20:15:14 UTC
466a021 [Diagnostics] Add an educational note for `error_in_future_swift_version`. 01 March 2024, 20:05:51 UTC
9ba481a [Diagnostics] Clarify the wording of `error_in_future_swift_version`. 01 March 2024, 20:05:51 UTC
6075de1 Add upcoming feature `ImplicitOpenExistentials` for SE-0352 To maintain source compatibility, SE-0352 does not open existentials with "self-conforming" type, such as `any Error` or existentials based on `@objc` protocols. The proposal specified that this behavior would change in Swift 6. Implement that behavior change, which can be enabled prior to Swift 6 with the upcoming feature `ImplicitOpenExistentials` (as documented in SE-0362). Fixes #70873 / rdar://120902975. 01 March 2024, 19:50:39 UTC
8ead722 [cxx-interop] Overhaul virtual method support This adds a new implementation of virtual method dispatch that handles reference types correctly. Previously, for all C++ types an invocation of a virtual method would actually get dispatched statically. For value types this is expected and matches what C++ does because of slicing. For reference types, however, this is incorrect, we should do dynamic dispatch. rdar://123852577 01 March 2024, 19:45:58 UTC
f1adf99 Merge pull request #72012 from apple/egorzhdan/std-chrono [cxx-interop] Add conversions between `std::chrono::duration` and `Swift.Duration` 01 March 2024, 19:17:01 UTC
e7e5be1 test: Repair isolated_any_metadata.sil for Wasm CI (#72013) The test was failing on the Wasm CI because `%IRGenFileCheck` is configured for the target platform (in this case wasm32-unknown-wasi), but the test used it to check the output for other platforms. The mismatch was not revealed on the other CI because they are all 64-bit, but the 32-bit Wasm CI revealed it. https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/66/ Adjust a test case added by https://github.com/apple/swift/pull/71970 to repair Wasm CI 01 March 2024, 19:12:54 UTC
7edd23a Serialization: allow different channels to share a module cache location 01 March 2024, 18:54:29 UTC
1e4fe67 Serialization: restrict swiftmodules to distribution channels There are scenarios where different compilers are distributed with compatible serialization format versions and the same tag. Distinguish swiftmodules in such a case by assigning them to different distribution channels. A compiler expecting a specific channel will only read swiftmodules from the same channel. The channels should be defined by downstream code as it is by definition vendor specific. For development, a no-channel compiler loads or defining the env var SWIFT_IGNORE_SWIFTMODULE_REVISION skips this new check. rdar://123731777 01 March 2024, 18:52:44 UTC
9ae7065 Merge pull request #71991 from artemcm/ExplicitModulesDefaultCache [Dependency Scanning] Fallback on system default cache directory when no explicit cache path is specified by the user 01 March 2024, 18:26:04 UTC
892dd45 SymbolGraph: Fixes for noncopyable generics and some small cleanups 01 March 2024, 17:55:08 UTC
1f115ad Merge pull request #72009 from hamishknight/another-attr-fix [Parse] Fix a couple more attribute SourceRanges 01 March 2024, 17:37:14 UTC
8a25294 Merge pull request #71965 from augusto2112/fix-lto-decl [DebugInfo] Emit witness and objc method declarations in debug info 01 March 2024, 17:26:02 UTC
a535948 AST/SourceKit: Fix printing of inheritance clauses (sort of) This still needs a lot more cleanup. 01 March 2024, 17:19:15 UTC
9f9f91d Merge pull request #71996 from edymtt/edymtt/ensure-visibility-hidden-is-set-for-compatibility-archives Ensure that proper default visibility is set for compatibility archives 01 March 2024, 16:55:33 UTC
37dbd05 ConstExtract: Update for noncopyable generics (sort of) 01 March 2024, 16:05:54 UTC
638abd9 [cxx-interop] Refactor: move synthesis logic elsewhere 01 March 2024, 15:57:33 UTC
ede186c Merge pull request #71980 from compnerd/build-host-target SwiftShims: use the correct variable for the behaviour check 01 March 2024, 15:45:53 UTC
c18c7a6 Merge pull request #72003 from ahoppen/ahoppen/print-compilerargs-last [SourceKit] Print compilerargs and sourcetext keys last 01 March 2024, 14:54:14 UTC
ecbe758 Merge pull request #71986 from kubamracek/dont-strip-builtins [build-script] Avoid stripping clang builtin .a libraries when extracting dSYMs on Darwin 01 March 2024, 14:43:48 UTC
cc50cc8 Merge pull request #71945 from eeckstein/undef-parent-function SwiftCompilerSources: support `Undef.parentFunction` and `PlaceholderValue.parentFunction` 01 March 2024, 14:16:45 UTC
53fb653 [cxx-interop] Add conversions between `std::chrono::duration` and `Swift.Duration` rdar://123696734 01 March 2024, 13:15:05 UTC
064c8c5 Merge pull request #71995 from slavapestov/ncgenerics-fixes-6 Non-copyable generics fixes 01 March 2024, 12:34:00 UTC
5d39788 [Parse] Fix a couple more attribute SourceRanges 01 March 2024, 12:23:49 UTC
2f6e9b3 Merge pull request #72005 from tshortli/refactor-feature-set AST: Refactor FeatureSet utility out into its own file 01 March 2024, 11:09:47 UTC
237dd4f Merge pull request #71970 from rjmccall/isolated-any-availability Fix metadata availability testing for parameterized existentials and implement it for @isolated(any) function types 01 March 2024, 09:11:22 UTC
bc8f42d Merge pull request #71979 from kateinoigakukun/pr-cd8ba74ab4469e3c7607e61424497cc86fee8812 wasm: Add `pthread.h` to the WASI libc modulemap 01 March 2024, 08:55:57 UTC
44e4488 AST: Simplify usesFeatureTypedThrows(). NFC. 01 March 2024, 08:16:41 UTC
65e8ce5 AST: Refactor FeatureSet out into its own file. NFC. 01 March 2024, 08:16:41 UTC
8137adf SwiftCompilerSources: support `Undef.parentFunction` and `PlaceholderValue.parentFunction` After support in the C++ SIL, we can implement parentFunction for those values in swift, too. It simplifies a few things. 01 March 2024, 08:07:12 UTC
58188fc SIL: let the function entry block be the parent block of SILUndefs in the function. 01 March 2024, 08:07:12 UTC
back to top