Skip to main content

Browse the archive

Revision f048355b3d2fd2468e37ddd916b6f0166aad0739 authored by Stephen McGruer on 13 April 2018, 16:52:45 UTC, committed by Chromium WPT Sync on 13 April 2018, 16:52:45 UTC 
Web Animations: Fix bugs in procedure to process a keyframes argument
 
There were three minor bugs left in the implementation:

  - We threw on lists-in-custom-iterators instead of just ignoring them.
  - We returned all properties on the keyframe rather than just those
    defined on the keyframe itself (e.g. we would include prototype
    properties, against spec).
  - We didn't access the properties in ascending unicode order.

Bug: 827573
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}
1 parent 1e5a5fe
Raw File
first-contentful-canvas.html 
<!DOCTYPE html>
<head>
<title>Performance Paint Timing Test: FCP due to canvas</title>
</head>
<body>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<canvas id="canvas" width="200" height="200" ></canvas>

<script>
async_test(function (t) {
    const canvas = document.getElementById("canvas");
    const context = canvas.getContext("2d");
    context.beginPath();
    context.moveTo(0,0);
    context.lineTo(300,150);
    context.stroke();
    function testPaintEntries() {
        const bufferedEntries = performance.getEntriesByType('paint');
        if (bufferedEntries.length < 2) {
            t.step_timeout(function() {
                testPaintEntries();
            }, 20);
            return;
        }
        t.step(function() {
            assert_equals(bufferedEntries.length, 2, "There should be two paint timing instances.");
            assert_equals(bufferedEntries[0].entryType, "paint");
            assert_equals(bufferedEntries[0].name, "first-paint");
            assert_equals(bufferedEntries[1].entryType, "paint");
            assert_equals(bufferedEntries[1].name, "first-contentful-paint");
            t.done();
        });
    };
    t.step(function() {
        testPaintEntries();
    });
}, "First contentful paint fires due to canvas render.");
</script>
</body>
</html>
back to top