Skip to main content

Browse the archive

Revision f048355b3d2fd2468e37ddd916b6f0166aad0739 authored by Stephen McGruer on 13 April 2018, 16:52:45 UTC, committed by Chromium WPT Sync on 13 April 2018, 16:52:45 UTC 
Web Animations: Fix bugs in procedure to process a keyframes argument
 
There were three minor bugs left in the implementation:

  - We threw on lists-in-custom-iterators instead of just ignoring them.
  - We returned all properties on the keyframe rather than just those
    defined on the keyframe itself (e.g. we would include prototype
    properties, against spec).
  - We didn't access the properties in ascending unicode order.

Bug: 827573
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}
1 parent 1e5a5fe
Raw File
open-method-case-sensitive.htm 
<!DOCTYPE html>
<html>
  <head>
    <title>XMLHttpRequest: open() - case-sensitive methods test</title>
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <link rel="help" href="https://xhr.spec.whatwg.org/#the-open()-method" data-tested-assertations="following::ol/li[5]" />
  </head>
  <body>
    <div id="log"></div>
    <script>
      function method(method) {
        test(function() {
          var client = new XMLHttpRequest()
          client.open(method, "resources/content.py", false)
          client.send(null)
          assert_equals(client.getResponseHeader("x-request-method"), method)
        }, document.title + " (" + method + ")")
      }
      method("XUNICORN")
      method("xUNIcorn")
      method("chiCKEN")
      method("PATCH")
      method("patCH")
      method("copy")
      method("COpy")
      method("inDEX")
      method("movE")
    </script>
  </body>
</html>
back to top