Revision f048355b3d2fd2468e37ddd916b6f0166aad0739 authored by Stephen McGruer on 13 April 2018, 16:52:45 UTC, committed by Chromium WPT Sync on 13 April 2018, 16:52:45 UTC
There were three minor bugs left in the implementation:
- We threw on lists-in-custom-iterators instead of just ignoring them.
- We returned all properties on the keyframe rather than just those
defined on the keyframe itself (e.g. we would include prototype
properties, against spec).
- We didn't access the properties in ascending unicode order.
Bug: 827573
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}
1 parent 1e5a5fe
open-url-about-blank-window.htm
<!doctype html>
<html>
<head>
<title>XMLHttpRequest: open() resolving URLs (about:blank iframe)</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="help" href="https://xhr.spec.whatwg.org/#the-open()-method" data-tested-assertations="following::ol/li[2]/ol/li[2] following::ol/li[7] following::ol/li[14]/ul/li[2]" />
<link rel="help" href="https://xhr.spec.whatwg.org/#the-responsetext-attribute" data-tested-assertations="following::ol/li[4]" />
<link rel="help" href="https://xhr.spec.whatwg.org/#concept-xmlhttprequest-document" data-tested-assertations=".." />
</head>
<body>
<div id="log"></div>
<iframe src="about:blank"></iframe>
<script>
test(function() {
var client = new self[0].XMLHttpRequest()
client.open("GET", "folder.txt", false)
client.send("")
assert_equals(client.responseText, "top\n")
})
</script>
</body>
</html>
Computing file changes ...
