Revision f274ef8747d3be649bba8708696fb31cb00fa75a authored by Srivatsa S. Bhat on 21 May 2013, 09:32:48 UTC, committed by Benjamin Herrenschmidt on 31 May 2013, 22:29:27 UTC
Adam Lackorzynski reported the following build failure on
!CONFIG_HOTPLUG_CPU configuration:

  CC      arch/powerpc/kernel/rtas.o
arch/powerpc/kernel/rtas.c: In function ‘rtas_cpu_state_change_mask’:
arch/powerpc/kernel/rtas.c:843:4: error: implicit declaration of function ‘cpu_down’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/rtas.o] Error 1
make: *** [arch/powerpc/kernel] Error 2

The build fails because cpu_down() is defined only under CONFIG_HOTPLUG_CPU.

Looking further, the mobility code in pseries is one of the call-sites which
uses rtas_ibm_suspend_me(), which in turn calls rtas_cpu_state_change_mask().
And the mobility code is unconditionally compiled-in (it does not fall under
any Kconfig option). And commit 120496ac (powerpc: Bring all threads online
prior to migration/hibernation) which introduced this build regression is
critical for the proper functioning of the migration code. So it appears
that the only solution to this problem is to enable CONFIG_HOTPLUG_CPU if
SMP is enabled on PPC_PSERIES platforms. So make that change in the Kconfig.

Reported-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: stable@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
1 parent 8e44ddc
History
File Mode Size
Kconfig -rw-r--r-- 7.6 KB
Makefile -rw-r--r-- 1.0 KB
ath3k.c -rw-r--r-- 12.2 KB
bcm203x.c -rw-r--r-- 6.8 KB
bfusb.c -rw-r--r-- 16.1 KB
bluecard_cs.c -rw-r--r-- 20.3 KB
bpa10x.c -rw-r--r-- 10.3 KB
bt3c_cs.c -rw-r--r-- 15.2 KB
btmrvl_debugfs.c -rw-r--r-- 5.8 KB
btmrvl_drv.h -rw-r--r-- 3.9 KB
btmrvl_main.c -rw-r--r-- 15.0 KB
btmrvl_sdio.c -rw-r--r-- 26.3 KB
btmrvl_sdio.h -rw-r--r-- 3.0 KB
btsdio.c -rw-r--r-- 8.2 KB
btuart_cs.c -rw-r--r-- 14.3 KB
btusb.c -rw-r--r-- 41.5 KB
btwilink.c -rw-r--r-- 8.9 KB
dtl1_cs.c -rw-r--r-- 12.7 KB
hci_ath.c -rw-r--r-- 5.0 KB
hci_bcsp.c -rw-r--r-- 18.4 KB
hci_h4.c -rw-r--r-- 4.0 KB
hci_h5.c -rw-r--r-- 15.8 KB
hci_ldisc.c -rw-r--r-- 13.1 KB
hci_ll.c -rw-r--r-- 11.9 KB
hci_uart.h -rw-r--r-- 2.9 KB
hci_vhci.c -rw-r--r-- 6.2 KB

back to top