Revision f274ef8747d3be649bba8708696fb31cb00fa75a authored by Srivatsa S. Bhat on 21 May 2013, 09:32:48 UTC, committed by Benjamin Herrenschmidt on 31 May 2013, 22:29:27 UTC
Adam Lackorzynski reported the following build failure on !CONFIG_HOTPLUG_CPU configuration: CC arch/powerpc/kernel/rtas.o arch/powerpc/kernel/rtas.c: In function ‘rtas_cpu_state_change_mask’: arch/powerpc/kernel/rtas.c:843:4: error: implicit declaration of function ‘cpu_down’ [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors make[1]: *** [arch/powerpc/kernel/rtas.o] Error 1 make: *** [arch/powerpc/kernel] Error 2 The build fails because cpu_down() is defined only under CONFIG_HOTPLUG_CPU. Looking further, the mobility code in pseries is one of the call-sites which uses rtas_ibm_suspend_me(), which in turn calls rtas_cpu_state_change_mask(). And the mobility code is unconditionally compiled-in (it does not fall under any Kconfig option). And commit 120496ac (powerpc: Bring all threads online prior to migration/hibernation) which introduced this build regression is critical for the proper functioning of the migration code. So it appears that the only solution to this problem is to enable CONFIG_HOTPLUG_CPU if SMP is enabled on PPC_PSERIES platforms. So make that change in the Kconfig. Reported-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de> Cc: stable@vger.kernel.org Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
1 parent 8e44ddc
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 20.6 KB |
Makefile | -rw-r--r-- | 3.7 KB |
devres.c | -rw-r--r-- | 3.0 KB |
gpio-74x164.c | -rw-r--r-- | 5.2 KB |
gpio-adnp.c | -rw-r--r-- | 13.4 KB |
gpio-adp5520.c | -rw-r--r-- | 4.4 KB |
gpio-adp5588.c | -rw-r--r-- | 11.4 KB |
gpio-amd8111.c | -rw-r--r-- | 6.8 KB |
gpio-arizona.c | -rw-r--r-- | 4.1 KB |
gpio-bt8xx.c | -rw-r--r-- | 8.0 KB |
gpio-clps711x.c | -rw-r--r-- | 5.0 KB |
gpio-cs5535.c | -rw-r--r-- | 9.5 KB |
gpio-da9052.c | -rw-r--r-- | 6.3 KB |
gpio-da9055.c | -rw-r--r-- | 4.7 KB |
gpio-davinci.c | -rw-r--r-- | 12.1 KB |
gpio-em.c | -rw-r--r-- | 10.2 KB |
gpio-ep93xx.c | -rw-r--r-- | 10.7 KB |
gpio-ge.c | -rw-r--r-- | 5.2 KB |
gpio-generic.c | -rw-r--r-- | 13.7 KB |
gpio-grgpio.c | -rw-r--r-- | 11.5 KB |
gpio-ich.c | -rw-r--r-- | 11.7 KB |
gpio-it8761e.c | -rw-r--r-- | 4.8 KB |
gpio-janz-ttl.c | -rw-r--r-- | 5.2 KB |
gpio-ks8695.c | -rw-r--r-- | 7.4 KB |
gpio-langwell.c | -rw-r--r-- | 12.3 KB |
gpio-lpc32xx.c | -rw-r--r-- | 14.8 KB |
gpio-lynxpoint.c | -rw-r--r-- | 12.3 KB |
gpio-max7300.c | -rw-r--r-- | 2.0 KB |
gpio-max7301.c | -rw-r--r-- | 2.7 KB |
gpio-max730x.c | -rw-r--r-- | 6.0 KB |
gpio-max732x.c | -rw-r--r-- | 16.5 KB |
gpio-mc33880.c | -rw-r--r-- | 4.2 KB |
gpio-mc9s08dz60.c | -rw-r--r-- | 3.5 KB |
gpio-mcp23s08.c | -rw-r--r-- | 17.5 KB |
gpio-ml-ioh.c | -rw-r--r-- | 15.0 KB |
gpio-mm-lantiq.c | -rw-r--r-- | 4.1 KB |
gpio-mpc5200.c | -rw-r--r-- | 9.6 KB |
gpio-mpc8xxx.c | -rw-r--r-- | 9.9 KB |
gpio-msic.c | -rw-r--r-- | 8.6 KB |
gpio-msm-v1.c | -rw-r--r-- | 25.1 KB |
gpio-msm-v2.c | -rw-r--r-- | 12.1 KB |
gpio-mvebu.c | -rw-r--r-- | 20.9 KB |
gpio-mxc.c | -rw-r--r-- | 13.5 KB |
gpio-mxs.c | -rw-r--r-- | 9.7 KB |
gpio-omap.c | -rw-r--r-- | 41.0 KB |
gpio-palmas.c | -rw-r--r-- | 5.2 KB |
gpio-pca953x.c | -rw-r--r-- | 20.2 KB |
gpio-pcf857x.c | -rw-r--r-- | 11.5 KB |
gpio-pch.c | -rw-r--r-- | 13.7 KB |
gpio-pl061.c | -rw-r--r-- | 9.9 KB |
gpio-pxa.c | -rw-r--r-- | 18.1 KB |
gpio-rc5t583.c | -rw-r--r-- | 5.2 KB |
gpio-rcar.c | -rw-r--r-- | 10.3 KB |
gpio-rdc321x.c | -rw-r--r-- | 6.3 KB |
gpio-sa1100.c | -rw-r--r-- | 1.6 KB |
gpio-samsung.c | -rw-r--r-- | 70.2 KB |
gpio-sch.c | -rw-r--r-- | 6.9 KB |
gpio-sodaville.c | -rw-r--r-- | 6.4 KB |
gpio-spear-spics.c | -rw-r--r-- | 5.7 KB |
gpio-sta2x11.c | -rw-r--r-- | 11.1 KB |
gpio-stmpe.c | -rw-r--r-- | 11.1 KB |
gpio-stp-xway.c | -rw-r--r-- | 8.3 KB |
gpio-sx150x.c | -rw-r--r-- | 15.4 KB |
gpio-tc3589x.c | -rw-r--r-- | 10.8 KB |
gpio-tegra.c | -rw-r--r-- | 14.1 KB |
gpio-timberdale.c | -rw-r--r-- | 8.8 KB |
gpio-tnetv107x.c | -rw-r--r-- | 5.3 KB |
gpio-tps6586x.c | -rw-r--r-- | 4.6 KB |
gpio-tps65910.c | -rw-r--r-- | 5.9 KB |
gpio-tps65912.c | -rw-r--r-- | 3.8 KB |
gpio-ts5500.c | -rw-r--r-- | 12.5 KB |
gpio-twl4030.c | -rw-r--r-- | 14.7 KB |
gpio-twl6040.c | -rw-r--r-- | 3.5 KB |
gpio-ucb1400.c | -rw-r--r-- | 2.4 KB |
gpio-viperboard.c | -rw-r--r-- | 12.6 KB |
gpio-vr41xx.c | -rw-r--r-- | 12.5 KB |
gpio-vx855.c | -rw-r--r-- | 8.2 KB |
gpio-wm831x.c | -rw-r--r-- | 7.3 KB |
gpio-wm8350.c | -rw-r--r-- | 4.4 KB |
gpio-wm8994.c | -rw-r--r-- | 7.4 KB |
gpio-xilinx.c | -rw-r--r-- | 7.0 KB |
gpiolib-acpi.c | -rw-r--r-- | 7.8 KB |
gpiolib-of.c | -rw-r--r-- | 6.0 KB |
gpiolib.c | -rw-r--r-- | 53.4 KB |
Computing file changes ...