Revision f274ef8747d3be649bba8708696fb31cb00fa75a authored by Srivatsa S. Bhat on 21 May 2013, 09:32:48 UTC, committed by Benjamin Herrenschmidt on 31 May 2013, 22:29:27 UTC
Adam Lackorzynski reported the following build failure on
!CONFIG_HOTPLUG_CPU configuration:

  CC      arch/powerpc/kernel/rtas.o
arch/powerpc/kernel/rtas.c: In function ‘rtas_cpu_state_change_mask’:
arch/powerpc/kernel/rtas.c:843:4: error: implicit declaration of function ‘cpu_down’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/rtas.o] Error 1
make: *** [arch/powerpc/kernel] Error 2

The build fails because cpu_down() is defined only under CONFIG_HOTPLUG_CPU.

Looking further, the mobility code in pseries is one of the call-sites which
uses rtas_ibm_suspend_me(), which in turn calls rtas_cpu_state_change_mask().
And the mobility code is unconditionally compiled-in (it does not fall under
any Kconfig option). And commit 120496ac (powerpc: Bring all threads online
prior to migration/hibernation) which introduced this build regression is
critical for the proper functioning of the migration code. So it appears
that the only solution to this problem is to enable CONFIG_HOTPLUG_CPU if
SMP is enabled on PPC_PSERIES platforms. So make that change in the Kconfig.

Reported-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: stable@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
1 parent 8e44ddc
History
File Mode Size
Kconfig -rw-r--r-- 3.7 KB
Makefile -rw-r--r-- 832 bytes
b43_pci_bridge.c -rw-r--r-- 1.8 KB
driver_chipcommon.c -rw-r--r-- 17.8 KB
driver_chipcommon_pmu.c -rw-r--r-- 21.9 KB
driver_chipcommon_sflash.c -rw-r--r-- 3.3 KB
driver_extif.c -rw-r--r-- 5.0 KB
driver_gige.c -rw-r--r-- 7.3 KB
driver_gpio.c -rw-r--r-- 5.2 KB
driver_mipscore.c -rw-r--r-- 8.4 KB
driver_pcicore.c -rw-r--r-- 18.3 KB
embedded.c -rw-r--r-- 6.2 KB
main.c -rw-r--r-- 33.6 KB
pci.c -rw-r--r-- 34.4 KB
pcihost_wrapper.c -rw-r--r-- 2.7 KB
pcmcia.c -rw-r--r-- 19.3 KB
scan.c -rw-r--r-- 10.2 KB
sdio.c -rw-r--r-- 15.6 KB
sprom.c -rw-r--r-- 5.2 KB
ssb_private.h -rw-r--r-- 8.0 KB

back to top