Revision f274ef8747d3be649bba8708696fb31cb00fa75a authored by Srivatsa S. Bhat on 21 May 2013, 09:32:48 UTC, committed by Benjamin Herrenschmidt on 31 May 2013, 22:29:27 UTC
Adam Lackorzynski reported the following build failure on
!CONFIG_HOTPLUG_CPU configuration:

  CC      arch/powerpc/kernel/rtas.o
arch/powerpc/kernel/rtas.c: In function ‘rtas_cpu_state_change_mask’:
arch/powerpc/kernel/rtas.c:843:4: error: implicit declaration of function ‘cpu_down’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/rtas.o] Error 1
make: *** [arch/powerpc/kernel] Error 2

The build fails because cpu_down() is defined only under CONFIG_HOTPLUG_CPU.

Looking further, the mobility code in pseries is one of the call-sites which
uses rtas_ibm_suspend_me(), which in turn calls rtas_cpu_state_change_mask().
And the mobility code is unconditionally compiled-in (it does not fall under
any Kconfig option). And commit 120496ac (powerpc: Bring all threads online
prior to migration/hibernation) which introduced this build regression is
critical for the proper functioning of the migration code. So it appears
that the only solution to this problem is to enable CONFIG_HOTPLUG_CPU if
SMP is enabled on PPC_PSERIES platforms. So make that change in the Kconfig.

Reported-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: stable@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
1 parent 8e44ddc
History
File Mode Size
iscsi
loopback
sbp
tcm_fc
Kconfig -rw-r--r-- 1.1 KB
Makefile -rw-r--r-- 828 bytes
target_core_alua.c -rw-r--r-- 54.3 KB
target_core_alua.h -rw-r--r-- 5.5 KB
target_core_configfs.c -rw-r--r-- 80.3 KB
target_core_device.c -rw-r--r-- 42.1 KB
target_core_fabric_configfs.c -rw-r--r-- 34.7 KB
target_core_fabric_lib.c -rw-r--r-- 12.3 KB
target_core_file.c -rw-r--r-- 19.2 KB
target_core_file.h -rw-r--r-- 965 bytes
target_core_hba.c -rw-r--r-- 4.2 KB
target_core_iblock.c -rw-r--r-- 17.8 KB
target_core_iblock.h -rw-r--r-- 518 bytes
target_core_internal.h -rw-r--r-- 5.4 KB
target_core_pr.c -rw-r--r-- 125.6 KB
target_core_pr.h -rw-r--r-- 2.2 KB
target_core_pscsi.c -rw-r--r-- 29.9 KB
target_core_pscsi.h -rw-r--r-- 1.3 KB
target_core_rd.c -rw-r--r-- 11.9 KB
target_core_rd.h -rw-r--r-- 1.2 KB
target_core_sbc.c -rw-r--r-- 18.0 KB
target_core_spc.c -rw-r--r-- 34.2 KB
target_core_stat.c -rw-r--r-- 48.1 KB
target_core_tmr.c -rw-r--r-- 11.4 KB
target_core_tpg.c -rw-r--r-- 23.4 KB
target_core_transport.c -rw-r--r-- 78.0 KB
target_core_ua.c -rw-r--r-- 8.9 KB
target_core_ua.h -rw-r--r-- 1.4 KB

back to top