Revision f2efc6e60089c99c342a6b7da47f1037e06c4296 authored by Shirish S on 30 October 2019, 08:50:46 UTC, committed by Alex Deucher on 06 November 2019, 20:26:53 UTC
[Why]

doing kthread_park()/unpark() from drm_sched_entity_fini
while GPU reset is in progress defeats all the purpose of
drm_sched_stop->kthread_park.
If drm_sched_entity_fini->kthread_unpark() happens AFTER
drm_sched_stop->kthread_park nothing prevents from another
(third) thread to keep submitting job to HW which will be
picked up by the unparked scheduler thread and try to submit
to HW but fail because the HW ring is deactivated.

[How]
grab the reset lock before calling drm_sched_entity_fini()

Signed-off-by: Shirish S <shirish.s@amd.com>
Suggested-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 576daab
History
File Mode Size
6fire
bcd2000
caiaq
hiface
line6
misc
usx2y
Kconfig -rw-r--r-- 4.8 KB
Makefile -rw-r--r-- 781 bytes
card.c -rw-r--r-- 24.0 KB
card.h -rw-r--r-- 6.9 KB
clock.c -rw-r--r-- 16.0 KB
clock.h -rw-r--r-- 392 bytes
debug.h -rw-r--r-- 301 bytes
endpoint.c -rw-r--r-- 32.3 KB
endpoint.h -rw-r--r-- 1.4 KB
format.c -rw-r--r-- 16.1 KB
format.h -rw-r--r-- 489 bytes
helper.c -rw-r--r-- 2.9 KB
helper.h -rw-r--r-- 1.3 KB
media.c -rw-r--r-- 8.1 KB
media.h -rw-r--r-- 2.4 KB
midi.c -rw-r--r-- 68.9 KB
midi.h -rw-r--r-- 1.9 KB
mixer.c -rw-r--r-- 94.3 KB
mixer.h -rw-r--r-- 3.5 KB
mixer_maps.c -rw-r--r-- 15.3 KB
mixer_quirks.c -rw-r--r-- 61.1 KB
mixer_quirks.h -rw-r--r-- 655 bytes
mixer_scarlett.c -rw-r--r-- 27.6 KB
mixer_scarlett.h -rw-r--r-- 208 bytes
mixer_scarlett_gen2.c -rw-r--r-- 54.3 KB
mixer_scarlett_gen2.h -rw-r--r-- 228 bytes
mixer_us16x08.c -rw-r--r-- 37.1 KB
mixer_us16x08.h -rw-r--r-- 4.0 KB
pcm.c -rw-r--r-- 49.9 KB
pcm.h -rw-r--r-- 586 bytes
power.c -rw-r--r-- 2.5 KB
power.h -rw-r--r-- 924 bytes
proc.c -rw-r--r-- 5.2 KB
proc.h -rw-r--r-- 250 bytes
quirks-table.h -rw-r--r-- 84.1 KB
quirks.c -rw-r--r-- 50.4 KB
quirks.h -rw-r--r-- 1.5 KB
stream.c -rw-r--r-- 31.8 KB
stream.h -rw-r--r-- 325 bytes
usbaudio.h -rw-r--r-- 3.2 KB
validate.c -rw-r--r-- 9.5 KB

back to top