Skip to main content

Browse the archive

https://github.com/torvalds/linux
13 July 2024, 08:20:57 UTC
Revision f39cdaebb89dc3e6dd4f3e75b6d4e87ef12190af authored by Anton Blanchard on 20 June 2012, 19:53:03 UTC, committed by Linus Torvalds on 20 June 2012, 21:39:36 UTC 
fault-inject: avoid call to random32() if fault injection is disabled
 
After enabling CONFIG_FAILSLAB I noticed random32 in profiles even if slub
fault injection wasn't enabled at runtime.

should_fail forces a comparison against random32() even if probability is
0:

        if (attr->probability <= random32() % 100)
                return false;

Add a check up front for probability == 0 and avoid all of the more
complicated checks.

Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 10d8935
History
Tip revision: f39cdaebb89dc3e6dd4f3e75b6d4e87ef12190af authored by Anton Blanchard on 20 June 2012, 19:53:03 UTC
fault-inject: avoid call to random32() if fault injection is disabled
Tip revision: f39cdae
File Mode Size
partitions
Kconfig -rw-r--r-- 3.3 KB
Kconfig.iosched -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 720 bytes
blk-cgroup.c -rw-r--r-- 22.8 KB
blk-cgroup.h -rw-r--r-- 10.4 KB
blk-core.c -rw-r--r-- 79.6 KB
blk-exec.c -rw-r--r-- 3.0 KB
blk-flush.c -rw-r--r-- 13.1 KB
blk-integrity.c -rw-r--r-- 11.5 KB
blk-ioc.c -rw-r--r-- 10.2 KB
blk-iopoll.c -rw-r--r-- 5.9 KB
blk-lib.c -rw-r--r-- 3.9 KB
blk-map.c -rw-r--r-- 8.2 KB
blk-merge.c -rw-r--r-- 12.1 KB
blk-settings.c -rw-r--r-- 25.7 KB
blk-softirq.c -rw-r--r-- 4.5 KB
blk-sysfs.c -rw-r--r-- 14.8 KB
blk-tag.c -rw-r--r-- 9.8 KB
blk-throttle.c -rw-r--r-- 31.1 KB
blk-timeout.c -rw-r--r-- 5.6 KB
blk.h -rw-r--r-- 7.1 KB
bsg-lib.c -rw-r--r-- 7.6 KB
bsg.c -rw-r--r-- 23.7 KB
cfq-iosched.c -rw-r--r-- 108.0 KB
compat_ioctl.c -rw-r--r-- 20.8 KB
deadline-iosched.c -rw-r--r-- 11.1 KB
elevator.c -rw-r--r-- 23.1 KB
genhd.c -rw-r--r-- 43.0 KB
ioctl.c -rw-r--r-- 8.7 KB
noop-iosched.c -rw-r--r-- 2.5 KB
partition-generic.c -rw-r--r-- 13.9 KB
scsi_ioctl.c -rw-r--r-- 19.6 KB
back to top