Skip to main content

Browse the archive

https://github.com/torvalds/linux
13 July 2024, 08:20:57 UTC
Revision f39cdaebb89dc3e6dd4f3e75b6d4e87ef12190af authored by Anton Blanchard on 20 June 2012, 19:53:03 UTC, committed by Linus Torvalds on 20 June 2012, 21:39:36 UTC 
fault-inject: avoid call to random32() if fault injection is disabled
 
After enabling CONFIG_FAILSLAB I noticed random32 in profiles even if slub
fault injection wasn't enabled at runtime.

should_fail forces a comparison against random32() even if probability is
0:

        if (attr->probability <= random32() % 100)
                return false;

Add a check up front for probability == 0 and avoid all of the more
complicated checks.

Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 10d8935
History
Tip revision: f39cdaebb89dc3e6dd4f3e75b6d4e87ef12190af authored by Anton Blanchard on 20 June 2012, 19:53:03 UTC
fault-inject: avoid call to random32() if fault injection is disabled
Tip revision: f39cdae
File Mode Size
.gitignore -rw-r--r-- 151 bytes
Kconfig -rw-r--r-- 5.3 KB
Makefile -rw-r--r-- 2.3 KB
gen_init_cpio.c -rw-r--r-- 13.1 KB
initramfs_data.S -rw-r--r-- 1.3 KB
back to top