https://github.com/torvalds/linux
Revision f3d5e3a4155b6f42f6f6f0a2cc95ca0adbabe1af authored by Herbert Xu on 19 September 2007, 17:46:28 UTC, committed by David S. Miller on 20 September 2007, 19:14:18 UTC
This patch makes pppol2tp_xmit call skb_cow_head so that we don't modify cloned skb data. It also gets rid of skb2 we only need to preserve the original skb for congestion notification, which is only applicable for ppp_async and ppp_sync. The other semantic change made here is the removal of socket accounting for data tranmitted out of pppol2tp_xmit. The original code leaked any existing socket skb accounting. We could fix this by dropping the original skb owner. However, this is undesirable as the packet has not physically left the host yet. In fact, all other tunnels in the kernel do not account skb's passing through to their own socket. In partciular, ESP over UDP does not do so and it is the closest tunnel type to PPPoL2TP. So this patch simply removes the socket accounting in pppol2tp_xmit. The accounting still applies to control packets of course. I've also added a reminder that the outgoing checksum here doesn't work. I suppose existing deployments don't actually enable checksums. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7a70e39
Tip revision: f3d5e3a4155b6f42f6f6f0a2cc95ca0adbabe1af authored by Herbert Xu on 19 September 2007, 17:46:28 UTC
[PPP] L2TP: Fix skb handling in pppol2tp_xmit
[PPP] L2TP: Fix skb handling in pppol2tp_xmit
Tip revision: f3d5e3a
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| scripts | ||
| security | ||
| sound | ||
| usr | ||
| .gitignore | -rw-r--r-- | 607 bytes |
| .mailmap | -rw-r--r-- | 3.6 KB |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 89.3 KB |
| Kbuild | -rw-r--r-- | 1.5 KB |
| MAINTAINERS | -rw-r--r-- | 91.1 KB |
| Makefile | -rw-r--r-- | 50.1 KB |
| README | -rw-r--r-- | 16.5 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.0 KB |
Computing file changes ...
