Revision - f451fd9 - ext4: drop the call to ext4_error() from ext4_get_group_info() - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

05 April 2024, 19:05:47 UTC

Revision f451fd97dd2b78f286379203a47d9d295c467255 authored by Fabio M. De Francesco on 14 June 2023, 10:02:55 UTC, committed by Theodore Ts'o on 15 June 2023, 02:24:05 UTC

ext4: drop the call to ext4_error() from ext4_get_group_info()

A recent patch added a call to ext4_error() which is problematic since
some callers of the ext4_get_group_info() function may be holding a
spinlock, whereas ext4_error() must never be called in atomic context.

This triggered a report from Syzbot: "BUG: sleeping function called from
invalid context in ext4_update_super" (see the link below).

Therefore, drop the call to ext4_error() from ext4_get_group_info(). In
the meantime use eight characters tabs instead of nine characters ones.

Reported-by: syzbot+4acc7d910e617b360859@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/00000000000070575805fdc6cdb2@google.com/
Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail")
Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20230614100446.14337-1-fmdefrancesco@gmail.com

1 parent 1948279

Files
Changes

Permalinks

Tip revision: f451fd97dd2b78f286379203a47d9d295c467255 authored by Fabio M. De Francesco on 14 June 2023, 10:02:55 UTC
ext4: drop the call to ext4_error() from ext4_get_group_info()

Tip revision: f451fd9

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
fs
include
init
io_uring
ipc
kernel
lib
mm
net
rust
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	20.1 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	151 bytes
.gitattributes	-rw-r--r--	90 bytes
.gitignore	-rw-r--r--	2.1 KB
.mailmap	-rw-r--r--	27.9 KB
.rustfmt.toml	-rw-r--r--	369 bytes
COPYING	-rw-r--r--	496 bytes
CREDITS	-rw-r--r--	100.1 KB
Kbuild	-rw-r--r--	2.5 KB
Kconfig	-rw-r--r--	555 bytes
MAINTAINERS	-rw-r--r--	693.5 KB
Makefile	-rw-r--r--	70.1 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

ext4: drop the call to ext4_error() from ext4_get_group_info()

README