| f4f8133 | Axel Naumann | 20 September 2023, 12:16:55 UTC | [config] Remove config/root-help.el.in: it is GPLed and thus incompatible. | 22 September 2023, 09:20:10 UTC |
| ebe6694 | Axel Naumann | 20 September 2023, 12:38:27 UTC | [cmake] Turn everything with incompatible licenses off by default: The default should be a ROOT binary that respects its license; any build that creates GPLed binaries should be an active decision. Affected are uses of fftw3, gsl, Pythia 8, and unuran (all GPL), as well as Pythia 6 which does not seem to have a license. | 22 September 2023, 09:19:06 UTC |
| 1d5baf0 | Danilo Piparo | 21 September 2023, 14:12:57 UTC | [Build] Remove flags causing warnings on MacOS when llvm 15 is used: -single_module and -bind_at_load. Once removed, they also do not cause problems to macos 11 and 12. | 21 September 2023, 17:29:30 UTC |
| 1831ce6 | Danilo Piparo | 21 September 2023, 14:12:41 UTC | [Build] Do not link libgtest twice when bulding ctest executables. | 21 September 2023, 17:29:30 UTC |
| e188c8f | Danilo Piparo | 21 September 2023, 09:07:30 UTC | [Build] Fix implicit comp. warning on MacOS when using llvm 15. The warning was "implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]" | 21 September 2023, 17:29:30 UTC |
| 14338c8 | Sergey Linev | 21 September 2023, 15:06:27 UTC | [jsroot] dev 21/09/2023 with fixes 1. TText/TLatex scaling to pad size 2. Handle TAxis with ndiv = 0 3. TGraph B draw option - proper bar width 4. Correctly use fixed label font size in TLegend, not always autoscale 5. Adjust columns width in TLegend to content 6. Correctly store defs when create image Fixes #13693 | 21 September 2023, 15:40:36 UTC |
| fb567b4 | Axel Naumann | 20 September 2023, 12:43:57 UTC | [core] Remove Demangle: unused and incompatible license. | 21 September 2023, 15:32:54 UTC |
| 6245f4f | Axel Naumann | 20 September 2023, 11:28:44 UTC | [mathcore] Fix incorrect license (NFC). | 21 September 2023, 15:25:35 UTC |
| 85a962f | Jonas Rembser | 21 September 2023, 12:26:09 UTC | [RF] Include `gsl_integration.h` in RooFitMore instead of copy-pasting Include `gsl_integration.h` in RooFitMore instead of copy-pasting code from gsl. The linking is done in the same was as in `math/mathmore/CMakeLists.txt`. This should add no additional dependency compilcations, because RooFitMore already linked against MathMore, which requires GSL to be present. | 21 September 2023, 15:00:35 UTC |
| 6627da7 | Utkarsh Saxena | 17 August 2022, 14:44:41 UTC | Do not evaluate dependent immediate invocations We deferred the evaluation of dependent immediate invocations in https://reviews.llvm.org/D119375 until instantiation. We should also not consider them referenced from a non-consteval context. Fixes: https://github.com/llvm/llvm-project/issues/55601 ``` template<typename T> class Bar { consteval static T x() { return 5; } public: Bar() : a(x()) {} private: int a; }; Bar<int> g(); ``` Is now accepted by clang. Previously it errored with: `cannot take address of consteval function 'x' outside of an immediate invocation Bar() : a(x()) {}` Differential Revision: https://reviews.llvm.org/D132031 --- Fixes https://github.com/root-project/root/issues/13698, a problem with the new C++ headers from the new macOS SDK. | 21 September 2023, 14:50:20 UTC |
| f54c828 | Axel Naumann | 20 September 2023, 14:45:54 UTC | [mathmore] Remove license-incompatible KelvinFunctions. Part of ROOT-10992 | 21 September 2023, 12:40:20 UTC |
| 3acc0e6 | Jonas Rembser | 20 September 2023, 15:21:55 UTC | [cmake] Option `roofit_multiprocess` requires option `minuit2` The RooFit gradient multiprocessing depends on Minuit2 at compile time. Therefore, building with `roofti_multiprocess=ON` should imply `minuit2=ON`, giving a warning if the user defined `minuit2=OFF`. Then, Minuit2 should only be added as a dependency to RooFitCore if `roofit_multiprocess` is switched on. | 20 September 2023, 19:43:45 UTC |
| 6866a57 | Jonas Rembser | 18 September 2023, 14:14:33 UTC | [math] Make Minuit2 the default minimizer in ROOT Math if available Most people prefer Minuit2 nowadays, especially RooFit users, as some of the more complicated fits don't converge with the old Minuit implementation. In case ROOT was built without Minuit2 enabled, the default falls back to `Minuit`. Also, since there is a "default default" already hardcoded in `MinimizerOptions.cxx`, it is not necessary to specify another "default default" in the default `.rootrc`. The corresponding line is commented out. | 20 September 2023, 19:43:45 UTC |
| 1dcd853 | Jonas Rembser | 20 September 2023, 14:19:47 UTC | [RF] Loosen comparision precision in `testHypoTestInvResult` For the estimated error on the upper limit, we need to loosen the tolerance because it is determined on-the-fly with a fit, and not read as a data member like the comment in the test said before. Withg the default minimizer changing from Minuit to Minuit2, the results are slightly different and caused this test to fail. | 20 September 2023, 19:43:45 UTC |
| 8a1d41f | Jonas Rembser | 20 September 2023, 13:10:56 UTC | [RF] Always use Minuit1 for contour plot tutorials The contour implementation in Minuit2 doesn't work for these RooFit tutorials yet. | 20 September 2023, 19:43:45 UTC |
| eb622bf | Jonas Rembser | 18 September 2023, 12:28:54 UTC | [RF] Slighlty loosen arbitrary precision parameter in `testHistFactory` This is to make the test also pass when using Minuit2, where the post fit parameters differ by a tiny bit, pushing one of the precision parameters over the edge by 3 percent. To have a bit of a margin, the relevant precision constants are increased by 10 percent. | 20 September 2023, 19:43:45 UTC |
| bd562e1 | Jonas Rembser | 18 September 2023, 09:42:38 UTC | [RF] Adapt `testNaNPacker` to Minut2 being the default minimizer | 20 September 2023, 19:43:45 UTC |
| cdc6830 | Jonas Rembser | 20 September 2023, 12:44:15 UTC | [RF] Add config flag to set minimizer in `stressRooFit/HistFactory` This config parameter was already present for `stressRooStats`, and this commit also adds it for `stressRooFit` and `stressHistFactory`. The default minimizer is hardcoded to `Minuit`, not `Minuit2`. Furthermore, the code is modernized a bit, for example by using raw string literals and `int` instead of `Int_t`. | 20 September 2023, 19:43:45 UTC |
| e8bdfaf | Jonas Rembser | 19 September 2023, 14:22:19 UTC | [RF] Fix all typos in RooFit source code This was done with the help of this very useful tool: https://github.com/crate-ci/typos | 20 September 2023, 14:26:10 UTC |
| 256dd33 | YuryYury | 20 September 2023, 11:50:40 UTC | Fixing a typo in histpalettecolor.C (#13680) | 20 September 2023, 11:50:40 UTC |
| e58055c | Jonas Rembser | 18 September 2023, 17:43:28 UTC | [RF] Avoid code duplication in likelihood and chi2 fitting The function that steered the chi2 minimization had almost the exact same implementation as the one steering the likelihood fits. It would be better is the chi2 fits also use the same function as the likelihood fits, which is implemented in this PR. | 20 September 2023, 09:45:06 UTC |
| fb64189 | Jonas Rembser | 18 September 2023, 17:32:24 UTC | [RF] Move declaration and parsing of minimizer options to FitHelpers | 20 September 2023, 09:45:06 UTC |
| a23595b | Jonas Rembser | 18 September 2023, 17:06:15 UTC | [RF] Don't preprocess const-term optimization flag in `fitTo()` We can avoid the const-term-optimization in BatchMode or `codegen` simply by overriding the relevant function in the wrapper classes. | 20 September 2023, 09:45:06 UTC |
| 1a7f63f | Jonas Rembser | 18 September 2023, 16:51:29 UTC | [RF] Remove `RooFitCommon` library and use `gSystem->TempDirectory()` The RooFitCommon library only contained one single function to create a temporary directory `/tmp/roofit/` that was not even platform independed. This commit suggests to use `gSystem->TempDirectory()` instead, and prefix the temporary files with `roofit_` so there is no need for creating another subdirectory. | 20 September 2023, 09:45:06 UTC |
| 1c4e1af | Jonas Rembser | 18 September 2023, 11:56:36 UTC | [RF] Introduce separate private `FitHeaders.h` interface | 20 September 2023, 09:45:06 UTC |
| a680f0a | Jonas Rembser | 19 September 2023, 02:40:03 UTC | [RF] Fix logic error in RooAbsPdf where Offset() was ignored in fitTo() There was a little bug in `fitTo()` when the new modular test statistics got implemented in fe6935be8a. If the `ModularL` command is not passed, the offsetting flag should be forwarded to `createNLL()`, because only for the new test statistics the offsetting is done in the minimizer only. | 20 September 2023, 09:12:22 UTC |
| acd7618 | Jonas Rembser | 19 September 2023, 02:39:20 UTC | [RF] Fix typos in RooFit tutorials | 20 September 2023, 09:12:22 UTC |
| afd622c | Jonas Rembser | 19 September 2023, 01:59:38 UTC | [RF] Implement `Offset("bin")` also for RooDataSet fits Fully implement the `Offset("bin")` feature also for RooDataSet, both with CPU/CUDA BatchMode and the legacy tests statistics. This is done now by introducing a new element in the computation graph: an "offset pdf" that is created as a RooHistPdf from the observed data, and it is used to get the counterterm in each bin. It was validated with the `rf614` tutorial that this binwise offsetting is indeed fixing the convergense problems that the simple offsetting by the initial NLL value can't fix. Closes #11965. | 20 September 2023, 09:12:22 UTC |
| f7594a3 | Vincenzo Eduardo Padulano | 05 September 2023, 16:21:03 UTC | [PyROOT] Make building with Python 2 optional In preparation for a future removal of Python 2 support, add the `pyroot-python2` cmake build option (OFF by default). Users who really need Python 2 support can still get it, but warn them that it will be removed in a future ROOT release. | 20 September 2023, 08:51:55 UTC |
| 57a5c9a | Axel Naumann | 19 September 2023, 14:51:42 UTC | [cmake] Replace FindOracle.cmake: Nicer to distribute a BSD licensed version. The file `COPYING-CMAKE-SCRIPTS` is missing virtually worldwide, not even CMake includes it: https://gitlab.kitware.com/search?search=COPYING-CMAKE-SCRIPTS&nav_source=navbar&project_id=541&group_id=415&search_code=true&repository_ref=master | 19 September 2023, 21:20:27 UTC |
| 8b7aa49 | Sergey Linev | 19 September 2023, 11:55:48 UTC | Provide correct TCanvas::Draw and TPad::Draw for web canvas Instead direct call of Paint() call UpdateAsync() Prevent Paint() when calling TCanvas::SetGrayscale | 19 September 2023, 15:42:44 UTC |
| 98e9e74 | Sergey Linev | 19 September 2023, 14:52:45 UTC | [jsroot] 7.5.pre 19/09/2023 with grayscale support Add support of grayscale flag in the canvas | 19 September 2023, 15:41:09 UTC |
| 5df0ef8 | Sergey Linev | 19 September 2023, 07:49:41 UTC | [jsroot] 7.5.pre 19/09/2023 Preliminary 7.5.0 release for ROOT 6.30 Improve build legend functionality, provide as context menu command Fix toggling of hist draw options | 19 September 2023, 11:48:35 UTC |
| 0e78f9c | Sergey Linev | 19 September 2023, 07:43:35 UTC | [webgui] use actual canvas size as pdf page size When producing pdf document, set page size to maximal canvas size. Also include margins into page size to let normally embed complete canvas per page. | 19 September 2023, 11:48:35 UTC |
| 0b8fc4b | Sergey Linev | 13 September 2023, 11:52:07 UTC | [ipython] fix canvas width/height usage Use GetWindowWidth()/GetWindowHeight() methods to get configured drawing dimension, do not swap width/height parameters | 19 September 2023, 06:08:34 UTC |
| dfd8a8a | Sergey Linev | 13 September 2023, 11:19:35 UTC | [ipython] use TWebCanvas for canvas rendering This class provides all necessary functionality for web-based display, including handling of stacks, stats, styles, colors and so on Adjust layout of the div element - use 'relative' position to preserve dimension of the JSROOT drawings. | 19 September 2023, 06:08:34 UTC |
| 4f7854d | Sergey Linev | 13 September 2023, 09:27:16 UTC | [ipython] support RCnavas.Update() Handle same as for TCanvas. Use RCanvas::GetUID() for canvas identifier. | 19 September 2023, 06:08:34 UTC |
| b3ae186 | Sergey Linev | 13 September 2023, 08:52:09 UTC | [rcanvas] add IsUpdated() flag, required for iPython Fix problem with IsShown() - also should be set in batch mode Provide GetUID() method, which will be used in iPython | 19 September 2023, 06:08:34 UTC |
| 40842c7 | Sergey Linev | 13 September 2023, 08:33:23 UTC | [ipython] implement Update of canvas drawing Keep list of display handles for TCanvas and if Update called - try to update it. Works for jsroot and png display | 19 September 2023, 06:08:34 UTC |
| 9fb6731 | Sergey Linev | 12 September 2023, 14:23:40 UTC | Add TCanvas::IsUpdated() method It inform that Update() or UpdateAsync() methods were called. Will be used in iPython to implement graphics update functionality | 19 September 2023, 06:08:34 UTC |
| d0b9ee3 | moneta | 18 September 2023, 10:14:10 UTC | Reduce number of events in PyKeras Regression tutorial to avoid timeout | 18 September 2023, 13:52:42 UTC |
| acc2849 | moneta | 18 September 2023, 09:42:49 UTC | [pyroot] Add dependency on dataframe for rtensor test. This should fix some of the failures observed for builds without rdataframe | 18 September 2023, 13:52:42 UTC |
| 6426d90 | Jonas Rembser | 15 September 2023, 14:01:42 UTC | [RF] Bugfix in `RooDataSet::reduce()` by also copying the stored errors After adding support for subrange fits with the `RooXYChi2Var`, it initially didn't work because the y-value errors were missing in the dataset. This is because `RooDataSet::reduce()` is not copying the errors over to the reduced dataset, which is a bug. Fortunately, there is a straighforward solution. To create the reduced `RooDataSet`, it now doesn't use some buggy private constructor (that is now removed), but instead the trusty `RooAbsData::emptyClone()` method, for which I fixed the problem with the errors not being copied already some time ago. | 18 September 2023, 09:03:48 UTC |
| c9bbb99 | Jonas Rembser | 15 September 2023, 13:29:49 UTC | [RF] Support `NumCPU()` and `Range()` in createChi2() for RooDataSets This is achieved in the same was as in `createNLL()`, by forwarding the configuration options to the `RooAbsOptTestStatistic` base class. | 18 September 2023, 09:03:48 UTC |
| 1b892b1 | Jonas Rembser | 15 September 2023, 12:52:22 UTC | [RF] Avoid separate RooXYChi2Var constructors for pdfs and functions It can be checked at runtime if a given `RooAbsReal` is a pdf or not. Like this, we also don't need a separate override of `createChi2(RooDataSet &)` in RooAbsPdf. | 18 September 2023, 09:03:48 UTC |
| 889beb3 | Jonas Rembser | 15 September 2023, 11:34:00 UTC | [RF] Remove multi-range chi-square fit logic from RooAbsPdf Almost a year ago, I fixed the support for comma-separated normalization ranges for pdfs, e.g. `pdf.setNormRange("range1,range2")` was fixed also for RooAddPdfs. As a result, the logic for multi-range likelihood fits was removed from `createNLL()`, because the multi-range fit didn't have to be treated as a special case anymore. The same applies also to chi-square fits. In fact, the reason why the `RooChi2Var` constructor and `RooAbsReal::createChi2()` methods had a `RooAbsPdf` overload was *only* this workaround! For regular RooAbsReals, the workaround was not necessary, because there is no normalization. Therefore, quite a few functions were removed in this commit. The multi-range chi2 fit is now also validated by the multi-range fit unit test in `testRooAbsPdf`. This is a follow-up to PR #11455 (commit fa10523706 in particular), where the same change was already make for regular likelihoods. | 18 September 2023, 09:03:48 UTC |
| 8c9f8bf | Olivier Couet | 18 September 2023, 07:03:38 UTC | [skip-ci] add missing parenthesis (#13658) | 18 September 2023, 07:03:38 UTC |
| e1c1002 | Danilo Piparo | 15 September 2023, 12:14:32 UTC | [Doc] Remove usage of polyfill.io | 15 September 2023, 20:28:35 UTC |
| 12d8a75 | Danilo Piparo | 15 September 2023, 10:18:54 UTC | [Doc] Remove CERN Matomo from the Doxygen documentation | 15 September 2023, 20:28:35 UTC |
| 4de48ca | Jonas Rembser | 14 September 2023, 23:51:05 UTC | [RF] Add flag to define RooLognormal in the standard way Add a flag to define the RooLognormal with `mu` and `sigma` instead of their exponentiated values. In particular, this is used for the RooFit HS3 import and export. | 15 September 2023, 11:16:41 UTC |
| 9cb2aab | Jonas Rembser | 14 September 2023, 16:15:46 UTC | [RF] Format code of RooExponential and RooLognormal As these classes are changed quite a bit by the previous and next commits, it is a good time to format them now. | 15 September 2023, 11:16:41 UTC |
| a03076e | Jonas Rembser | 14 September 2023, 16:07:57 UTC | [RF] Add flag to define RooExponential in the standard `exp(-c*x)` way In particular, this is used for the RooFit HS3 import and export. | 15 September 2023, 11:16:41 UTC |
| 6385744 | Jonas Rembser | 14 September 2023, 14:01:43 UTC | [RF][HS3] Store reference norm. set of RooAddPdf also in an attribute By storing the reference normalization set also in an attribute, one gets the JSON IO for the `_refCoefNorm` for free, because attributes are always covered by the JSON IO. | 15 September 2023, 11:16:41 UTC |
| 16bb01f | Jonas Rembser | 13 September 2023, 15:35:15 UTC | [RF] Fix inconsistency in `RooMinimizer` about minimizer type This is a potential problem: ```c++ setMinimizerType(type); _theFitter->Config().SetMinimizer(type, alg); ``` The call to `setMinimizerType()` will set a default minimizer if `type` is empty. This default minimizer is right now the same as in general ROOT, but if RooFit would have a different default, the default minimizer of the RooMinimizer and the internal `_theFitter` would become out of sync, as `SetMinimizer(type)` takes the ROOT default if type is empty, not the RooMinimizer default. The better approach is this: ```c++ setMinimizerType(type); _theFitter->Config().SetMinimizer(_cfg.minimizerType.c_str(), alg); ``` First, `setMinimizerType(type)` sets the minimizer type in `_cfg.minimizerType`, and then this information is taken to set the minimizer of the `ROOT::Fitter`. | 15 September 2023, 11:16:41 UTC |
| 75146cc | Jonas Rembser | 13 September 2023, 15:31:38 UTC | [RF] Avoid fitting empty dataset in `testRooAbsPdf` unit tests Fitting empty datasets doesn't give you a well-defined likelihood, and Minuit2 would actually explicitly print errors that would cause the test to fail. It's better to actually simulate non-empty toy datasets for fitting. Then, the unit tests will also pass when Minuit2 will be the default in the future. | 15 September 2023, 11:16:41 UTC |
| 592b124 | Jonas Rembser | 13 September 2023, 00:52:27 UTC | [RF] Use Minuit2 in `testHS3SimultaneousFit` The fit results of Minuit2 are less random, and therefore we can tighten the test tolerance. | 15 September 2023, 11:16:41 UTC |
| 11d4ea7 | Jonas Rembser | 12 September 2023, 23:18:25 UTC | [RF][HF] Fix typos in HistFactory | 15 September 2023, 11:16:41 UTC |
| 282b41c | Jonas Rembser | 12 September 2023, 23:17:47 UTC | [RF][HS3] Fix typos in RooFitHS3 | 15 September 2023, 11:16:41 UTC |
| b03e65a | Carsten Burgard | 08 September 2023, 10:13:57 UTC | [RF][HS3] Allow for non-exact matching in unit tests - off by default This is useful for debugging, but off by default. | 15 September 2023, 11:16:41 UTC |
| 6e9a07f | Carsten Burgard | 08 September 2023, 10:13:19 UTC | [RF][HS3] Updated importers and exporters to match changes in standard | 15 September 2023, 11:16:41 UTC |
| 38a30c2 | Carsten Burgard | 08 September 2023, 10:08:39 UTC | [RF][HS3] Added methods to automatically transform variables Also, renamed "bounds" to "edges" for data export. | 15 September 2023, 11:16:41 UTC |
| 807e256 | Carsten Burgard | 08 September 2023, 10:07:41 UTC | [RF] Added a few getters and setters | 15 September 2023, 11:16:41 UTC |
| b22c152 | Jonas Rembser | 12 September 2023, 12:13:32 UTC | [RF] Explain behavior of Extended() command in fitTo() and chi2FitTo() This commit improves the documentation of `RooAbsPdf::fitTo()` and `RooAbsReal::chi2FitTo()` by adding a more detailed explanation of the `Extended()` command argument. | 15 September 2023, 09:59:19 UTC |
| 408feb3 | Jonas Rembser | 12 September 2023, 11:39:07 UTC | [RF] Fix some typos in the RooFit documentation | 15 September 2023, 09:59:19 UTC |
| 1fd6bfd | Jonas Rembser | 12 September 2023, 11:21:40 UTC | [RF] Don't recommend direct use of RooChi2Var in RooPlot documentation The test statistic classes should not be used directly, but always via the `createNLL()` (or in this case `createChi2()`) wrapper. | 15 September 2023, 09:59:19 UTC |
| 2e12da4 | Jonas Rembser | 12 September 2023, 10:02:29 UTC | [RF] Avoid code duplication in RooAbsPdf and RooAbsReal `chi2FitTo()` | 15 September 2023, 09:59:19 UTC |
| 1df034b | Jonas Rembser | 11 September 2023, 21:22:52 UTC | [RF] Make extended fit default of RooAbsPdf::fitChi2() same as in fitTo It is confusing to the users that the chi2 fit is by default not extended, even if the pdf is extended. Because this is what happens in normal likelihood fits. This commit makes that behavior consistent and explains it in the release notes. Also, a new error message is added for the case you forcing a non extended fit on a pdf that must be extended, because this is guaranteed to give wrong results. | 15 September 2023, 09:59:19 UTC |
| a7008eb | Jonas Rembser | 11 September 2023, 23:25:04 UTC | [RF] Fix skipping of zero weights in tests statistic caching There was an evil hack in `RooAbsOptTestStatistic`: ```c++ _dataClone->cacheArgs(this,_cachedNodes,_normSet,!_funcClone->getAttribute("BinnedLikelihood")) ; ``` The final parameter determins if zero weights should be skipped when recalculating the caches. Indeed, for the NLL case, this corresponds to the BinnedLikelihood attrribute being present or not, but it broke the other test statistics for which zero weights should not be skipped at all. This commit suggests a safer way to manage this with a new `RooAbOptTestStatistic::_skipZeroWeights` flag. In particular, this change fixed a bug that got uncovered during a forum discussion: https://root-forum.cern.ch/t/failing-chi2-fit/56309/3 | 15 September 2023, 09:58:30 UTC |
| 1c5d7af | moneta | 14 September 2023, 21:43:43 UTC | [tmva][pymva] Use less events on testPyKerasRegression Reduce number of events to avoid timeout of the test. Do this separtly for MAcOSX, since we cannot disable there eager execution | 14 September 2023, 22:03:37 UTC |
| 352c353 | moneta | 14 September 2023, 17:57:08 UTC | [tmva][sofie] Add in RSofieReader specialization for single output | 14 September 2023, 22:03:37 UTC |
| ead7963 | moneta | 12 September 2023, 09:01:15 UTC | [tmva][sofie] Add in RSofieReader support for multiple inputs and custom operators To add the custom operator the function Load is added in RSofieReader Fix also the Keras parsing tests to use RSofieReader Add also a function to print the output tensors in RModel | 14 September 2023, 22:03:37 UTC |
| 08e9192 | moneta | 06 September 2023, 09:26:15 UTC | [tmva][pymva] Fixes for latest version of scikit-learn | 14 September 2023, 22:03:37 UTC |
| 8b005a0 | moneta | 06 September 2023, 09:03:07 UTC | [tmva][pymva] Do not disable tensorflow eager execution on MacoS Disbaling it causes an interference with multiprocessing and a restart of the process after it is endeded. This fixes the timeout of the PyKeras tests on MacOS. This commits apply also some small fixes/improvements on the deletetion of some TMVA objects. | 14 September 2023, 22:03:37 UTC |
| 0139f28 | moneta | 04 September 2023, 14:58:35 UTC | [tmva][sofie] Add dependency on sklearn for TMVA_SOFIE_Models tutorial | 14 September 2023, 22:03:37 UTC |
| 7793c20 | moneta | 04 September 2023, 12:37:43 UTC | [tmva][pymva] Use .h5 file instead of .keras Go back to use .h5 files instead of .keras due to a problem in Keras loading .keras files on MacOS ARM (see https://github.com/keras-team/keras/issues/18278 ) | 14 September 2023, 22:03:37 UTC |
| 160d396 | Jonas Rembser | 13 September 2023, 12:08:07 UTC | [math] Don't incl. "Math/Error.h" and "Math/Util.h" in Minuit2 headers The "Math/Error.h" header is not shipped with standalone Minuit2. It is not a perfect solution to just ship it with Minuit2, because the Error.h header behaves differently depending on the `MATHCORE_STANDALONE` macro being defined or not. The code would only work correctly if the user defines the `MATHCORE_STANDALONE` herself in the user code that uses standalone Minuit2, which would be annoying. Instead, this commit proposes another solution to the problem: for all headers also used in Minuit2 standalone, MathCore moves the definitions of all functions that use `Math/Error.h` out of the header files in the cxx files. Like this, the `Math/Error.h` is only a build dependency of standalone Minuit2, and the user doesn't need to define the `MATHCORE_STANDALONE` macro for it to work. Including the "Math/Util.h" header needs to be avoided for similar reasons (it's about another preprocessor macro related to `veccore`). | 14 September 2023, 16:04:37 UTC |
| ca43bce | Danilo Piparo | 14 September 2023, 11:29:23 UTC | [Doc] Reformulate Doxy doc not to trigger a compiler warning which is `root/net/net/src/TNetFile.cxx:19:29: warning: '/*' within block comment [-Wcomment]` on clang on macos 13.5.1 | 14 September 2023, 15:06:46 UTC |
| 2b3dd4f | Jonas Rembser | 06 September 2023, 00:16:33 UTC | [RF][PyROOT] Avoid boolean operators on numpy arrays in unit test The `n_in_range` reference value in the unit test `roodataset_numpy.TestRooDataSetNumpy.test_ignoring_out_of_range` apparently doesn't get computed right on some 32 platforms. I can't reproduce the problem, but I'm sure it will be fixed by avoiding the use of the operators `&` and `|` with numpy arrays. Just doing a manual loop in Python should be more platform independent. Closes #12162. | 14 September 2023, 12:33:14 UTC |
| 9c3558a | Danilo Piparo | 14 September 2023, 09:39:08 UTC | [Doc] Revamp and Doxygenize doc of T(X)NetFile and TS3WebFile | 14 September 2023, 10:16:11 UTC |
| 5c43684 | Axel Naumann | 13 September 2023, 10:39:53 UTC | [ci] Add title to list of failed tests. | 13 September 2023, 10:39:53 UTC |
| 8ce465c | Axel Naumann | 06 September 2023, 15:35:29 UTC | [minuit2] pick up ROOT version from ROOTConfig-version.cmake: build/version_number is gone. | 13 September 2023, 10:38:20 UTC |
| f4a2971 | Axel Naumann | 06 September 2023, 15:34:15 UTC | [proofd] Include RVersion.hxx instead of parsing it. | 13 September 2023, 10:38:20 UTC |
| 7c72f78 | Axel Naumann | 12 September 2023, 12:53:59 UTC | [base] Diagnose errors when version version date. | 13 September 2023, 10:38:20 UTC |
| f45f2c2 | Axel Naumann | 12 September 2023, 12:52:46 UTC | [config] root-config: use CMake variable instead of parsing RVersion.h. | 13 September 2023, 10:38:20 UTC |
| 13b0706 | Axel Naumann | 06 September 2023, 15:37:51 UTC | [core,cmake,build] Define ROOT version in header: This simplifies the release procedure: no more bootstrapping, no more running of scripts; the source is the source. Given that the source now has the authoritative version number for releases (unlike for dev branches, of course) the ROOT package version is now determined from that header, rather than git describe which is less reliable. The updated release procedure will appear at https://root.cern/for_developers/release_checklist/ | 13 September 2023, 10:38:20 UTC |
| 9b2b237 | Axel Naumann | 08 March 2022, 17:35:33 UTC | [rootx] Remove "core developers" from splash window: We do not show this anymore, and this requires complex operations and - in its current implementation - a working ROOT build as part of the version update. | 13 September 2023, 10:38:20 UTC |
| c1dbe06 | Vincenzo Eduardo Padulano | 06 September 2023, 07:06:55 UTC | [TMVA] Remove dependency on torch.onnx submodule As seen in https://github.com/pytorch/pytorch/pull/82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error. | 12 September 2023, 15:32:01 UTC |
| 917b19c | Sergey Linev | 12 September 2023, 09:11:00 UTC | [jsroot] dev 12/09/2023 Fix axis labels tilt Fix THStack update Support e1hist combination of draw options th1 render order of filled area and markers | 12 September 2023, 14:30:36 UTC |
| ea666a2 | Jonas Rembser | 11 September 2023, 18:04:51 UTC | [RF] Give example for multiple categories plot in rf501_simultaneouspdf Also, throw an exception with a helpful error message if the user attempts to use `RooFit::Slice()` with a comma-separates list of category states, which is not supported. This addresses a question on the forum: https://root-forum.cern.ch/t/plotting-two-categories-of-simultaneous-fit-in-a-single-plot/56250 | 12 September 2023, 13:36:11 UTC |
| 03dd288 | Sergey Linev | 11 September 2023, 14:30:07 UTC | [webcanvas] correctly check first normal connection Now first connection in list is batch connection, used for async update. | 12 September 2023, 07:34:57 UTC |
| 972cf90 | Sergey Linev | 11 September 2023, 14:10:42 UTC | [pyroot] in case of web display update web canvas in EventInputHook This function called regularly from interactive python session and can be used for proper update of the active canvas | 12 September 2023, 07:34:57 UTC |
| 70d03dc | Sergey Linev | 11 September 2023, 14:04:53 UTC | [webgui] immediately assign main thread in python case In such special mode web canvas or any other web components created from the main python thread - which stored at the moment when web win manager created. Callback only from this thread are allowed - all other threads has to be ignored. | 12 September 2023, 07:34:57 UTC |
| 73da3aa | Sergey Linev | 11 September 2023, 06:25:43 UTC | [webgui] always checks callbacks processing in web window Internally web window has special checks for thread id - when it assigned. With external events processing such thread is not set | 12 September 2023, 07:34:57 UTC |
| bc9d21a | Sergey Linev | 08 September 2023, 16:32:02 UTC | [webgui] let use TWebCanvas also without connection It is intermediate state when web window is shown, but no active connection is established. At such moment canvas->Update() was not updating objects - like invoking THStack::BuildPrimitives() to introduce all necessary histograms. Therefore create artificial batch connection which do exactly same job as active web window connection - but does not send any data. Also improve timer handling in TWebCanvas. Instead of enabling/disabling this timer just use fast or slow mode - changing intervals Instead | 12 September 2023, 07:34:57 UTC |
| 8d1d9d4 | Sergey Linev | 08 September 2023, 16:27:12 UTC | [webwindow] let use http server processing thread for widgets This is very special mode will be used only for the python, which creates special thread for events processing. And this thread is changing with the time | 12 September 2023, 07:34:57 UTC |
| cb86a11 | Sergey Linev | 08 September 2023, 16:25:39 UTC | [http] adjust timer interval depending on the load If there are no requests are processed during last 500 attempts, timer switch to the slow mode with 100 ms period. But immediately switched back to fast mode if new if new requests are processed. | 12 September 2023, 07:34:57 UTC |
| 4b2df16 | Danilo Piparo | 09 September 2023, 17:04:37 UTC | [Math] Respawn genvector tests because they accidentally dropped out from the building and testing process during the migration to CMake. Minimal changes to the code were applied to let them run, respecting the original coding style. | 12 September 2023, 06:50:38 UTC |
| 4ebc357 | Olivier Couet | 12 September 2023, 06:25:15 UTC | More fixes for stressGraphics (#13636) | 12 September 2023, 06:25:15 UTC |
| 0a0bcaa | Jonas Rembser | 07 September 2023, 15:56:21 UTC | [RF] Don't recompile when requesting the same class instance twice If you call `makePdfInstance` or `makeFunctionInstance` twice in a row with the same arguments, the RooClassFactory should not have to recompile anything. This is particularly important to support the jupyter notebook workflow, where the same cell might be run several times. In fact, before this commit, calling the `makeClassInstance` function twice in a row with the same arguments resulted in a crash. | 11 September 2023, 12:15:20 UTC |
| b01408a | Jonas Rembser | 07 September 2023, 15:09:01 UTC | [RF] Use `std::string` instead of C-style strings in RooClassFactory This should preserve backwards compatibility, because `const char*` implicitly casts to `std::string`. | 11 September 2023, 12:15:20 UTC |
