Revision - f57e46c - fix(language-service): two-way binding completion should not [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

07 August 2024, 03:31:07 UTC

Revision f57e46c53881c46e712a64e23bffb1893dfe54fc authored by ivanwonder on 10 April 2022, 14:46:16 UTC, committed by Dylan Hunn on 15 April 2022, 20:53:48 UTC

fix(language-service): two-way binding completion should not remove the trailing quote (#45582)

We allow the path to contain both the `t.BoundAttribute` and `t.BoundEvent` for two-way
bindings but do not want the path to contain both the `t.BoundAttribute` with its
children when the position is in the value span because we would then logically create a path
that also contains the `PropertyWrite` from the `t.BoundEvent`. This early return condition
ensures we target just `t.BoundAttribute` for this case and exclude `t.BoundEvent` children.

Fixes https://github.com/angular/vscode-ng-language-service/issues/1626

PR Close #45582

1 parent c6e0e3f

Files
Changes

Permalinks

Tip revision: f57e46c53881c46e712a64e23bffb1893dfe54fc authored by ivanwonder on 10 April 2022, 14:46:16 UTC
fix(language-service): two-way binding completion should not remove the trailing quote (#45582)

Tip revision: f57e46c

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	2.8 KB
.bazelrc	-rw-r--r--	6.7 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	915 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	46.9 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.2 KB
CHANGELOG.md	-rw-r--r--	284.2 KB
CHANGELOG_ARCHIVE.md	-rw-r--r--	742.5 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.9 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	5.0 KB
browser-providers.conf.js	-rw-r--r--	1.8 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	6.0 KB
package.json	-rw-r--r--	9.3 KB
renovate.json	-rw-r--r--	2.5 KB
test-events.js	-rw-r--r--	259 bytes
tsconfig-tslint.json	-rw-r--r--	171 bytes
tslint.json	-rw-r--r--	5.4 KB
yarn.lock	-rw-r--r--	706.3 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(language-service): two-way binding completion should not remove the trailing quote (#45582)

README.md