https://github.com/Kitware/CMake
Revision f5d3da091b8e5952f8e880afbd09ee2f18e8ea7f authored by Shoaib Meenai on 23 September 2020, 23:58:39 UTC, committed by Brad King on 24 September 2020, 19:37:24 UTC
In commit 55196a1440 (MSVC: Use 'lib' instead of 'link /lib' to create static libraries, 2020-01-10, v3.18.0-rc1~625^2) we changed CMake to use lib instead of `link /lib` to create static libraries, but it didn't search for `llvm-lib`. If you have `llvm-lib` but not `lib` (e.g. when cross-compiling), when `CMakeFindBinutils` is invoked for the `C` and `CXX` languages, `CMAKE_AR` is not found. When it's subsequently invoked for the ASM language, `CMAKE_ASM_SIMULATE_ID` and `CMAKE_ASM_COMPILER_FRONTEND_VARIANT` are not set (because `CMakeDetermineASMCompiler` doesn't call `CMAKE_DETERMINE_COMPILER_ID`, which sets those variables), so we go down the non-MSVC conditional and set `CMAKE_AR` to a GNU-style `ar`, which of course does not understand lib flags. Explicitly search for `llvm-lib` to avoid this situation.
1 parent 177fc02
Tip revision: f5d3da091b8e5952f8e880afbd09ee2f18e8ea7f authored by Shoaib Meenai on 23 September 2020, 23:58:39 UTC
Clang: Look for llvm-lib when using MSVC-like front-end
Clang: Look for llvm-lib when using MSVC-like front-end
Tip revision: f5d3da0
| File | Mode | Size |
|---|---|---|
| .github | ||
| .gitlab | ||
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Packaging | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .clang-format | -rw-r--r-- | 1.3 KB |
| .clang-tidy | -rw-r--r-- | 1.1 KB |
| .gitattributes | -rw-r--r-- | 1.1 KB |
| .gitignore | -rw-r--r-- | 132 bytes |
| .gitlab-ci.yml | -rw-r--r-- | 4.4 KB |
| .hooks-config | -rw-r--r-- | 418 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 9.7 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 11.9 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 33.4 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 3.0 KB |
| CTestConfig.cmake | -rw-r--r-- | 513 bytes |
| CTestCustom.cmake.in | -rw-r--r-- | 7.1 KB |
| CompileFlags.cmake | -rw-r--r-- | 4.2 KB |
| Copyright.txt | -rw-r--r-- | 5.2 KB |
| DartConfig.cmake | -rw-r--r-- | 374 bytes |
| README.rst | -rw-r--r-- | 3.9 KB |
| bootstrap | -rwxr-xr-x | 53.8 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 789 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
