| f632fc7 | Philippe Canal | 25 January 2022, 23:58:47 UTC | TBranchElement::InitInfo improve doc | 18 February 2022, 17:13:11 UTC |
| 94d5443 | Philippe Canal | 12 November 2021, 21:59:39 UTC | TBranchElement: do not set fOnfileObject for collection parent (type 3 or 4). This assignment is both unnecessary and harmfull. It is unnecessary because the pushd and popd of the onfile object address for those cases is already handle by the usage of PushDataCache and PopDataCache action for the branches of type 3 and 4 (via their configuration). It is harmfull because the type of the used/seen in the sub-branches might be completely different from the type of the collection content. For example, this code was crashing some CMS jobs because the sub-branches that had a "OnfileObject" corresponded to a nested sub-object (of type reco::ParticleState) and then this was (unconditionally) associated with the head node of the collection, which contained reco::PFCandidate objects (One of PFCandidate base class contains a reco::ParticleState sub-object). The assignment is triggered when visiting one of the child branch (type 31 or 41) of the collection parent branch. This is a fix for the main branch commit 875e8fb91418f9e520e5d9b22fb1d32f4a42faf0 which is fix for the issue #7754. | 03 February 2022, 01:23:26 UTC |
| d1247ea | Philippe Canal | 18 October 2021, 20:35:32 UTC | [NFC] Typo in comment | 03 February 2022, 01:23:26 UTC |
| b294814 | Philippe Canal | 05 October 2021, 22:12:06 UTC | TClass::GetRealData support more than one level of nesting | 03 February 2022, 01:23:26 UTC |
| d151c55 | Philippe Canal | 05 October 2021, 19:11:57 UTC | TBranchElement::Print add fOnfileObject to 'debugAddress' | 03 February 2022, 01:23:25 UTC |
| 202e774 | Philippe Canal | 29 June 2021, 21:50:58 UTC | Add comment on semantic of fConfiguration->fElemId == -1 | 03 February 2022, 01:22:49 UTC |
| d716865 | Philippe Canal | 29 June 2021, 21:34:29 UTC | TBranchElement::InitializeOffsets: don't confuse top level collection for missing data member | 03 February 2022, 01:22:49 UTC |
| 266f257 | Philippe Canal | 22 October 2021, 22:58:21 UTC | In SetOnfileObject also determine the 'last' branch based on name. The branch ID is not reliable as for the 'later' branch it has not yet been updated from the as-seen-when-writing value to the current value. | 03 February 2022, 01:22:49 UTC |
| 4c8da46 | Philippe Canal | 05 October 2021, 19:11:30 UTC | Further devel for extend io customization support: whole obj rule in split obj. Use the full name to make branch name comparisons | 03 February 2022, 01:22:49 UTC |
| 4c39fe1 | Philippe Canal | 25 June 2021, 18:10:01 UTC | Extend io customization support: whole obj rule in split obj with repetion In the case where the containing object held several sub-object whose type is a class which has a 'whole object' rule, prior to this commit, the infrastructure would re-use only one of the incoming object as input to the rule executions. | 03 February 2022, 01:22:49 UTC |
| 3bd95ed | Philippe Canal | 14 June 2021, 22:46:24 UTC | Extend io customization support: whole obj rule in split obj. Extend the support for a rule that applies to several data members (and thus currently is applied as the 'object level') to the case of a split object embedded within a split subobject of an object (previous it worked only for the collection case). This fixes issue #8428, see also https://cdcvs.fnal.gov/redmine/issues/25893. | 03 February 2022, 01:22:47 UTC |
| e707d41 | Philippe Canal | 29 January 2022, 00:56:28 UTC | Emulated Collection Proxy always need the VectorLooper for the StreamerInfoActions This fixes #9136. Without this commit, SelectLooper would select the 'GenericLooper' in the case of an emulated proxy for STL collection with (in the name) a custom allocator. However the GenericLooper only usable for collection with a compiled collection proxy. In particular, GenericLooper is calling the 'Next' function which is not defined for vector ... and emulated collection. Using it lead to an assert complaining (right fully so) that an 'undefined' function is being called. | 31 January 2022, 16:58:29 UTC |
| 5236a99 | Philippe Canal | 14 January 2022, 16:39:07 UTC | TStreamerInfo::New needs to use the CollectionProxy::New This fixes issue #9543 In the issue #9543, the unusual situation is the combination of: * there is (intentionally) no dictionary for `std::map<int,std::vector<int>>` * consequently we use an "emulated collection proxy" for that collection * there is (unintentional due to external config) interpreter information/ClassInfo for `std::map<int,std::vector<int>>` The crux of the issue #9542 is: * TClass::fSizeof info prefers the information from the CollectionProxy * TStreamerInfo::fSize is set to the value of TClass::fSizeOf * TClass:New prefers the constructor from the interpreter * TStreamerInfo::New was using TClass::New for that case * On the failing platform, the `sizeof(std::map<int,std::vector<int>>)` is larger than the size of the emulated collection. Since the I/O and TStreamerInfo uses the TCollection proxy and all of TStreamerInfo needs to prefer the information from the collection proxy (including the 'sizeof'). To fix #9542 the solution is for * TStremearInfo::New to prefer/use TCollectionProxy::New over TClass::New (i.e. the interpreted constructor in this particular case). | 19 January 2022, 16:01:33 UTC |
| 71bab00 | Jonas Hahnfeld | 13 January 2022, 09:28:00 UTC | RooAddPdf: Avoid UB in checkObservables A RooAddPdf may have more PDFs than coefficients, in which case "the coefficient of the last PDF is calculated automatically from the condition that the sum of all coefficients has to be 1". In this case, the last call to "_coefList.at(i)" is supposed to return a nullptr because the index is out of range, and dereferencing it is undefined behavior which Clang 13 optimizes away, leading to crashes. Fixes #9547 (cherry picked from commit 1f3f0fdc0544087042e6289376094bf06b2d259f) | 14 January 2022, 15:51:37 UTC |
| 89d80e1 | Jonas Rembser | 10 November 2021, 13:13:30 UTC | [RF] Cleanup `RooRealVar::_sharedPropList` in RooRealVar destructor In df1a5a6, a memory leak when reading RooRealVars from ROOT files was fixed by introducing a `RooRealVar::_sharedPropList` map that holds `std::weak_ptr`s to all shared properties objects that were created by any RooRealVar. However, a mechanism to cleanup the weak pointers from the map when they were explired was still missing, which caused the `RooRealVar::_sharedPropList` map to grow forever and by a lot, especially in toy studies where many datasets are created (in the RooFit dataset constructors, RooAbsReals are cloned, which triggers the creation of the shared properties object). In this commit, the `RooRealVar::_sharedPropList` map is cleaned from expiring pointers in the RooRealVar destructor, which should fix a bunch of RooFit problems that seemed like memory leaks. To avoid the static initialization order fiasko, the `_sharedPropList` is now allocated on the heap and only deleted when the process exits using the `RooSentinel` mechanism that is already used for the RooFit memory pools. | 12 November 2021, 23:19:03 UTC |
| 188739c | Emmanouil | 23 October 2020, 07:55:13 UTC | [RF] Fix global static objects initialization problem. | 12 November 2021, 23:19:03 UTC |
| cb756fc | Omar Zapata | 09 August 2021, 14:39:44 UTC | ROOT-R:fixed links to the users guide. | 19 August 2021, 17:30:55 UTC |
| 912c205 | Omar Zapata | 09 August 2021, 14:38:10 UTC | ROOT-R: fixed segfault evaluating R code | 19 August 2021, 17:30:55 UTC |
| 0099f77 | Philippe Canal | 07 July 2021, 20:11:24 UTC | gdml: add support for the official spelling of millimeter | 07 July 2021, 20:11:24 UTC |
| cf67fed | Philippe Canal | 22 June 2021, 21:03:46 UTC | Remove stray debug print out. It was inadvertently introduced in 82fad768c9a In TBranchElement::Print use the correct StreamerInfo in case of schema evolution | 22 June 2021, 21:10:20 UTC |
| b09e4d0 | Jonas Rembser | 21 June 2021, 09:32:11 UTC | [RF] Fix missing initializer warnings in MemPoolForRooSets.h (2nd try) This PR should finally fix the build warnings in the master nightlies, after the unsuccessful fix attempt in commit 4ed5ea3976743d1206a8f8c7579adeb1818a9695. I have checked that the missing field initializer warnings go away with this change by compiling the following example snippet under gcc48: ```C++ // compile with g++ -Wmissing-field-initializers -std=c++11 -o test test.cc struct A{ A() : arr_{{}} {} std::array<int, 10> arr_ = {{}}; }; int main() { A a{}; std::cout << a.arr_[0] << std::endl; return 0; } ``` The warnings are reproduced, and can successfully be suppressed by replacing `{}` with `{{}}`. | 22 June 2021, 08:11:18 UTC |
| 67dc213 | Vincenzo Eduardo Padulano | 06 May 2021, 12:17:21 UTC | [core] Missing include in string_view header | 31 May 2021, 16:53:22 UTC |
| 9cd0cac | Philippe Canal | 05 May 2021, 21:24:37 UTC | Record properly the number of dim of a string array in its StreamerElement | 07 May 2021, 20:26:46 UTC |
| a352ac9 | Philippe Canal | 05 May 2021, 21:23:47 UTC | Fix #8033: string array StreamerElement not recorded properly | 07 May 2021, 20:26:46 UTC |
| 6817011 | Jonas Rembser | 23 April 2021, 16:49:57 UTC | [RF] Use again operator new instead of ObjectAlloc in MemPoolForRooSets This reverts a change from commit 64f299ce3c08501d3ba42e164ad6e40c151bb25b. The change was causing crashes in in python code. | 29 April 2021, 14:27:33 UTC |
| 0e3b40d | Jonas Rembser | 21 April 2021, 15:57:16 UTC | [RF] Reduce memory consumption of MemPoolForRooSets The MemPoolForRooSets has two problems: 1. Scaling issues: increasing memory and CPU consumption with increasing number of arenas, becuase trying to allocate a new non-overlapping arena often fails. 2. Amplification of memory leaks in user code: If one of the elements in the arena leaks, the whole arena will leak. Since each arena has 6000 elements, this means a leak of a RooArgSet will be ampilfied by a factor 6000 in the worst case. This commit proposes a solution to the scaling/performance issues and the leak amplification. Explained for the example for RooArgSet, the idea is to use each arena 120 times because this is the size of RooArgSet in bytes. This can be done while still having unique adresses for each RooArgSet: 1. Keep a gap of 120 bytes between each RooArgSet 2. When an address was used before, add one byte and in can be used again So at the cost of allocating 2x more memory per arena, we can reuse each arena 120 times. Now, the good thing is that the interval of creating/deleting RooArgSets is usually higher than 6000. So when reusing an arena multiple times, they will eventually be filled only by leaking RooArgSets if there is a leak. Meaning the leak amplification effect should be gone. This was checked with the CMS Higgs combine toy fit example from the Higgs combine tutorial. Without this commit, there is a GB-level leak that can be clearly observed with `top`, but with this commit the leak becomes negligible again. (cherry picked from commit 73acf88a799547bfe7eacf37a4537a2968da57af) | 22 April 2021, 18:43:24 UTC |
| 3bae1f6 | Jonas Rembser | 20 April 2021, 10:43:20 UTC | [RF] Deallocate memory owned by empty MemPoolForRooSets Arenas If an arena in the MemPoolForRooSets is not referenced anymore, it should delete the memory it has allocated. (cherry picked from commit a3f4198f546e6e41323a8d0871aad74fcbb9b252) | 22 April 2021, 18:43:24 UTC |
| f0da4b4 | Stephan Hageboeck | 16 April 2021, 12:56:14 UTC | [RF] Fix memory leak in ToyMCSampler. Fix #7890. (cherry picked from commit e485b2898ae65b78cd4208ae2f5337b703228c8a) | 22 April 2021, 18:43:24 UTC |
| 76a5b5d | Axel Naumann | 12 April 2021, 09:13:16 UTC | [test] Update location of xrootd test files: The original directory was removed. (cherry picked from commit ca9ab88c7e38046dae309d039b7912e294a5435d) | 14 April 2021, 17:13:29 UTC |
| c55f27a | Jonas Hahnfeld | 09 April 2021, 08:51:56 UTC | [AArch64] Materialize FP constant in code for large code model (#7807) Backport of D99607, commit 6415f424bc. Original commit message: --- When using the large code model with FastISel (for example via clang -O0 which adds the optnone attribute), FP constants could still be materialized using adrp + ldr. Unconditionally enable the existing path for MachO to materialize the constant in code. [...] --- See the discussion in https://github.com/cms-sw/cmssw/issues/31123 for context on the observed crashes. (cherry picked from commit 9e104ac7900ca264066d57aac1655ac1d8daf5f0) | 09 April 2021, 08:51:56 UTC |
| 4419fb7 | Philippe Canal | 31 March 2021, 00:36:28 UTC | Fix the action PushDataCache for TClonesArray. It was using the wrong signature leading to the configuration to be mis-read. Fixes #7754 | 31 March 2021, 21:29:28 UTC |
| f8c8a43 | Philippe Canal | 24 March 2021, 18:09:47 UTC | [io] Correct cycle order in file merging for non-mergeable obj. Fixes #7676 | 26 March 2021, 17:42:44 UTC |
| 1f740dd | Axel Naumann | 12 November 2020, 11:24:46 UTC | [core] Fix TCling::GetSharedLibs() for macOS11: The massaging of libray names introduced by Fons needs to be applied earlier, right at the library names extracted from macOS dyld,to fix also TCling::GetSharedLibs() not mentioning unlinkable libraries. This in turn fixes TFile::MakeProject(), specifically roottest/root/meta/MakeProject/stltest generating a MAKEP that contains a linker line with unlinkable libs on macOS 11. While at it, update the static function name to signal what it is actually doing these days :-) (cherry picked from commit a7a4a54c01e1528e7a88c33d6d11306c7eda89f2) | 24 March 2021, 13:18:42 UTC |
| 08abf82 | Fons Rademakers | 04 November 2020, 15:37:32 UTC | Libraries found in the dynamic linker cache must be linked with -lXxxx. Linking with the full path of /usr/lib libraries does not trigger a search in the dynamic linker cache, only when libs are linked via -l. Exclude the Big Sur libs liboah and libRosetta as they cannot be linked. No idea why (yet). (cherry picked from commit 3c4a1197a102238336e8daef7948f083b293e696) | 24 March 2021, 13:18:42 UTC |
| aa43ecd | Fons Rademakers | 03 November 2020, 14:50:29 UTC | Check for libraries in the dynamic linker-cache of macOS 11. On macOS 11 most libraries are not anymore on the filesystem. The system ships with a built-in dynamic linker cache of all system-provided libraries. As part of this change, copies of dynamic libraries are no longer present on the filesystem. (cherry picked from commit f39d4b00b12ee09acf644e8c5bcf6b801b3340a5) | 24 March 2021, 13:18:42 UTC |
| 09eb975 | Fons Rademakers | 22 October 2020, 12:29:54 UTC | [etc,config] Update Makefile.arch, root-config.in for macOS 11. (cherry picked from commit 11909ee5a2ab7471dfedf21c1f4d83f56bdceba7) | 24 March 2021, 13:18:42 UTC |
| 160b699 | Axel Naumann | 29 October 2020, 13:08:43 UTC | [build] Fix compiledata.h for macOS11, remove <10.5. (cherry picked from commit 132b72c2000b9f942cc77b5cddec4e9c7161f836) | 24 March 2021, 13:18:42 UTC |
| 899e5aa | Axel Naumann | 22 October 2020, 13:22:57 UTC | [cmake] gsl, tbb: for macOS11, pass isysroot also to ld; silence warning "include <gsl/... - you meant <GSL/...?" by renaming source dir. (cherry picked from commit 06453461ae1b5ed2b452242f658c8498a13a8ee7) | 24 March 2021, 13:18:42 UTC |
| 082f744 | Axel Naumann | 12 June 2020, 16:39:46 UTC | [unix] No linked so does not mean failure on MacOS: An empty list of linked libraries was interpreted as failure to extract the list of linked libraries; the default "-lCore -lRint..." was taken instead. When running python, no libs show up as linked. That caused "-lRint" to be claimed as linked, which was preventing gSystem.Load("libRint") within python, claiming that it is already loaded (as it is linked). Instead, if the library signaling the end of linked libraries is seen, and so far no libraries have been found as linked, set the list-of-linked-libraries to " ", i.e. not empty, triggering the "success" path in TSystem::GetLibraries(), and correctly reporting the linked libraries. This fixes JupyROOT-cppcompleter-doctest, JupyROOT-ROOT-kernel-notebook not finding TTabCom::TTabCom() because loadling libRint was mistakenly a no-op. (cherry picked from commit bcd5d2241271425103cac17bbcbcbdb447197395) | 24 March 2021, 13:18:42 UTC |
| 4031bc6 | Oksana Shadura | 26 March 2020, 12:47:49 UTC | [ROOT-10636]Enable exception support in TBB In MVSC it is enabled automatically. More about: https://software.intel.com/en-us/blogs/2014/08/28/exact-exception-propagation-in-the-intel-threading-building-blocks-library-and-c11 (cherry picked from commit ced217771e922ec2aa25206df8799cbccf3d51f9) | 24 March 2021, 13:18:42 UTC |
| 0135aa1 | Jonas Hahnfeld | 17 March 2021, 11:56:02 UTC | Fix unwind info relocation with large code model on AArch64 Backport of D27629, commit 18805ea951. Original commit message: --- Makes sure that the unwind info uses 64bits pcrel relocation if a large code model is specified and handle the corresponding relocation in the ExecutionEngine. This can happen with certain kernel configuration (the same as the one in https://reviews.llvm.org/D27609, found at least on the ArchLinux stock kernel and the one used on https://www.packet.net/) using the builtin JIT memory manager. Co-authored-by: Yichao Yu <yyc1992@gmail.com> Co-authored-by: Valentin Churavy <v.churavy@gmail.com> --- Note: The handling in ExecutionEngine was committed in a different revision and is already part of LLVM 9. We need the part about emitting relocations because eh_frame (allocated in a data section) may be more than 4Gb away from the code section it references. See the discussion in https://github.com/cms-sw/cmssw/issues/31123 for context. (cherry picked from commit f481e8fe6df177ec1a50a10b7d76df5fb0b5c2a2) | 22 March 2021, 09:07:14 UTC |
| a517708 | Jonas Hahnfeld | 19 March 2021, 09:00:46 UTC | Fix unwind info relocation with large code model on PowerPC Backport of commit fe6e6d93d9. Original commit message: --- Allow FDE references outside the +/-2GB range supported by PC relative offsets for code models other than small/medium. For JIT application, memory layout is less controlled and can result in truncations otherwise. Patch based on one by Olexa Bilaniuk! Co-authored-by: Eric Christopher <echristo@gmail.com> --- | 22 March 2021, 09:07:14 UTC |
| 919c0bc | Enrico Guiraud | 17 March 2021, 16:52:52 UTC | [cmake] Add ROOTVecOps to ROOT_LIBRARIES It is a dependency of ROOTDataFrame which is already included in ROOT_LIBRARIES, so we want it there. | 18 March 2021, 14:07:58 UTC |
| 7d1a633 | Emmanouil | 18 February 2021, 11:34:43 UTC | [RF] Bugfix in RooVDTHeaders.h. | 18 February 2021, 11:45:58 UTC |
| dce2ab3 | Jonas Rembser | 11 February 2021, 22:06:43 UTC | [RF] RooFormula::processForumla: escape { and } in variable names. Fixes issue #7115. Some characters need to be escaped before using variable names in std::regex expressions formed in RooFormula::processForumla. Both [ and ] were already considered; this commit adds { and } to the list. | 17 February 2021, 11:12:29 UTC |
| 940b409 | Sergey Linev | 06 February 2021, 18:56:10 UTC | [pgsql] check when size > maxsize is statement | 09 February 2021, 16:06:40 UTC |
| 13977da | Sergey Linev | 06 February 2021, 08:49:44 UTC | [pgsql] set parameter type every time any parameter changed Avoid misinterpretation of parameter if after SetBinary SetNull is set. Also check memory allocation. | 09 February 2021, 16:06:40 UTC |
| a93da45 | Sergey Linev | 04 February 2021, 16:49:15 UTC | [pgsql] fix usage of sizeof operator in SetString It does not return size of allocated memory, therefore just reallocate buffer if maxsize bigger than standard buffer | 09 February 2021, 16:06:40 UTC |
| 5687210 | Sergey Linev | 04 February 2021, 16:44:42 UTC | [pgsql] use binary format for argument in TPgSQLStatement::SetBinary Fixing problem in #7127 with escape characters | 09 February 2021, 16:06:40 UTC |
| 1feb41c | Sergey Linev | 04 February 2021, 16:32:06 UTC | [pgsql] fix memory leak in TPgSQLStatement::SetNull | 09 February 2021, 16:06:40 UTC |
| 312dacb | Bertrand Bellenot | 08 January 2021, 13:47:32 UTC | [NFC] v6-20: Try to prevent anti-virus false positive detection on Windows Comment out part of the code to try to prevent false positive detection from several anti-virus engines on Windows (and multiproc is not supported on Windows anyway) | 08 January 2021, 15:02:47 UTC |
| a32552b | Enric Tejedor Saavedra | 13 October 2020, 08:03:18 UTC | [PyROOT] Silence deprecated-declarations warning for tp_print in Python3.8 | 13 October 2020, 12:32:54 UTC |
| 08801df | Mattias Ellert | 13 March 2020, 10:45:27 UTC | Fix -Wmissing-field-initializers in python bindings for Python 3.8 and 3.9 Warnings with python 3.8: .../bindings/pyroot/src/MethodProxy.cxx:891:1: warning: missing initializer for member '_typeobject::tp_vectorcall' [-Wmissing-field-initializers] .../bindings/pyroot/src/MethodProxy.cxx:891:1: warning: missing initializer for member '_typeobject::tp_print' [-Wmissing-field-initializers] Warnings with python 3.9: .../bindings/pyroot/src/MethodProxy.cxx:891:1: warning: missing initializer for member '_typeobject::tp_vectorcall' [-Wmissing-field-initializers] | 13 October 2020, 12:32:54 UTC |
| 6877628 | Philippe Canal | 08 September 2020, 23:30:37 UTC | Correct FullName of the index leaf of a collection | 16 September 2020, 07:44:52 UTC |
| 4cb885a | Philippe Canal | 26 August 2020, 18:50:48 UTC | Use FullName in TTree::GetLeaf. Fixes ROOT-10942 | 16 September 2020, 07:44:52 UTC |
| 4ef7cf5 | Axel Naumann | 07 September 2020, 15:36:28 UTC | Revert "[cling] Make sure declchain is deserialized:" This reverts commit 1a9569aa81b0aab0316ded194e4e0cc28005a4aa. (cherry picked from commit 423fa660c385f49eb5223bba1eaf16a0c468a629) | 09 September 2020, 15:57:06 UTC |
| 6a1df49 | Axel Naumann | 07 September 2020, 15:34:03 UTC | Revert "[cxxmodules] Delay constexpr evaluation of exception spec when deserializing." This reverts commit 30ecf72b9298c3122aeb3aeb523aae61e5bc4b95. It's superseded by "[clang] Backport llvm svn 331428:" (cherry picked from commit 81a12210b44d5cbc39f54ef7568cdf1b904347c0) | 09 September 2020, 15:57:06 UTC |
| 73644b2 | Axel Naumann | 03 September 2020, 15:44:52 UTC | [cling] Adjust to changed clang::ExceptionSpecificationType. (cherry picked from commit 30bebf88e8e17b242c3bc8871a682a6fab28ad38) | 09 September 2020, 15:57:06 UTC |
| b559d20 | Axel Naumann | 02 September 2020, 14:56:21 UTC | [clang] Backport llvm svn 331428: commit eaf11ad70904679593d3c7c100bcbcc395c91a89 Author: Richard Smith <richard-llvm@metafoo.co.uk> Date: Thu May 3 03:58:32 2018 +0000 Track the result of evaluating a computed noexcept specification on the FunctionProtoType. We previously re-evaluated the expression each time we wanted to know whether the type is noexcept or not. We now evaluate the expression exactly once. This is not quite "no functional change": it fixes a crasher bug during AST deserialization where we would try to evaluate the noexcept specification in a situation where we have not deserialized sufficient portions of the AST to permit such evaluation. llvm-svn: 331428 (cherry picked from commit 776492d58964a0d30f72a991605a15d08d47b09f) | 09 September 2020, 15:57:06 UTC |
| 1dd98e0 | Axel Naumann | 02 September 2020, 14:48:40 UTC | [clang] Apply parts of llvm svn 318570 (clang-tidy): Prevents conflicts of subsequent patch backport. (cherry picked from commit 290b29ca9bdd1dc483af0e3fc79595b0243e01af) | 09 September 2020, 15:57:06 UTC |
| a2edaa7 | Erich Keane | 12 October 2017, 23:01:53 UTC | Correctly handle an non-dependent noexcept expr in function template It seems that all of the other templated cases are handled correctly, however the function template case was not correctly handled. This patch recovers from this condition by setting the function to noexcept after diagnosing. Previously it simply set NoexceptExpr to null, which caused an Assert when this was evaluated during substitution. Differential Revision:https://reviews.llvm.org/D38700 llvm-svn: 315638 (cherry picked from commit afe74e3d62f6493dfcd1eb815fe7c669f1e251b6) | 09 September 2020, 15:57:06 UTC |
| 66e8e1a | Philippe Canal | 25 August 2020, 17:37:53 UTC | When normalizing template names, don't split inside parenthesis. This prevented the proper normalizing of template where one of the argument in a function type with more than one function argument. This fixes ROOT-11013. | 31 August 2020, 16:33:20 UTC |
| 963f043 | Gerardo GANIS | 04 May 2020, 07:57:28 UTC | Add config switch to disable (x)proofd. Default OFF. (#5432) * Add config switch to disable (x)proofd. Default OFF. This patch disables default building proofd and proofx modules, the PROOF ones requiring XRootD. The possibility to build these modules is provided as legacy and controlled by the switch 'xproofd' (-Dxproofd=ON). Note that these modules require XRootD v4 and the xrootd-private-devel RPM installed (or equivalent on Debian systems). Or -Dbuiltin_xrootd=ON . * Proof: fix segv introduced by patch 7a810c6f207 (2020-02-14) | 20 August 2020, 16:33:37 UTC |
| 20be1b7 | Mattias Ellert | 14 July 2020, 06:10:00 UTC | Compatibility with xrootd 5. The old client library libXrdClient is removed. Also XrdSysDNS is removed. Do not build the legacy XProofD file server and client (already disabled by default - give error if someone enables it while building with xrootd 5). Do not build the old libNetx. Build the new libNetNG without XrdSysDNS, use XrdNetAddr instead. | 20 August 2020, 16:33:37 UTC |
| 19278fc | Axel Naumann | 18 August 2020, 15:09:26 UTC | "Update ROOT version files to v6.20/09." | 18 August 2020, 15:09:26 UTC |
| 5144c58 | Axel Naumann | 18 August 2020, 14:13:10 UTC | "Update ROOT version files to v6.20/08." | 18 August 2020, 14:13:10 UTC |
| 2c39fb9 | Axel Naumann | 18 August 2020, 12:18:17 UTC | [relnotes] Update for v6.20/08. | 18 August 2020, 12:18:17 UTC |
| aae63f7 | Axel Naumann | 12 August 2020, 16:21:11 UTC | [TCling] Exclude deleted functions from iteration. | 14 August 2020, 07:45:14 UTC |
| 482d499 | Philippe Canal | 23 July 2020, 16:32:34 UTC | Remove obsolete TGenCollectionProxy::UpdateValueClass. The implementation was not thread safe **and** has been obsolete ever since fType is a TClassRef and since c9460ae556c84c9a7febb7cef6865e8e04c2621a make the update much faster (single atomic update) and thread safe. | 12 August 2020, 17:38:26 UTC |
| 7c60af1 | Philippe Canal | 23 July 2020, 15:09:47 UTC | Use std::memory_order_relaxed for 'standalone' atomics | 12 August 2020, 17:38:25 UTC |
| c320d4d | Philippe Canal | 21 July 2020, 22:50:57 UTC | Avoid extremely frequent setting of atomic to ... the same value. This was happening to TClass::fVersionUsed. Replacing the assignment with a test then assign greatly improved scaling of io on 'small objects' | 12 August 2020, 17:38:25 UTC |
| 7758e67 | Philippe Canal | 21 July 2020, 22:09:21 UTC | Reduce contention on some atomics in core/meta and io | 12 August 2020, 17:38:24 UTC |
| 7920741 | Philippe Canal | 23 July 2020, 15:31:11 UTC | [NFC] White space. | 12 August 2020, 17:26:12 UTC |
| 40677ca | Philippe Canal | 15 July 2020, 00:45:39 UTC | Improve TBasket/TBuffer memory allocation for reading. Rename TBasket::Reset to TBasket::WriteReset Add TBasket::ReadResetBuffer which will shrink the buffer is it is currently significantly larger than it is needed to any of the next (up to) 10 baskets. | 12 August 2020, 17:26:12 UTC |
| 21e7db4 | Enrico Guiraud | 08 August 2020, 17:43:48 UTC | Build built-in LZMA with O3 optimization level | 10 August 2020, 11:53:28 UTC |
| 0e9e235 | Enrico Guiraud | 06 August 2020, 10:19:17 UTC | [DF] Fix inclusion of certain arrow headers in new arrow versions arrow/compute/test_util.h has been removed from recent versions, but arrow/testing/gtest_util.h contains what we need and is present both in v0.15 and v0.17. | 07 August 2020, 08:43:22 UTC |
| c63cb66 | Enrico Guiraud | 07 August 2020, 07:50:07 UTC | [DOCS] Mention change of behavior of `df.GetColumnNames()` in relnotes | 07 August 2020, 07:50:07 UTC |
| fbce42a | Enrico Guiraud | 04 August 2020, 14:39:44 UTC | [DF] Use unique file names in tests Otherwise tests run concurrently can write on each other's feet. | 04 August 2020, 16:07:41 UTC |
| 69a009c | Enrico Guiraud | 03 August 2020, 15:40:27 UTC | [DF] Work around TTree::GetLeaf bug in GetBranchOrLeafTypeName This should bring RDF back to a fully working state (for all cases we test) after the change in valid column names discussed in ROOT-10942. | 04 August 2020, 16:06:19 UTC |
| fdd894d | Enrico Guiraud | 23 July 2020, 15:36:33 UTC | [DF] Add all spellings of a branch name to valid column names Before this patch, in cases in which t.GetBranch("a.b") and t.GetBranch("b") both returned a valid address, RDataFrame was adding only "a.b" to the list of valid TTree columns. With this patch, both "a.b" and "b" are recognized as valid column names. We need this change in behavior to avoid a _worse_ change in behavior, described in detail in ROOT-10942: since ROOT-10702 was fixed, TTree::GetBranch became more powerful and started returning non-null addresses for branch names with form "a.b" while it was returning a nullptr until v6.20/06. With RDataFrame's previous logic, this in turn meant that valid code that was using "a" as a column broke as RDataFrame was now adding the "a.b" spelling to the list of valid columns instead. This fixes the RDF-related part of ROOT-10942: "a" is recognized as a valid spelling again, and "a.b" is kept as a new valid spelling. | 28 July 2020, 08:52:20 UTC |
| 638ae53 | Enrico Guiraud | 12 May 2020, 09:03:57 UTC | [DF] Use FindBranch as a fallback way to check branch existence FindBranch deals with full branch names more nicely. This fixes RDF not being able to find the "i.x" branch in ROOT-10702. | 28 July 2020, 08:52:20 UTC |
| f5c8e91 | Enrico Guiraud | 12 May 2020, 10:00:02 UTC | [TTreeReader] Use FindBranch as a fallback method to find branch FindBranch deals with full branch names more nicely. This fixes TTreeReader not being able to find the "i.x" branch in ROOT-10702. | 28 July 2020, 08:52:20 UTC |
| 813d728 | Philippe Canal | 21 July 2020, 20:09:57 UTC | Avoid auto-parsing for std::pair during I/O init. Don't provoke auto-parsing during name normalization for the std::pair (but let it happen for its parameters if need be). In TGenCollectionProxy Don't provoke autoparsing for an std::pair. In TGenCollectionProxy handle the fact that we may now not find the std::pair. Addresses (at least part of) ROOT-10932 | 23 July 2020, 15:28:16 UTC |
| aef8f4e | Philippe Canal | 14 July 2020, 20:53:21 UTC | In TClass::GetListOfBaseClasses, correct conditional. It looks like without ROOT pcm but with a ClassInfo/Decl available but not loaded then the base class would not be properly setup. | 15 July 2020, 17:15:06 UTC |
| 112744a | Philippe Canal | 14 July 2020, 16:36:48 UTC | Reduce TBasket high water mark use. Fix ROOT-10927. In commit 79f2e3b0e5, TBranch::GetFreshBasket was effectively switch from always reallocating the TBuffer (i.e. minimal memory use but maximal number of memory allocation) to always keeping the TBuffer (i.e. maximal memory use but minimal number of memory allocations). This causes a problem in a use CMS use case where: - files were kept open - TTree were kept in memory - has (at least) one branch with one unusually large basket (257Mb) This accumulated to increase the memory use from 1.8Gb to 2.9Gb. For now (quick fix), we use TBasket::Reset (tuned for writing) also for reading. (This leads to spurrious large reallocation in case of a consecutive series of large baskets). | 14 July 2020, 19:45:39 UTC |
| 3056da6 | Andrei Gheata | 08 July 2020, 15:01:38 UTC | Avoid double delete by registering to TGeoManager reflected shape assemblies, owned by TGeoVolumeAssemby. (cherry picked from commit 437486008912b2da317097eaf7ea8f2ea1a822c4) | 09 July 2020, 14:09:47 UTC |
| 7ebb5bc | Olivier Couet | 01 July 2020, 15:07:09 UTC | Import doc version changer to 6.20 | 01 July 2020, 19:02:48 UTC |
| 19ac127 | Enric Tejedor Saavedra | 30 June 2020, 17:54:48 UTC | [CMake][PyROOT] Add missing else case | 01 July 2020, 07:19:59 UTC |
| 2dbfee2 | Enrico Guiraud | 29 June 2020, 08:46:19 UTC | [Tutorials] Veto df103_NanoAODHiggsAnalysis on Mac 10.13 Because of these errors (see e.g. https://bit.ly/31y2jSa): ``` Plugin dlopen(libXrdSecgsi-4.so, 256): image not found sec.protocol libXrdSecgsi-4.so Secsss: 0x30 cryptography load failed; Protocol not supported ``` | 30 June 2020, 08:12:58 UTC |
| 19606d2 | Sergey Linev | 26 June 2020, 20:04:36 UTC | Reset matrix global pointer in TTF This pointer was not initialized properly | 29 June 2020, 11:32:18 UTC |
| 35575c0 | Sergey Linev | 26 June 2020, 17:49:08 UTC | Correctly cleanup data in TTF (ROOT-10882) Created image may be cleaned up many time, causing ROOT crash One also should initialize that pointer properly | 29 June 2020, 11:32:18 UTC |
| 61f6828 | Enric Tejedor Saavedra | 26 June 2020, 09:40:35 UTC | [CMake] Protect ourselves in case pyroot_experimental has an arbitrary value | 26 June 2020, 12:27:26 UTC |
| 739e5fa | Enric Tejedor Saavedra | 25 June 2020, 13:51:35 UTC | [CMake][ROOT-10873] Fix setting of environment in LCG views | 26 June 2020, 12:27:26 UTC |
| 370de10 | Vassil Vassilev | 23 April 2020, 16:30:04 UTC | Make IMT an optional dependency. | 25 June 2020, 13:48:47 UTC |
| 4df2190 | Vassil Vassilev | 17 April 2020, 17:48:42 UTC | [cxxmodules] Convert filename to a module name. This fixes the Module X not found rootcling diagnostic when rootcling -m X.pcm is specified. | 25 June 2020, 13:48:47 UTC |
| daefe2f | Vassil Vassilev | 23 April 2020, 15:01:21 UTC | [cxxmodules] Load the dependent modules for both rootcling and rootcling_stage1. | 25 June 2020, 13:48:47 UTC |
| ce5a445 | Vassil Vassilev | 15 April 2020, 10:03:25 UTC | [cxxmodules] Preload the dependent modules if specified in rootcling. This should allow us to build non-standard modules such as boost. This patch should enable building the cmssw third-party modules for external dependencies. | 25 June 2020, 13:48:47 UTC |
| c4ac3d0 | Philippe Canal | 17 June 2020, 23:47:04 UTC | In MakeProject properly handle ptr in template args. Without this std::map<int,std::vector<double>* > got corrupted into std::map<int,std::vector<double,*> >. This fixes ROOT-10796 | 24 June 2020, 19:17:00 UTC |
| 40e8fd6 | Philippe Canal | 24 June 2020, 16:14:07 UTC | [NFC][io] Fix typo in comment and add new line after if | 24 June 2020, 16:14:58 UTC |
| 7e7394f | Philippe Canal | 23 June 2020, 18:16:56 UTC | Fix ROOT-9240 by preventing TMapFile::WhichMapFile from initializing TROOT. TMapFile::WhichMapFile is called via operator delete which is used during RegisterModule and letting TMapFile::WhichMapFile trigger the initialization of the TROOT object means that a) RegisterModule will have nested called to RegisterModule b) The interpreter will be created in the middle of the execution of RegisterModule. Both are potentially fatal (i.e. undefined behavior). | 24 June 2020, 15:52:42 UTC |
