Revision f6d9db6355227656108cb93dd8c74d9a9904c5fb authored by Arseny Maslennikov on 09 March 2019, 15:43:06 UTC, committed by Masahiro Yamada on 17 March 2019, 03:56:23 UTC
* The man page for dpkg-source(1) notes: > -b, --build directory [format-specific-parameters] > Build a source package (--build since dpkg 1.17.14). > <...> > > dpkg-source will build the source package with the first > format found in this ordered list: the format indicated > with the --format command line option, the format > indicated in debian/source/format, “1.0”. The fallback > to “1.0” is deprecated and will be removed at some point > in the future, you should always document the desired > source format in debian/source/format. See section > SOURCE PACKAGE FORMATS for an extensive description of > the various source package formats. Thus it would be more foolproof to explicitly use 1.0 (as we always did) than to rely on dpkg-source's defaults. * In a similar vein, debian/rules is not made executable by mkdebian, and dpkg-source warns about that but still silently fixes the file. Let's be explicit once again. Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
1 parent da9cfb8
checkversion.pl
#! /usr/bin/env perl
# SPDX-License-Identifier: GPL-2.0
#
# checkversion find uses of LINUX_VERSION_CODE or KERNEL_VERSION
# without including <linux/version.h>, or cases of
# including <linux/version.h> that don't need it.
# Copyright (C) 2003, Randy Dunlap <rdunlap@xenotime.net>
use strict;
$| = 1;
my $debugging;
foreach my $file (@ARGV) {
next if $file =~ "include/linux/version\.h";
# Open this file.
open( my $f, '<', $file )
or die "Can't open $file: $!\n";
# Initialize variables.
my ($fInComment, $fInString, $fUseVersion);
my $iLinuxVersion = 0;
while (<$f>) {
# Strip comments.
$fInComment && (s+^.*?\*/+ +o ? ($fInComment = 0) : next);
m+/\*+o && (s+/\*.*?\*/+ +go, (s+/\*.*$+ +o && ($fInComment = 1)));
# Pick up definitions.
if ( m/^\s*#/o ) {
$iLinuxVersion = $. if m/^\s*#\s*include\s*"linux\/version\.h"/o;
}
# Strip strings.
$fInString && (s+^.*?"+ +o ? ($fInString = 0) : next);
m+"+o && (s+".*?"+ +go, (s+".*$+ +o && ($fInString = 1)));
# Pick up definitions.
if ( m/^\s*#/o ) {
$iLinuxVersion = $. if m/^\s*#\s*include\s*<linux\/version\.h>/o;
}
# Look for uses: LINUX_VERSION_CODE, KERNEL_VERSION, UTS_RELEASE
if (($_ =~ /LINUX_VERSION_CODE/) || ($_ =~ /\WKERNEL_VERSION/)) {
$fUseVersion = 1;
last if $iLinuxVersion;
}
}
# Report used version IDs without include?
if ($fUseVersion && ! $iLinuxVersion) {
print "$file: $.: need linux/version.h\n";
}
# Report superfluous includes.
if ($iLinuxVersion && ! $fUseVersion) {
print "$file: $iLinuxVersion linux/version.h not needed.\n";
}
# debug: report OK results:
if ($debugging) {
if ($iLinuxVersion && $fUseVersion) {
print "$file: version use is OK ($iLinuxVersion)\n";
}
if (! $iLinuxVersion && ! $fUseVersion) {
print "$file: version use is OK (none)\n";
}
}
close($f);
}
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...