f7353e6 | Pablo Prietz | 25 August 2020, 08:00:42 UTC | Merge pull request #1997 from pupil-labs/develop Pupil v2.3 Release Candidate 1 | 25 August 2020, 08:00:42 UTC |
985d5c2 | Pablo Prietz | 25 August 2020, 07:59:06 UTC | Merge pull request #1994 from pupil-labs/better-pupil-mobile-network-lag-error-message Better Pupil Mobile network lag error message | 25 August 2020, 07:59:06 UTC |
b977192 | Roman Roibu | 24 August 2020, 10:33:17 UTC | Refine wording for Pupil Mobile connection issues Co-authored-by: Pablo Prietz <pablo@prietz.org> | 24 August 2020, 10:33:17 UTC |
0800ba3 | Roman Roibu | 24 August 2020, 07:33:47 UTC | Add suggestion on fixing Pupil Mobile network lag | 24 August 2020, 07:33:47 UTC |
7d8eaa1 | Pablo Prietz | 20 August 2020, 08:55:50 UTC | Merge pull request #1984 from pupil-labs/support-pi-headset-worn-classifier-data Support PI headset on/off classifier data | 20 August 2020, 08:55:50 UTC |
22463c8 | Pablo Prietz | 19 August 2020, 16:17:00 UTC | Fi logic error when generating fallback worn data | 19 August 2020, 16:17:00 UTC |
48a8d54 | Pablo Prietz | 19 August 2020, 14:59:45 UTC | Merge pull request #1992 from pupil-labs/cleanup_camera_models Cleanup camera models | 19 August 2020, 14:59:45 UTC |
bc38489 | Patrick Faion | 19 August 2020, 14:56:26 UTC | Fix typos/wording | 19 August 2020, 14:56:26 UTC |
9b2d27c | Patrick Faion | 19 August 2020, 12:38:15 UTC | Rephrase camera model calibration to intrinsics There was a mixed use of the terms calibration and intrinsics. Since we use calibration also for gazers, I renamed everything relating to intrinsics to not contain "calibration" anymore. There was also some mis-used cases of "pre-recorded calibrations" vs "default calibration", where some places referred to the default calibrations as "pre-recorded" and other places referred to user-recorded calibrations as "pre-recorded". I now used "default intrinsics" for all default intrinsics that we measured at some point and "recorded intrinsics" for intrinsics loaded from a file. | 19 August 2020, 12:38:15 UTC |
1a49e73 | Patrick Faion | 19 August 2020, 12:24:22 UTC | Move saving/loading intrinsics into Camera_Model The previous code would not savely encapsulate the logic, so when loading a saved DummyModel, it would actually get loaded as a RadialModel. Using a factory method and proper subclass registration makes it a lot easier to avoid duplication and inconsistencies between the subclasses. | 19 August 2020, 12:24:22 UTC |
4f9b67a | Patrick Faion | 19 August 2020, 10:49:12 UTC | Move duplicate code from camera models to base Both radial and fish-eye assume a camera model with camera matrix K and distortion coefficients D, so we can remove the duplicate logic here. I also added a comment on why/how the solvePnP is different. | 19 August 2020, 10:57:23 UTC |
56f5927 | Pablo Prietz | 19 August 2020, 09:38:12 UTC | Load worn data: Explicitly check against None results Avoids numpy ValueError when calling bool(conf_data) implicitly | 19 August 2020, 09:38:12 UTC |
fc89a04 | Patrick Faion | 18 August 2020, 12:06:39 UTC | Merge pull request #1990 from pupil-labs/add-windows-git-download Add notes about installing git to Windows docs | 18 August 2020, 12:06:39 UTC |
29e8fe8 | Patrick Faion | 14 August 2020, 08:30:23 UTC | Add notes about installing git to Windows docs | 14 August 2020, 08:30:23 UTC |
aec6a18 | Patrick Faion | 04 August 2020, 11:29:50 UTC | Merge pull request #1989 from pupil-labs/develop Pupil v2.2 Release Candidate 1 | 04 August 2020, 11:29:50 UTC |
35fa2d1 | Pablo Prietz | 04 August 2020, 10:11:27 UTC | Merge pull request #1988 from pupil-labs/remove-user-scale Remove gui user scale | 04 August 2020, 10:11:27 UTC |
3cfba21 | Patrick Faion | 04 August 2020, 09:56:26 UTC | Merge pull request #1987 from pupil-labs/eye_squared_default Eye window: Set 500x500 as default content size | 04 August 2020, 09:56:26 UTC |
3859436 | Patrick Faion | 04 August 2020, 09:44:52 UTC | Remove gui user scale | 04 August 2020, 09:44:52 UTC |
c6608f1 | Pablo Prietz | 04 August 2020, 09:37:12 UTC | Eye window: Collapse sidebar menu by default | 04 August 2020, 09:37:12 UTC |
ed796f2 | Patrick Faion | 04 August 2020, 09:25:06 UTC | Merge pull request #1976 from pupil-labs/cross-platform-display-scaling Cross-platform display scaling | 04 August 2020, 09:25:06 UTC |
a03de80 | Pablo Prietz | 04 August 2020, 08:03:28 UTC | Calculate minimum window size correctly on Retina displays | 04 August 2020, 08:03:28 UTC |
b92d632 | Pablo Prietz | 03 August 2020, 16:32:31 UTC | Eye: Set 500x500 as default content area Pupil Cam1 uses 4:3 resolutions. Pupil Cam2 and Cam3 use 1:1 resolutions. As all Pupil Core and VR/AR add-ons are shipped with Pupil Cam2 and Cam3 cameras, we adjust the default eye window size to a 1:1 content aspect ratio. The size of 500 was chosen s.t. the menu still fits. | 03 August 2020, 16:32:37 UTC |
dbd8043 | Pablo Prietz | 03 August 2020, 16:31:09 UTC | Eye: Use 192x192 as preferred frame size explicitly The UVC backend will fallback to the closest frame size if 192x192 is not available. | 03 August 2020, 16:32:37 UTC |
d8625fd | Patrick Faion | 03 August 2020, 14:40:24 UTC | Add comment Co-authored-by: Pablo Prietz <pablo@prietz.org> | 03 August 2020, 14:40:24 UTC |
a4622dc | Patrick Faion | 03 August 2020, 14:31:45 UTC | Call glClear on resize for all launchables | 03 August 2020, 14:31:45 UTC |
bdbbc8f | Patrick Faion | 03 August 2020, 14:12:27 UTC | Improve code clarity Co-authored-by: Pablo Prietz <pablo@prietz.org> | 03 August 2020, 14:12:27 UTC |
165a35c | Patrick Faion | 03 August 2020, 14:01:08 UTC | Add minimum window size for Capture and Player The menubar rendering seems to cause OpenGL errors when the window is too small. These errors even cause persistent UI issues. Setting a minimal size prevents this. Service does not need to be adjusted as it has no menubar. | 03 August 2020, 14:01:08 UTC |
ca6f49c | Roman Roibu | 01 August 2020, 17:29:28 UTC | Fix the scaling issue when setting the user GUI scale | 01 August 2020, 17:29:28 UTC |
a7c1292 | Roman Roibu | 30 July 2020, 14:35:22 UTC | Fix missing call to glfw.get_content_scale in service_ui.py | 30 July 2020, 14:35:22 UTC |
18eaa8f | Roman Roibu | 28 July 2020, 15:55:37 UTC | Save unscaled window size in init_dict in Service_UI for Windows and Linux | 28 July 2020, 15:55:37 UTC |
d9ad070 | Roman Roibu | 28 July 2020, 15:54:19 UTC | Save unscaled window size in session settings on Linux too | 28 July 2020, 15:54:19 UTC |
290c355 | Roman Roibu | 28 July 2020, 15:34:33 UTC | Save unscaled window size in session settings on Windows This fixes the issue that a window closed on a scaled window would reopen bigger by the content scale factor on init. | 28 July 2020, 15:34:33 UTC |
3ddb27c | Roman Roibu | 28 July 2020, 15:30:11 UTC | Fix recursive set_scale call on Windows in Service | 28 July 2020, 15:30:11 UTC |
91de82c | Roman Roibu | 28 July 2020, 14:47:00 UTC | Prevent drawing audio visualization if there is no data | 28 July 2020, 14:47:00 UTC |
7830a21 | Roman Roibu | 28 July 2020, 14:09:11 UTC | Update UI at the end of on_resize calls in launchables | 28 July 2020, 14:09:11 UTC |
47ad0c7 | Roman Roibu | 28 July 2020, 13:38:48 UTC | Apply black formatting | 28 July 2020, 13:38:48 UTC |
34f4348 | Roman Roibu | 28 July 2020, 13:38:37 UTC | Replace getHDPIFactor with more explicit get_content_scale | 28 July 2020, 13:38:37 UTC |
168d535 | Roman Roibu | 28 July 2020, 13:16:29 UTC | Update launchables' set_scale to account for changed icon bar width | 28 July 2020, 13:16:29 UTC |
6741777 | Roman Roibu | 28 July 2020, 13:15:37 UTC | Update launchables' set_window_size to account for display scale factor | 28 July 2020, 13:15:37 UTC |
029b6fb | Pablo Prietz | 28 July 2020, 10:54:04 UTC | Make Reset Window Size consistent on Windows | 28 July 2020, 10:54:04 UTC |
d6362d8 | Pablo Prietz | 28 July 2020, 10:53:50 UTC | Fix recursion error when setting ui user scale | 28 July 2020, 10:53:50 UTC |
c5e584b | Pablo Prietz | 28 July 2020, 10:28:14 UTC | Draw ui, glflush, and swap buffers on frame buffer size Redraws everything while resizing the window instead of clipping an old buffer | 28 July 2020, 10:28:14 UTC |
74daf3c | Pablo Prietz | 28 July 2020, 10:18:50 UTC | Call Plugin.gl_display() on frame buffer sizes Fixes #1981 | 28 July 2020, 10:18:50 UTC |
d099a2c | Roman Roibu | 28 July 2020, 09:30:23 UTC | Clear buffers on resize WIP: This is an attempt to fix redraw on resize | 28 July 2020, 09:30:23 UTC |
7a002e7 | Pablo Prietz | 28 July 2020, 08:58:29 UTC | Merge pull request #1972 from pupil-labs/disable-readonly-calibration-buttons Disable read only buttons in post-hoc calibration menu | 28 July 2020, 08:58:29 UTC |
608b53c | Roman Roibu | 28 July 2020, 07:50:28 UTC | Implement set_scale by calling on_resize | 28 July 2020, 07:50:28 UTC |
2133692 | Roman Roibu | 27 July 2020, 16:35:54 UTC | Use numpy in load_worn_data | 27 July 2020, 16:36:31 UTC |
b368d48 | Pablo Prietz | 27 July 2020, 13:21:50 UTC | Merge pull request #1983 from pupil-labs/fix_2d_monocular Fix crash when calibrating 2D monocularly | 27 July 2020, 13:21:50 UTC |
a1aded7 | Pablo Prietz | 27 July 2020, 12:02:38 UTC | Check if regressor was actually fit Fixes AttributeError when calibrating 2D monocularly | 27 July 2020, 12:02:38 UTC |
3f0895f | Roman Roibu | 27 July 2020, 10:51:54 UTC | Increment NEWEST_SUPPORTED_VERSION for invisible recordings | 27 July 2020, 10:51:54 UTC |
289d29c | Roman Roibu | 27 July 2020, 10:51:31 UTC | Add confidence data from worn.bin to pi_gaze_items | 27 July 2020, 10:51:31 UTC |
da56465 | Roman Roibu | 27 July 2020, 10:50:45 UTC | Add helper functions for finding and reading worn.bin files from timestamp path | 27 July 2020, 10:50:45 UTC |
bbf56e8 | Pablo Prietz | 27 July 2020, 09:47:59 UTC | Add pyglui v1.28 requirement (includes updated read-only button colors) | 27 July 2020, 09:47:59 UTC |
d03a6e5 | Patrick Faion | 24 July 2020, 07:24:50 UTC | Merge pull request #1980 from pupil-labs/zmq_log_handler_fallback Fix serialization issue in zmq log handler | 24 July 2020, 07:24:50 UTC |
d8ce7bd | Pablo Prietz | 23 July 2020, 13:15:31 UTC | Stringify log message Previously, the exeception handling expected the "msg" field to be a string. If an object was passed that is not msgpack-serializable, the exeception handling failed, e.g logger.debug([uuid.uuid4()]). | 23 July 2020, 13:15:31 UTC |
b6f744d | Pablo Prietz | 23 July 2020, 13:12:34 UTC | Fix SyntaxWarning SyntaxWarning: "is" with a literal. Did you mean "=="? | 23 July 2020, 13:12:34 UTC |
7bf9654 | Roman Roibu | 23 July 2020, 09:41:12 UTC | Update on_click definition to correctly map window coordinates to framebuffer coordinates | 23 July 2020, 09:41:12 UTC |
5eb29d0 | Roman Roibu | 23 July 2020, 09:34:23 UTC | Update on_pos in Visualizer plugin | 23 July 2020, 09:34:23 UTC |
1c04113 | Roman Roibu | 23 July 2020, 09:34:01 UTC | Fix unknow glfw name error | 23 July 2020, 09:34:01 UTC |
879a11f | Roman Roibu | 23 July 2020, 09:33:35 UTC | Update on_pos definition to correctly map window coordinates to framebuffer coordinates | 23 July 2020, 09:33:35 UTC |
40b3894 | Patrick Faion | 23 July 2020, 09:33:32 UTC | Merge pull request #1979 from pupil-labs/fix-expanded-empty-menu Ensure collapsed menubar for unloaded previously selected plugins | 23 July 2020, 09:33:32 UTC |
4a5a51a | Roman Roibu | 23 July 2020, 09:26:19 UTC | Add helper methods to disambiguate between content_scale and framebuffer_scale concepts | 23 July 2020, 09:26:19 UTC |
a737f13 | Patrick Faion | 22 July 2020, 15:39:49 UTC | Ensure collapsed menubar for unloaded plugins | 23 July 2020, 09:11:16 UTC |
ca80787 | Pablo Prietz | 23 July 2020, 07:24:23 UTC | Merge pull request #1978 from pupil-labs/fix-comment-rot Fix comment rot, pointing to renamed function | 23 July 2020, 07:24:23 UTC |
b3138bf | Roman Roibu | 23 July 2020, 06:55:38 UTC | Add glfw.GLFW_SCALE_TO_MONITOR hint to all plugin windows | 23 July 2020, 06:55:38 UTC |
06cbc7c | Roman Roibu | 23 July 2020, 06:55:14 UTC | Add glfw.GLFW_SCALE_TO_MONITOR hint to all launchable windows | 23 July 2020, 06:55:14 UTC |
e40be5e | Roman Roibu | 23 July 2020, 06:54:35 UTC | Add missing glfw constrants up until GLFW_SCALE_TO_MONITOR | 23 July 2020, 06:54:35 UTC |
29d3ccf | Roman Roibu | 23 July 2020, 06:54:07 UTC | Add glfw true/false constants | 23 July 2020, 06:54:07 UTC |
73457ba | Pablo Prietz | 22 July 2020, 15:03:03 UTC | Fix typo in comment | 22 July 2020, 15:03:03 UTC |
11fc222 | Patrick Faion | 22 July 2020, 14:20:05 UTC | Fix comment rot, pointing to renamed function | 22 July 2020, 14:20:05 UTC |
bed001f | Roman Roibu | 21 July 2020, 12:02:30 UTC | Update getHDPIFactor to use glfwGetWindowContentScale | 21 July 2020, 12:02:30 UTC |
45b518c | Roman Roibu | 21 July 2020, 12:00:17 UTC | Implement glfwGetWindowContentScale wrapper function | 21 July 2020, 12:00:17 UTC |
8692abd | Pablo Prietz | 21 July 2020, 08:22:10 UTC | Merge pull request #1974 from pupil-labs/gracefully-handle-accuracy-nan-values Gracefully handle accuracy NaN values | 21 July 2020, 08:22:10 UTC |
dd79b08 | Roman Roibu | 20 July 2020, 15:18:52 UTC | Adjust logging in case of valid angular accuracy/precision result | 20 July 2020, 15:18:52 UTC |
b4552b7 | Roman Roibu | 20 July 2020, 13:45:00 UTC | Gracefully handle accuracy NaN values | 20 July 2020, 13:45:00 UTC |
305f187 | Pablo Prietz | 16 July 2020, 13:19:53 UTC | Merge pull request #1973 from pupil-labs/fix_flickering_on_retina_display_after_window_size_reset Remove unnecessary on_resize call | 16 July 2020, 13:19:53 UTC |
87fea59 | Pablo Prietz | 16 July 2020, 10:35:46 UTC | Remove unnecessary on_resize call glfwSetWindowSize triggers a frame buffer change which will call on_resize with appropriate parameters. This fixes an issue on Mac retina displays which caused the world window to flicker after clicking the "Reset window size" button as on_resize() was not called with the window frame buffer size but with the window size. On retina displays, these are different which cause the issue to appear. | 16 July 2020, 10:35:46 UTC |
98c98ad | Roman Roibu | 16 July 2020, 09:04:12 UTC | Apply black formatting | 16 July 2020, 09:04:12 UTC |
2c1598e | Pablo Prietz | 16 July 2020, 08:13:25 UTC | Merge pull request #1971 from pupil-labs/flatten-plugin-class-hierarchy Flatten plugin class hierarchy | 16 July 2020, 08:13:25 UTC |
2796af8 | Roman Roibu | 15 July 2020, 18:37:41 UTC | When selection changes, update Duplicate and Delete button read_only properties in CalibrationMenu | 15 July 2020, 18:37:41 UTC |
9000764 | Roman Roibu | 15 July 2020, 18:37:06 UTC | Save references to the created Duplicate and Delete buttons in CalibrationMenu | 15 July 2020, 18:37:06 UTC |
15bfbdc | Roman Roibu | 15 July 2020, 18:36:30 UTC | Add _create_delete_button to StorageEditMenu | 15 July 2020, 18:36:30 UTC |
7f81c7c | Roman Roibu | 15 July 2020, 18:35:50 UTC | Extract checking calibration menu validity for Duplicate and Delete buttons into separate methods | 15 July 2020, 18:35:50 UTC |
93dc129 | Roman Roibu | 15 July 2020, 10:28:14 UTC | Replace Producer_Plugin_Base with System_Plugin_Base | 15 July 2020, 10:28:14 UTC |
bf51b23 | Roman Roibu | 15 July 2020, 10:27:45 UTC | Remove Experimental_Plugin_Base | 15 July 2020, 10:27:45 UTC |
5b27c39 | Roman Roibu | 15 July 2020, 10:27:19 UTC | Remove Analysis_Plugin_Base | 15 July 2020, 10:27:19 UTC |
3afff5a | Roman Roibu | 15 July 2020, 10:26:18 UTC | Remove Visualizer_Plugin_Base | 15 July 2020, 10:26:18 UTC |
ec61718 | Pablo Prietz | 13 July 2020, 08:56:57 UTC | Merge pull request #1968 from pupil-labs/document-libusb-fix Improve Linux libusb fix instructions and add to Ubuntu 18 docs | 13 July 2020, 08:56:57 UTC |
3d5d818 | Pablo Prietz | 13 July 2020, 08:15:06 UTC | Fix typos | 13 July 2020, 08:15:06 UTC |
8d35203 | Patrick Faion | 10 July 2020, 13:23:31 UTC | Add custom libusb info to Ubuntu 18+ docs | 10 July 2020, 13:23:31 UTC |
dfb7932 | Patrick Faion | 10 July 2020, 13:14:44 UTC | Improve docs on libsub fix for Ubuntu <=17 | 10 July 2020, 13:19:39 UTC |
7a79d42 | Pablo Prietz | 10 July 2020, 11:57:54 UTC | Merge pull request #1967 from pupil-labs/fix-ceres-cpp14-ubuntu17 Use ceres version 1.14 before port to C++14 | 10 July 2020, 11:57:54 UTC |
7a177a5 | Patrick Faion | 10 July 2020, 11:38:23 UTC | Use ceres version 1.14 before port to C++14 | 10 July 2020, 11:38:23 UTC |
61107ac | Patrick Faion | 09 July 2020, 13:16:14 UTC | Merge pull request #1966 from pupil-labs/patch_pyre_zhelper_cdll Patch pyre.zhelper.cdll | 09 July 2020, 13:16:14 UTC |
42f0a22 | Pablo Prietz | 09 July 2020, 13:05:15 UTC | Use os_utils.patch_pyre_zhelper_cdll() where necessary Specifically, after importing pyre, pyre.zhelper, or ndsi | 09 July 2020, 13:10:45 UTC |
89b1251 | Pablo Prietz | 09 July 2020, 12:46:19 UTC | Add `os_utils.patch_pyre_zhelper_cdll()` Fixes https://github.com/pupil-labs/pupil/issues/1919 When running the v2.0 bundle on macOS 10.14, `ctypes.CDLL("libSystem.dylib")` fails to load which is required by pyre.zhelper. `libSystem.dylib` is not part of the bundle on purpose, as `ctypes.CDLL` is usually able to fallback to the system- provided library at `/usr/lib/libSystem.dylib`. The fallback mechanism is provided by the $DYLD_FALLBACK_LIBRARY_PATH variable. PyInstaller makes use of it to inject the bundle path to prioritize bundled libraries over system libraries: https://github.com/pyinstaller/pyinstaller/blob/v3.6/PyInstaller/loader/pyiboot01_bootstrap.py#L203 Upon inspection, `/usr/lib` is correcly present in $DYLD_FALLBACK_LIBRARY_PATH when running the macOS bundle on macOS 10.14. This indicates an underlying deeper issue. Curiously, `ctypes.util.find_library("libSystem.dylib")` works as expected and returns `/usr/lib/libSystem.dylib` when running the above setup. This patch makes use of that fact by implementing an additional fallback that attempts to load the initially missing library based on its absolute path. As `pyre.zhelper` is the only place calling `ctypes.CDLL("libSystem.dylib")`, we will only patch this specific CDLL instance. This patch will only be applied if the problematic setup is detected. | 09 July 2020, 13:10:45 UTC |
df7000f | Patrick Faion | 07 July 2020, 15:29:26 UTC | Merge pull request #1965 from pupil-labs/avoid_non-monotonic_progress Post-hoc gaze mapping: Avoid non-monotonic progress updates | 07 July 2020, 15:29:26 UTC |
ef23854 | Pablo Prietz | 07 July 2020, 15:01:58 UTC | Post-hoc gaze mapping: Avoid non-monotonic progress updates | 07 July 2020, 15:01:58 UTC |
4116162 | Pablo Prietz | 07 July 2020, 13:33:15 UTC | Merge pull request #1964 from pupil-labs/develop Pupil v2.1 Release Candidate 1 | 07 July 2020, 13:33:15 UTC |
94db63b | Pablo Prietz | 07 July 2020, 13:31:11 UTC | Merge pull request #1963 from pupil-labs/gazer_dont_activate_on_fail Capture: Only set active gaze mapping plugin if calibration did not fail | 07 July 2020, 13:31:11 UTC |