https://github.com/torvalds/linux
Revision f7b58a69fad9d2c4c90cab0247811155dd0d48e7 authored by Mike Snitzer on 30 March 2023, 18:56:38 UTC, committed by Mike Snitzer on 30 March 2023, 19:54:32 UTC
"Abnormal" bios include discards, write zeroes and secure erase. By no
longer passing the calculated 'len' pointer, commit 7dd06a2548b2 ("dm:
allow dm_accept_partial_bio() for dm_io without duplicate bios") took a
senseless approach to disallowing dm_accept_partial_bio() from working
for duplicate bios processed using __send_duplicate_bios().

It inadvertently and incorrectly stopped the use of 'len' when
initializing a target's io (in alloc_tio). As such the resulting tio
could address more area of a device than it should.

For example, when discarding an entire DM striped device with the
following DM table:
 vg-lvol0: 0 159744 striped 2 128 7:0 2048 7:1 2048
 vg-lvol0: 159744 45056 striped 2 128 7:2 2048 7:3 2048

Before this fix:

 device-mapper: striped: target_stripe=0, bdev=7:0, start=2048 len=102400
 blkdiscard: attempt to access beyond end of device
 loop0: rw=2051, sector=2048, nr_sectors = 102400 limit=81920

 device-mapper: striped: target_stripe=1, bdev=7:1, start=2048 len=102400
 blkdiscard: attempt to access beyond end of device
 loop1: rw=2051, sector=2048, nr_sectors = 102400 limit=81920

After this fix;

 device-mapper: striped: target_stripe=0, bdev=7:0, start=2048 len=79872
 device-mapper: striped: target_stripe=1, bdev=7:1, start=2048 len=79872

Fixes: 7dd06a2548b2 ("dm: allow dm_accept_partial_bio() for dm_io without duplicate bios")
Cc: stable@vger.kernel.org
Reported-by: Orange Kao <orange@aiven.io>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
1 parent 197b6b6
History
Tip revision: f7b58a69fad9d2c4c90cab0247811155dd0d48e7 authored by Mike Snitzer on 30 March 2023, 18:56:38 UTC
dm: fix improper splitting for abnormal bios
Tip revision: f7b58a6
File Mode Size
.gitignore -rw-r--r-- 120 bytes
Kconfig -rw-r--r-- 5.4 KB
Makefile -rw-r--r-- 3.2 KB
blacklist.c -rw-r--r-- 9.5 KB
blacklist.h -rw-r--r-- 135 bytes
blacklist_hashes.c -rw-r--r-- 147 bytes
check-blacklist-hashes.awk -rwxr-xr-x 1.0 KB
default_x509.genkey -rw-r--r-- 407 bytes
extract-cert.c -rw-r--r-- 3.7 KB
revocation_certificates.S -rw-r--r-- 495 bytes
system_certificates.S -rw-r--r-- 1017 bytes
system_keyring.c -rw-r--r-- 9.9 KB

back to top