Revision f8ace5477ef9731ef605f58d313c4cd1548f12d2 authored by Tom Lane on 22 June 2016, 20:52:41 UTC, committed by Tom Lane on 22 June 2016, 20:52:41 UTC
The original specification for this called for the deserialization function to have signature "deserialize(serialtype) returns transtype", which is a security violation if transtype is INTERNAL (which it always would be in practice) and serialtype is not (which ditto). The patch blithely overrode the opr_sanity check for that, which was sloppy-enough work in itself, but the indisputable reason this cannot be allowed to stand is that CREATE FUNCTION will reject such a signature and thus it'd be impossible for extensions to create parallelizable aggregates. The minimum fix to make the signature type-safe is to add a second, dummy argument of type INTERNAL. But to lock it down a bit more and make misuse of INTERNAL-accepting functions less likely, let's get rid of the ability to specify a "serialtype" for an aggregate and just say that the only useful serialtype is BYTEA --- which, in practice, is the only interesting value anyway, due to the usefulness of the send/recv infrastructure for this purpose. That means we only have to allow "serialize(internal) returns bytea" and "deserialize(bytea, internal) returns internal" as the signatures for these support functions. In passing fix bogus signature of int4_avg_combine, which I found thanks to adding an opr_sanity check on combinefunc signatures. catversion bump due to removing pg_aggregate.aggserialtype and adjusting signatures of assorted built-in functions. David Rowley and Tom Lane Discussion: <27247.1466185504@sss.pgh.pa.us>
1 parent e45e990
File | Mode | Size |
---|---|---|
config | ||
contrib | ||
doc | ||
src | ||
.dir-locals.el | -rw-r--r-- | 738 bytes |
.gitattributes | -rw-r--r-- | 1.7 KB |
.gitignore | -rw-r--r-- | 434 bytes |
COPYRIGHT | -rw-r--r-- | 1.2 KB |
GNUmakefile.in | -rw-r--r-- | 3.6 KB |
HISTORY | -rw-r--r-- | 283 bytes |
Makefile | -rw-r--r-- | 1.5 KB |
README | -rw-r--r-- | 1.2 KB |
README.git | -rw-r--r-- | 727 bytes |
aclocal.m4 | -rw-r--r-- | 384 bytes |
configure | -rwxr-xr-x | 459.3 KB |
configure.in | -rw-r--r-- | 72.9 KB |
Computing file changes ...