Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
Revision f922a6371c6b658aa955e5096774509b12dd7579 authored by Jeff Bezanson on 07 September 2018, 03:32:38 UTC, committed by Keno Fischer on 08 September 2018, 19:47:23 UTC 
fix #29036, poor inference of `val,i = iterate(x,i)`
 
In this case, the result of `iterate` has not been checked for
`nothing`, so we try to call `indexed_iterate` (for destructuring
assignment) on a Union of Nothing and the tuple returned by
`iterate`. That has two method matches, and so was excluded from
constant propagation. This commit fixes that by generalizing the
constant prop heuristic from requiring one method match to
requiring one non-Bottom method match.

This issue caused a large slowdown in DelimitedFiles, where
the inner loop consists of

```
        while idx <= slen
            val,idx = iterate(dbuff, idx)
```
1 parent 65e4c13
History
Tip revision: f922a6371c6b658aa955e5096774509b12dd7579 authored by Jeff Bezanson on 07 September 2018, 03:32:38 UTC
fix #29036, poor inference of `val,i = iterate(x,i)`
Tip revision: f922a63
File Mode Size
images
man
src
.gitignore -rw-r--r-- 55 bytes
Makefile -rw-r--r-- 1.6 KB
Manifest.toml -rw-r--r-- 2.7 KB
NEWS-update.jl -rw-r--r-- 456 bytes
Project.toml -rw-r--r-- 59 bytes
README.md -rw-r--r-- 905 bytes
make.jl -rw-r--r-- 7.2 KB

README.md

back to top