Revision f93e5180be1e20a59ff68f12853653f4f3282846 authored by Kristiyan Kostadinov on 26 April 2024, 08:13:10 UTC, committed by Andrew Kushnir on 26 April 2024, 16:32:31 UTC
Fixes several issues with the `HttpClient` migration that showed up after I tried updating the Material docs site to the latest v18 release. Includes: * The migration was assuming that all Angular decorators have at least one argument. This led to a null pointer error that broke the v18 update process when I was testing it. * The migration incorrectly reimplemented the detection of classes with Angular decorators. This can cause code to be migrated incorrectly and doesn't handle cases like import aliases. I've switched it to use the existing tooling for detecting decorated classes. * The migration was trying to migrate directives, even though they don't support the `imports` field. * The migration was detecting `TestBed.configureTestingModule` calls using a raw string match which is very fragile and can be broken by the user's formatting. * There were syntax errors in the unit tests. * There were type checking errors in the unit tests, for example none of them were importing the Angular decorators that they were migrating. There's more room for improvement, but this should resolve the most glaring issues without having to rewrite too much. PR Close #55557
1 parent 21532f8
File | Mode | Size |
---|---|---|
.circleci | ||
.devcontainer | ||
.github | ||
.husky | ||
.ng-dev | ||
.vscode | ||
.yarn | ||
adev | ||
aio | ||
devtools | ||
docs | ||
goldens | ||
integration | ||
modules | ||
packages | ||
scripts | ||
third_party | ||
tools | ||
.bazelignore | -rw-r--r-- | 1.6 KB |
.bazelrc | -rw-r--r-- | 7.2 KB |
.bazelversion | -rw-r--r-- | 6 bytes |
.clang-format | -rw-r--r-- | 73 bytes |
.editorconfig | -rw-r--r-- | 245 bytes |
.gitattributes | -rw-r--r-- | 146 bytes |
.gitignore | -rw-r--r-- | 1004 bytes |
.gitmessage | -rw-r--r-- | 7.2 KB |
.mailmap | -rw-r--r-- | 51 bytes |
.npmrc | -rw-r--r-- | 21 bytes |
.nvmrc | -rw-r--r-- | 8 bytes |
.prettierrc | -rw-r--r-- | 196 bytes |
.pullapprove.yml | -rw-r--r-- | 53.5 KB |
.yarnrc | -rw-r--r-- | 130 bytes |
BUILD.bazel | -rw-r--r-- | 2.5 KB |
CHANGELOG.md | -rw-r--r-- | 317.4 KB |
CHANGELOG_ARCHIVE.md | -rw-r--r-- | 997.0 KB |
CODE_OF_CONDUCT.md | -rw-r--r-- | 3.6 KB |
CONTRIBUTING.md | -rw-r--r-- | 15.5 KB |
LICENSE | -rw-r--r-- | 1.1 KB |
README.md | -rw-r--r-- | 5.5 KB |
SECURITY.md | -rw-r--r-- | 403 bytes |
WORKSPACE | -rw-r--r-- | 8.5 KB |
browser-providers.conf.d.ts | -rw-r--r-- | 387 bytes |
browser-providers.conf.js | -rw-r--r-- | 1.9 KB |
gulpfile.js | -rw-r--r-- | 572 bytes |
karma-js.conf.js | -rw-r--r-- | 6.0 KB |
package.json | -rw-r--r-- | 9.9 KB |
packages.bzl | -rw-r--r-- | 3.1 KB |
renovate.json | -rw-r--r-- | 3.1 KB |
tsconfig-tslint.json | -rw-r--r-- | 200 bytes |
tslint.json | -rw-r--r-- | 5.3 KB |
yarn.bzl | -rw-r--r-- | 77 bytes |
yarn.lock | -rw-r--r-- | 779.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...