Revision f9d18e22d24f154b64d58f78c77fcef2ce590a37 authored by Andrew Kryczka on 18 January 2017, 19:47:07 UTC, committed by Facebook Github Bot on 18 January 2017, 19:54:22 UTC
Summary: Cockroachdb exposed this bug in #1778. The bug happens when a compaction's output files are ended due to exceeding max_compaction_bytes. In that case we weren't taking into account the next file's start key when deciding how far to extend the current file's max_key. This caused the non-overlapping key-range invariant to be violated. Note this was correctly handled for the usual case of cutting compaction output, which is file size exceeding max_output_file_size. I am not sure why these are two separate code paths, but we can consider refactoring it to prevent such errors in the future. Closes https://github.com/facebook/rocksdb/pull/1784 Differential Revision: D4430235 Pulled By: ajkr fbshipit-source-id: 80af748
1 parent 3ce091f
| File | Mode | Size |
|---|---|---|
| arcanist_util | ||
| build_tools | ||
| cmake | ||
| coverage | ||
| db | ||
| docs | ||
| examples | ||
| hdfs | ||
| include | ||
| java | ||
| memtable | ||
| port | ||
| table | ||
| third-party | ||
| tools | ||
| util | ||
| utilities | ||
| .arcconfig | -rw-r--r-- | 566 bytes |
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 700 bytes |
| .travis.yml | -rw-r--r-- | 1.5 KB |
| AUTHORS | -rw-r--r-- | 247 bytes |
| CMakeLists.txt | -rw-r--r-- | 23.7 KB |
| CONTRIBUTING.md | -rw-r--r-- | 733 bytes |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.1 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 39.2 KB |
| INSTALL.md | -rw-r--r-- | 3.9 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 646 bytes |
| LICENSE | -rw-r--r-- | 1.6 KB |
| Makefile | -rw-r--r-- | 50.3 KB |
| PATENTS | -rw-r--r-- | 1.9 KB |
| README.md | -rw-r--r-- | 1.4 KB |
| ROCKSDB_LITE.md | -rw-r--r-- | 1.0 KB |
| USERS.md | -rw-r--r-- | 4.6 KB |
| Vagrantfile | -rw-r--r-- | 877 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| appveyor.yml | -rw-r--r-- | 555 bytes |
| src.mk | -rw-r--r-- | 24.1 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
