Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
Revision f9d1b85495089cae246c572bc8956d80d0fc2489 authored by Keno Fischer on 19 January 2023, 13:33:25 UTC, committed by GitHub on 19 January 2023, 13:33:25 UTC 
irinterp: Remove redundant `is_inlineable_constant` check (#48345)
 
The way that `is_inlineable_constant` is supposed to work is that during
type inference, we allow a large `Const` type to persist in the inference
domain and then at inlining time, we decide whether or not to remove the
call and replace it by the constant (thus having to serialize the constant)
or just leave the call as is (with the types eventually being widened).
`irinterp` was being a bit overeager here, not even permitting large
constants into the inference domain, which was hurting precision.
We alraedy have an appropriate `is_inlineable_constant` call guarding
the inlining of constants into the IR, so the move the one that checks
it when returning from concrete eval.
1 parent 1bff32b
History
Tip revision: f9d1b85495089cae246c572bc8956d80d0fc2489 authored by Keno Fischer on 19 January 2023, 13:33:25 UTC
irinterp: Remove redundant `is_inlineable_constant` check (#48345)
Tip revision: f9d1b85
File Mode Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version -rw-r--r-- 5 bytes
.clang-format -rw-r--r-- 3.3 KB
.codecov.yml -rw-r--r-- 52 bytes
.git-blame-ignore-revs -rw-r--r-- 294 bytes
.gitattributes -rw-r--r-- 65 bytes
.gitignore -rw-r--r-- 507 bytes
.mailmap -rw-r--r-- 12.1 KB
CITATION.bib -rw-r--r-- 513 bytes
CITATION.cff -rw-r--r-- 940 bytes
CONTRIBUTING.md -rw-r--r-- 23.1 KB
HISTORY.md -rw-r--r-- 363.4 KB
LICENSE.md -rw-r--r-- 1.3 KB
Make.inc -rw-r--r-- 51.6 KB
Makefile -rw-r--r-- 30.0 KB
NEWS.md -rw-r--r-- 1.5 KB
README.md -rw-r--r-- 7.3 KB
THIRDPARTY.md -rw-r--r-- 3.7 KB
VERSION -rw-r--r-- 11 bytes
julia.spdx.json -rw-r--r-- 35.8 KB
sysimage.mk -rw-r--r-- 4.1 KB

README.md

back to top