faf4c1d | Manish Goregaokar | 19 April 2018, 10:01:31 UTC | Add reftest bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451724 gecko-commit: a993e6e8d14c75545a59b18ba32c821801d6f124 gecko-integration-branch: central gecko-reviewers: emilio | 19 April 2018, 10:20:29 UTC |
f78410b | Luke Bjerring | 18 April 2018, 22:18:14 UTC | Cleanup several idlharness tests Change-Id: I388e2a9605096886291fafdae428b78bfe21dea9 Reviewed-on: https://chromium-review.googlesource.com/992880 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Luke Bj <lukebjerring@chromium.org> Cr-Commit-Position: refs/heads/master@{#551840} | 18 April 2018, 22:32:51 UTC |
0a537e6 | youennf | 18 April 2018, 21:09:58 UTC | Merge pull request #10527 from youennf/wpt-export-for-webkit-184746 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=184746 | 18 April 2018, 21:09:58 UTC |
a4c4257 | Anne van Kesteren | 18 April 2018, 18:58:15 UTC | DOM: test composed/composedPath via IDL (#9968) | 18 April 2018, 18:58:15 UTC |
a42f9ee | Youenn Fablet | 18 April 2018, 18:50:32 UTC | WebKit export of https://bugs.webkit.org/show_bug.cgi?id=184746 | 18 April 2018, 18:50:32 UTC |
4a7f047 | Ms2ger | 18 April 2018, 17:53:25 UTC | Avoid FutureWarnings in test_sourcefile.py. (#10518) These lines of code triggered the following warning: > FutureWarning: The behavior of this method will change in future versions. > Use specific 'len(elem)' or 'elem is not None' test instead. | 18 April 2018, 17:53:25 UTC |
e2c839d | Anne van Kesteren | 18 April 2018, 11:59:14 UTC | Fetch: MediaSource blob: URLs For https://github.com/whatwg/fetch/pull/708. | 18 April 2018, 11:59:14 UTC |
f70fcac | Cameron McCormack | 18 April 2018, 10:51:47 UTC | Add WPT test for white space between adjacent elements in the same anonymous table cell. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452870 gecko-commit: b06fe2f80ddfc8baa9af24ac5ad5a9e4b98940a8 gecko-integration-branch: central gecko-reviewers: dholbert | 18 April 2018, 11:03:48 UTC |
53d666c | Andrea Marchesini | 18 April 2018, 10:27:07 UTC | WorkerRef should make APIs able to work until the worker is completely terminated - part 2 - BroadcastChannel bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1450644 gecko-commit: f2341e59a4b58d36766806dab967a24526a35368 gecko-integration-branch: mozilla-inbound gecko-reviewers: asuth | 18 April 2018, 10:54:25 UTC |
b4e3ffb | Ms2ger | 18 April 2018, 09:55:48 UTC | URL.createObjectURL should not work with MediaStream (#10515) Change the one existing test to no longer rely on it (and clearly mark it as manual) and add an entry to historical.html for it. | 18 April 2018, 09:55:48 UTC |
13f0fff | Anne van Kesteren | 18 April 2018, 09:48:50 UTC | nit | 18 April 2018, 09:48:50 UTC |
816c2ec | Anne van Kesteren | 18 April 2018, 09:36:43 UTC | URL.createObjectURL should not work with MediaStream Change the one existing test to no longer rely on it (and clearly mark it as manual) and add an entry to historical.html for it. | 18 April 2018, 09:36:43 UTC |
412b403 | Anne van Kesteren | 12 April 2018, 09:58:43 UTC | Test vertical tab for base64 Apparently Rust's base64 crate strips this, so it would be good to test. Safari is also an outlier here. | 18 April 2018, 08:07:22 UTC |
6030898 | jgraham | 18 April 2018, 00:02:33 UTC | Install Ahem for Safari on Sauce (#10491) This just gets the latest master version of the font; we could change things to get the version for the current revision, but it isn't necessarily worth the extra complexity given how rarely this changes. | 18 April 2018, 00:02:33 UTC |
f76bdbf | jugglinmike | 18 April 2018, 00:02:14 UTC | [wptrunner] Install Ahem in Sauce Labs Windows VM (#10499) | 18 April 2018, 00:02:14 UTC |
4a0df34 | Morten Stenshorne | 17 April 2018, 20:09:59 UTC | Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html The test was incorrect, which is why it failed in legacy layout. It passed in LayoutNG because of a bug there. Add an (invisible) top border on the outer DIV to prevent clearance on the child. Otherwise the outer DIV and the child with 'clear' would have adjacent margins, which in turn would enable the child with 'clear' to pull the float along with itself, which in turn would guarantee clearance, which is precisely what this test wanted to avoid. Still passes in LayoutNG. Change-Id: I6b36d8196b93720453d6e398509705d2cf32f8e4 Reviewed-on: https://chromium-review.googlesource.com/1014975 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551443} | 17 April 2018, 20:22:44 UTC |
32b05c8 | Simon Stewart | 17 April 2018, 18:15:40 UTC | Merge pull request #10401 from jimevans/script-user-prompts Updating WebDriver execute[Async]Script tests for unhandled user prompts | 17 April 2018, 18:15:40 UTC |
558c8b5 | Simon Pieters | 17 April 2018, 15:45:03 UTC | [css-contain] add OWNERS | 17 April 2018, 16:23:56 UTC |
b1ddc9a | Simon Pieters | 17 April 2018, 15:36:20 UTC | Fix README.md command: python wpt run | 17 April 2018, 15:52:23 UTC |
4358fc0 | Emilio Cobos Álvarez | 16 April 2018, 11:47:06 UTC | css-display] Move unboxing to style, and handle display: contents before other suppressions. This also adopts the resolution of [1] while at it, and switches XUL to not support display: contents until a use case appears. This makes our behavior consistent both with the spec and also in terms of handling dynamic changes to stuff that would otherwise get suppressed. Also makes us consistent with both Blink and WebKit in terms of computed style. We were the only ones respecting "behaves as display: none" without actually computing to display: none. Will file a spec issue to get that changed. It also makes us match Blink and WebKit in terms of respecting display: contents before other suppressions, see the reftest which I didn't write as a WPT (because there's no spec supporting neither that or the opposite of what we do), where a <g> element respects display: contents even though if it had any other kind of display value we'd suppress the frame for it and all the descendants since it's an SVG element in a non-SVG subtree. Also, this removes the page-break bit from the display: contents loop, which I think is harmless. As long as the tests under style are based in namespace id / node name / traversal parent, this should not make style sharing go wrong in any way, since that's the first style sharing check we do at [2]. The general idea under this change is making all nodes with computed style of display: contents actually honor it. Otherwise there's no way of making the setup sound except re-introducing something similar to all the state tracking removed in bug 1303605. [1]: https://github.com/w3c/csswg-drafts/issues/2167 [2]: https://searchfox.org/mozilla-central/rev/fca4426325624fecbd493c31389721513fc49fef/servo/components/style/sharing/mod.rs#700 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453702 gecko-commit: 43862b2ee72eec858f509ce3b9cb5c6fa96194ba gecko-integration-branch: mozilla-inbound gecko-reviewers: mats, xidorn | 17 April 2018, 15:13:30 UTC |
4bf2fa8 | James Graham | 22 August 2017, 14:43:51 UTC | Don't wrap HTTPExceptions in FunctionHandler.__call__(). Extracted from https://github.com/w3c/web-platform-tests/pull/6792. | 17 April 2018, 13:27:35 UTC |
8824132 | Ahilya Sinha | 17 April 2018, 09:37:50 UTC | Fixed config.json not being used in TestEnvironment (#10494) Added a check in the TestEnvironment load_config so it overrides the default config when present. Closes https://github.com/w3c/web-platform-tests/issues/8181 | 17 April 2018, 09:37:50 UTC |
16e3f3e | Brendan McLoughlin | 17 April 2018, 09:31:37 UTC | Do not print logs twice when running wpt lint (#10148) | 17 April 2018, 09:31:37 UTC |
ae41496 | Anne van Kesteren | 17 April 2018, 08:50:02 UTC | Add more XMLHttpRequest overrideMimeType() tests For https://github.com/whatwg/xhr/issues/157, https://github.com/whatwg/xhr/pull/174, and https://github.com/whatwg/mimesniff/issues/42. | 17 April 2018, 08:50:02 UTC |
e0d1004 | Geoffrey Sneddon | 17 April 2018, 07:23:46 UTC | Add backwards compatibility for external_host and host_ip (#10409) | 17 April 2018, 07:23:46 UTC |
e08f214 | Jinho Bang | 17 April 2018, 04:55:09 UTC | PaymentHandler: Not allow to call operation if event is not trusted Related spec change: https://github.com/w3c/payment-handler/pull/294 Bug: 833530 Change-Id: I65d0e01bb5b6bfdd44925b90ba98837161cc136b Reviewed-on: https://chromium-review.googlesource.com/1013664 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#551238} | 17 April 2018, 05:05:29 UTC |
727a813 | Anne van Kesteren | 17 April 2018, 05:01:58 UTC | Meta: certificate advice for macOS (Chrome/Safari) (#10486) | 17 April 2018, 05:01:58 UTC |
7eed33a | Hongchan Choi | 17 April 2018, 03:09:48 UTC | Apply automatic pull for AudioWorkletNode with zero output Spec: https://webaudio.github.io/web-audio-api/#rendering-loop (Step 9.5) The AudioWorkletNode with zero output must be pulled by the renderer. The actual output will be ignored just like AnalyserNode. Bug: 831245 Test: LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html Change-Id: If9bd27d6c4bfeecdcd2dd4c8445459afd8593e85 Reviewed-on: https://chromium-review.googlesource.com/1014388 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551210} | 17 April 2018, 03:21:38 UTC |
e48e26a | Philip Jägenstedt | 17 April 2018, 01:03:04 UTC | Remove old drawCustomFocusRing test (#10487) Added in https://github.com/w3c/web-platform-tests/pull/406. Removed from HTML in https://github.com/whatwg/html/commit/ff07c6d630fb986f6c4f64b2fb87387b4f89647d and historical test added in https://github.com/w3c/web-platform-tests/pull/3801. Fixes https://github.com/w3c/web-platform-tests/issues/547. | 17 April 2018, 01:03:04 UTC |
0324a6e | James Graham | 16 April 2018, 17:58:17 UTC | Add long timeout to cache-abort tests, a=testonly These were previously timing out regularly on OSX debug builds. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1454362 gecko-commit: e2f68d3b03c2fe2c8f489ba179e7dc871acda245 gecko-integration-branch: mozilla-inbound gecko-reviewers: testonly | 16 April 2018, 23:59:07 UTC |
25b6727 | pyup.io bot | 16 April 2018, 23:20:44 UTC | Update mozprofile from 0.29 to 1.0.0 (#10453) | 16 April 2018, 23:20:44 UTC |
c5a68bd | Domenic Denicola | 16 April 2018, 03:50:36 UTC | null is not the correct origin for createDocument() See https://dom.spec.whatwg.org/#dom-domimplementation-createdocument | 16 April 2018, 14:29:56 UTC |
88a9970 | James Graham | 15 April 2018, 09:22:37 UTC | Fix prefs getter call in wptrunner Firefox executor bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452952 gecko-commit: 55b99481fab156381335b6887fca26b6a8f0c0b3 gecko-integration-branch: mozilla-inbound gecko-reviewers: ato | 16 April 2018, 11:44:42 UTC |
84e7972 | Anne van Kesteren | 16 April 2018, 09:52:07 UTC | Adjust XMLHttpRequest Content-Type handling See https://github.com/whatwg/xhr/pull/176 and https://github.com/whatwg/mimesniff/pull/36. | 16 April 2018, 09:52:07 UTC |
b4cdc8f | Marcos Cáceres | 16 April 2018, 07:19:19 UTC | fix: ApplePay PMI is wrong (#10485) | 16 April 2018, 07:19:19 UTC |
fa62ac0 | Anne van Kesteren | 16 April 2018, 06:36:02 UTC | Fetch: align about:blank handling with the standard See https://github.com/whatwg/fetch/commit/72fc2e787be663f5bc39c88665dd3c356abbca0f. Closes https://github.com/whatwg/xhr/issues/194. | 16 April 2018, 06:36:02 UTC |
691673d | Anne van Kesteren | 16 April 2018, 04:56:38 UTC | Ensure cloneNode() does not preserve the prototype Closes https://github.com/whatwg/dom/issues/565. | 16 April 2018, 04:56:38 UTC |
6736e3f | jgraham | 15 April 2018, 20:55:04 UTC | Improve handling of harness-level errors in wptrunner (#10444) Split the internal handling of errors during a test into two cases; INTERNAL-ERROR that is produced if there's an exception in the harness and ERROR that is for exceptions reported by the test. Both are still reported as ERROR to the user, but in the INTERNAL-ERROR case the runner is always restarted, just like EXTERNAL-TIMEOUT, since we assume that the internal state is compromised somehow. | 15 April 2018, 20:55:04 UTC |
ff4cf69 | Eric Willigers | 15 April 2018, 11:01:13 UTC | CSS: Remove support for position values with 3 parts Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/BLsXXiukAgAJ BUG=804187 Change-Id: I94e79b2b426250c521d0ebae1492571fde078f31 Reviewed-on: https://chromium-review.googlesource.com/1013459 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#550915} | 15 April 2018, 11:30:16 UTC |
b3c7910 | Kerem Kat | 15 April 2018, 09:31:12 UTC | Add web-platform tests for StyleRule selectorText property setter. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=37468 gecko-commit: 7343e39bf9854651c4f8c2525767b825666d38fd gecko-integration-branch: central gecko-reviewers: xidorn | 15 April 2018, 09:54:19 UTC |
ca418bd | Robert Longson | 14 April 2018, 16:20:39 UTC | support ping, rel, referrerPolicy, relList, hreflang, type and text on SVG a elements bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451823 gecko-commit: a1d4a3e6c77a29e7e63d5e88f5b4859b113df943 gecko-integration-branch: mozilla-inbound gecko-reviewers: mystor | 15 April 2018, 09:23:10 UTC |
fd2badf | Fuqiao Xue | 14 April 2018, 19:47:57 UTC | [css-values] Typo fixes (#10383) | 14 April 2018, 19:47:57 UTC |
da5837a | Stephen McGruer | 14 April 2018, 15:31:17 UTC | Reland "Web Animations: Fix bugs in procedure to process a keyframes argument" This is a reland of 0ade0386aa4168b48234bc7f33d30a62140b95ea Original change's description: > Web Animations: Fix bugs in procedure to process a keyframes argument > > There were three minor bugs left in the implementation: > > - We threw on lists-in-custom-iterators instead of just ignoring them. > - We returned all properties on the keyframe rather than just those > defined on the keyframe itself (e.g. we would include prototype > properties, against spec). > - We didn't access the properties in ascending unicode order. > > Bug: 827573 > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > Reviewed-on: https://chromium-review.googlesource.com/989261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550641} Bug: 827573 Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b Reviewed-on: https://chromium-review.googlesource.com/1012897 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550895} | 14 April 2018, 15:47:16 UTC |
6f621ca | L. David Baron | 14 April 2018, 15:33:30 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/37b8862d354e0014a72715462dd2102dd5b599cc . (#10470) | 14 April 2018, 15:33:30 UTC |
0e0344a | Emilio Cobos Álvarez | 14 April 2018, 11:37:26 UTC | Merge pull request #10422 from emilio/cssom-woes [cssom] Add tests for some recent CSSWG resolutions. | 14 April 2018, 11:37:26 UTC |
c53d084 | Alex Moshchuk | 13 April 2018, 23:12:06 UTC | Reland 2: Use PostTask to schedule cross-process postMessage forwarding. Changes from first reland attempt at https://crrev.com/c/1011287: - fix an additional source of flakiness in ChromeOS login tests Changes from original attempt at https://crrev.com/c/999182: - fix flakiness in two additional ChromeOS login tests - fix CSP WPT tests to not depend on ordering between iframe's onload and postMessage - see https://crbug.com/832319. Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Tbr: dcheng@chromium.org Change-Id: If2cc6591db31471adff0d84ec0b689905e21cdf1 Reviewed-on: https://chromium-review.googlesource.com/999182 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#550284} Reviewed-on: https://chromium-review.googlesource.com/1011287 Cr-Original-Commit-Position: refs/heads/master@{#550621} Reviewed-on: https://chromium-review.googlesource.com/1012472 Cr-Commit-Position: refs/heads/master@{#550769} | 13 April 2018, 23:31:26 UTC |
ae86013 | Emilio Cobos Álvarez | 13 April 2018, 22:03:05 UTC | Remove Element.createShadowRoot. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453789 gecko-commit: b2dd9ca61e0b92b6a0da66d86de4ab4f87cd8e19 gecko-integration-branch: central gecko-reviewers: smaug | 13 April 2018, 22:24:03 UTC |
433d39e | Emilio Cobos Álvarez | 11 April 2018, 12:29:23 UTC | [cssom] Remove comment that now is invalid per CSSWG resolution. getComputedStyle returns styles in the node's document per the resolution in https://github.com/w3c/csswg-drafts/issues/1548. | 13 April 2018, 20:20:18 UTC |
dc670d8 | Emilio Cobos Álvarez | 11 April 2018, 12:27:56 UTC | [cssom] Test detached elements, elements outside the flattened tree, and hidden frames. This tests resolutions from https://github.com/w3c/csswg-drafts/issues/1548. | 13 April 2018, 20:20:18 UTC |
de23472 | Emilio Cobos Álvarez | 11 April 2018, 12:15:02 UTC | [cssom] Test that getComputedStyle with an unknown/invalid pseudo-element throws. This tests the resolution in https://github.com/w3c/csswg-drafts/issues/2149. | 13 April 2018, 20:20:17 UTC |
cb845c5 | Avi Drissman | 13 April 2018, 19:50:51 UTC | Revert "Web Animations: Fix bugs in procedure to process a keyframes argument" This reverts commit 0ade0386aa4168b48234bc7f33d30a62140b95ea. Reason for revert: Unexpected Failures: * bindings/sequence-type.html * custom-elements/spec/define-element.html * external/wpt/custom-elements/CustomElementRegistry.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/ https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/ Speculatively reverting this to see if it's the cause. Original change's description: > Web Animations: Fix bugs in procedure to process a keyframes argument > > There were three minor bugs left in the implementation: > > - We threw on lists-in-custom-iterators instead of just ignoring them. > - We returned all properties on the keyframe rather than just those > defined on the keyframe itself (e.g. we would include prototype > properties, against spec). > - We didn't access the properties in ascending unicode order. > > Bug: 827573 > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > Reviewed-on: https://chromium-review.googlesource.com/989261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550641} TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827573 Reviewed-on: https://chromium-review.googlesource.com/1012857 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550721} | 13 April 2018, 20:09:27 UTC |
e6cffaa | theodab | 13 April 2018, 19:17:17 UTC | Test that requestMediaKeySystemAccess sets label (#8508) On Edge, navigator.requestMediaKeySystemAccess ignores the value passed along to the label configuration field. This test exposes that bug. See https://goo.gl/6SgCRb | 13 April 2018, 19:17:17 UTC |
81bcc8d | Mustaq Ahmed | 13 April 2018, 18:16:18 UTC | Make PointerEvent fromElement/toElement return null. Also added web-platform-tests. Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/G2s1Ol3qcgA Closes https://github.com/w3c/pointerevents/issues/167 Bug: 827271 Change-Id: I8429b9541f8cfc38223b3a34116b74c2aba92ee5 Reviewed-on: https://chromium-review.googlesource.com/986877 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550683} | 13 April 2018, 18:25:25 UTC |
6ad1b51 | Ben Pastene | 13 April 2018, 17:03:33 UTC | Revert "Reland: Use PostTask to schedule cross-process postMessage forwarding." This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9. Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886 https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887 Original change's description: > Reland: Use PostTask to schedule cross-process postMessage forwarding. > > Changes from original attempt at https://crrev.com/c/999182: > - fix flakiness in two additional ChromeOS login tests > - fix CSP WPT tests to not depend on ordering between iframe's onload > and postMessage - see https://crbug.com/832319. > > Previously, we sent the IPC to forward a cross-process postMessage > immediately. This caused a behavioral difference from the > same-process case where the postMessage is always scheduled. Namely, > in a scenario like this: > > frame.postMessage(...); > doSomethingThatSendsIPCsToFrame(frame); > > the IPCs from JS following the postMessage would've been ordered > incorrectly, causing |frame| to see their side effects after the > postMessage dispatch in the cross-process case, whereas they would be > seen before the postMessage dispatch in the same-process case. One > example of this is frame.focus(), and another is a frame element > onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after > a postMessage dispatched from an inline script while the frame was > still loading. > > To resolve these ordering concerns, this CL changes cross-process > postMessage to do a PostTask on the sender side before sending the > message to the browser process. This improves the current state of > the world, but does not yet achieve a perfect match for the IPC > ordering in the same-process case - see discussion on the bug. > > Bug: 828529 > Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 > Reviewed-on: https://chromium-review.googlesource.com/999182 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#550284} > Reviewed-on: https://chromium-review.googlesource.com/1011287 > Cr-Commit-Position: refs/heads/master@{#550621} TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828529 Reviewed-on: https://chromium-review.googlesource.com/1012138 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#550649} | 13 April 2018, 17:30:38 UTC |
7b20d12 | Eric Willigers | 13 April 2018, 17:26:34 UTC | Merge pull request #10263 from csnardi/patch-10 Update serialization of timing functions | 13 April 2018, 17:26:34 UTC |
2707869 | Stephen McGruer | 13 April 2018, 16:52:45 UTC | Web Animations: Fix bugs in procedure to process a keyframes argument There were three minor bugs left in the implementation: - We threw on lists-in-custom-iterators instead of just ignoring them. - We returned all properties on the keyframe rather than just those defined on the keyframe itself (e.g. we would include prototype properties, against spec). - We didn't access the properties in ascending unicode order. Bug: 827573 Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 Reviewed-on: https://chromium-review.googlesource.com/989261 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550641} | 13 April 2018, 17:03:30 UTC |
1e5a5fe | Eric Willigers | 13 April 2018, 16:48:17 UTC | Merge pull request #10462 from ewilligers/background-serialization-variety Accept variation in serialization of 'background' | 13 April 2018, 16:48:17 UTC |
f281334 | Alex Moshchuk | 13 April 2018, 15:22:14 UTC | Reland: Use PostTask to schedule cross-process postMessage forwarding. Changes from original attempt at https://crrev.com/c/999182: - fix flakiness in two additional ChromeOS login tests - fix CSP WPT tests to not depend on ordering between iframe's onload and postMessage - see https://crbug.com/832319. Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 Reviewed-on: https://chromium-review.googlesource.com/999182 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550284} Reviewed-on: https://chromium-review.googlesource.com/1011287 Cr-Commit-Position: refs/heads/master@{#550621} | 13 April 2018, 15:40:47 UTC |
f6787be | Eric Willigers | 13 April 2018, 15:13:19 UTC | Accept variation in serialization of 'background' Serialization of the CSS property 'background' varies across browsers. There is an open spec issue: https://github.com/w3c/csswg-drafts/issues/418 Until the issue is resolved, we accept a variety of serializations. | 13 April 2018, 15:22:50 UTC |
f90d3d6 | Andreas Tolfsen | 13 April 2018, 13:33:50 UTC | Test serialisation of collections in wdspec. Ports tests added to Marionette in bug 1284232 to WPT. These test that the Arguments, Array, FileList, HTMLAllCollection, HTMLCollection, HTMLFormControlsCollection, HTMLOptionsCollection, and NodeList collections are properly serialised when returned from an injected script. There is one failing test that needs more investigation. My current suspicion is that it is a JavaScript bug. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453009 gecko-commit: 172094bca9a6e2f841e629aae292647e212d92c6 gecko-integration-branch: central gecko-reviewers: whimboo | 13 April 2018, 13:46:58 UTC |
4c8580c | Ian Clelland | 13 April 2018, 01:59:02 UTC | Allow feature policy to be used in opaque origins. Currently, policy-controlled features do not work as expected in frames with opaque origins, such as isolated sandboxes and data: URLs, because the eventual opaque origin of the frame is not known when the HTMLFrameOwnerElement builds the container policy, and so has no way to tell the browser that a particular origin should be allowed. This CL adds a new member to the ParsedFeaturePolicyDeclaration, which indicates that the iframe policy is expected to apply to the origin of the frame, and is used when that frame has an opaque origin. This can be triggered with an iframe of the form <iframe sandbox allow="feature"> or <iframe sandbox allow="feature src"> This flag is checked when building the feature policy in the new frame, and ensures that the new feature policy will allow the feature in that origin. This is the first part of the eventual solution -- currently this has the effect of allowing the feature even if a sandboxed frame navigates to a new page (causing a new opaque origin to be created for it). Subsequent CLs will add a unique identified to each such origin, and ensure that the generated policies are properly tied to the specific origin of the frame. Bug: 690520 Change-Id: Ie18b9bc3c36be6550baf5a03e355871b9589fd40 Reviewed-on: https://chromium-review.googlesource.com/963382 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550463} | 13 April 2018, 12:05:15 UTC |
1dd03e7 | Darren Shen | 12 April 2018, 11:59:24 UTC | [css-typed-om] Support offset-rotate. Introduces the <angle> data type. Test fails because we compute offset-rotate to a pair rather than 'as specified' had to rebaseline all the tests. Bug: 820299 Change-Id: Ifdc192550b0b544b9887af80c259b3bfeede556b Reviewed-on: https://chromium-review.googlesource.com/1003433 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#550146} | 13 April 2018, 12:04:14 UTC |
a4acccc | Henrik Boström | 13 April 2018, 11:02:17 UTC | Fix race in track-stats.https.html test. This resolves the onIceConnectionStateComplete probmise when iceConnectionState reaches either 'connected' or 'completed' and fixes the race if it had already reached these states before the function was called. This fix is speculative. I am no longer able to repro the TIMEOUT locally with or without the fix. Bug: 829401 Change-Id: I1dec90250d640d93498c59a932ab5e84a3b96f15 Reviewed-on: https://chromium-review.googlesource.com/1012029 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550580} | 13 April 2018, 11:11:53 UTC |
ab9fc1e | Emilio Cobos Álvarez | 13 April 2018, 07:13:53 UTC | Merge pull request #10429 from emilio/mutation-record [cssom] Add a test for mutation records when CSSStyleDeclaration.setPropertyValue is invoked. | 13 April 2018, 07:13:53 UTC |
071e621 | Darren Shen | 13 April 2018, 06:23:04 UTC | [css-typed-om] Support remaining misc properties. Known failures: - all: computed value is always "", it should compute to something... - animation-name: <custom-ident> not mentioned in typed om spec. - cursor: 'grab' and 'grabbing' are still webkit prefixed. - list-style-type: Blink implements something different to the spec. - page: computed value is always "", <custom-ident> not mentioned in typedom spec - perspective: '0' seems to compute to none. - perspective-origin: Blink doesn't support 'none' keyword - quotes: computed value is always "" - size: computed value is always "" - speak: Blink implements something different to the spec. - transform-box: Blink doesn't support 'border-box' keyword - z-index: computed value is always 'auto' (might be something to do with stacking context) Bug: 820299 Change-Id: I629dda1c4bcac92f59cae3bddf11bd375f98e5c2 Reviewed-on: https://chromium-review.googlesource.com/1003434 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550527} | 13 April 2018, 06:52:44 UTC |
96bceca | Yutaka Hirano | 13 April 2018, 05:21:32 UTC | Stringify RequestInit.body As specified, RequestInit.body should be stringified, i.e., {toString(): () => 'hi!'} should be treated as same as 'hi!'. Bug: 831076 Change-Id: I4118c0faa9535d62b3db2529bf23716fdc25a997 Reviewed-on: https://chromium-review.googlesource.com/1004561 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#550523} | 13 April 2018, 05:33:09 UTC |
08c935c | Kent Tamura | 13 April 2018, 04:39:21 UTC | custom-elements: Implement customElements.upgrade(). Intent-to-implement-and-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zCQe7UkR07w Bug: 819482 Change-Id: I5645d5711d7fe1323992533e6c73593ba59d1bca Reviewed-on: https://chromium-review.googlesource.com/1009450 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550513} | 13 April 2018, 05:02:00 UTC |
bdcafae | Emilio Cobos Álvarez | 12 April 2018, 20:51:01 UTC | Let overflow parse two values. Per https://github.com/w3c/csswg-drafts/issues/2484. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453148 gecko-commit: eaf30a1f59eedf65d4d6a5009bebfd014873d64e gecko-integration-branch: central gecko-reviewers: xidorn | 12 April 2018, 21:08:22 UTC |
96f16c5 | Catalin Badea | 11 April 2018, 13:20:49 UTC | Implement Request.destination. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1402892 gecko-commit: 284b35d145ffcdd31fd0ecfef5031aac1bc82553 gecko-integration-branch: mozilla-inbound gecko-reviewers: asuth, baku | 12 April 2018, 20:53:29 UTC |
5170483 | Nicolas Pena | 12 April 2018, 19:56:32 UTC | Remove http/tests/w3c This CL moves the final user-timing tests to external/wpt and removes the folder. The performance_entrylist_checker is changed as in the http counterpart to allow de-duplicating test messages. There are some tests that are related to the wpt counterparts, but not equivalent and in a different format, so unifying some of these tests can be done in the future. Bug: 498037 Change-Id: I6f35d962ba088d92a9768e49a65dea4d5c267491 Reviewed-on: https://chromium-review.googlesource.com/1007888 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#550310} | 12 April 2018, 20:21:40 UTC |
cf2ef62 | jgraham | 12 April 2018, 19:52:22 UTC | Use version-specific prefs files when running Firefox (#10443) Firefox requires a prefs file to be loaded to ensure that it doesn't make external network connections, and to make sure that other settings are appropriate for testing. Previously we always used the version of the prefs file from master, which is usually fine for nightly builds, but doesn't work with release builds if it happens that a pref changed. This change uses the correct release version of the prefs file for firefox releases and beta versions. It continues to use the master version for any nightly build; this could be fixed in some cases if we are able to access the actual commit hash used to build Firefox, but probably isn't too bad an approximation. The caching algorithm was changed so that release versions of the prefs are cached forever, and the nightly version is updated once per day (although this doesn't quite match the nightly release cadence, it's only going to fail in edge cases where the prefs were changed in the file, but the nightly version was not yet updated, of vice-versa.) | 12 April 2018, 19:52:22 UTC |
7e8bc61 | moz-wptsync-bot | 12 April 2018, 18:04:34 UTC | Backed out changeset 0f81334efa0a (bug 1445883) for crashes (bug 1446902). a=backout (#10412) gecko-commit: 9fa586e87f34bef3bb15431d149ec7aeae0f7d24 gecko-integration-branch: central gecko-reviewers: backout | 12 April 2018, 18:04:34 UTC |
fc7af09 | Rob Buis | 12 April 2018, 16:14:10 UTC | Fix regression allowing text value for -webkit-background-origin Fix regression allowing text value for -webkit-background-origin that was caused by r514365. Code change implemented by Bugs Nash, testcase by Rob Buis. Bug: 802256 Change-Id: I11e2b1b19a374e9f6b9c1091d82882ef526bc63c Reviewed-on: https://chromium-review.googlesource.com/1008102 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550221} | 12 April 2018, 16:51:35 UTC |
56a257e | Eric Willigers | 12 April 2018, 16:12:55 UTC | Merge pull request #10170 from ewilligers/backgrounds-borders-parsing CSS Backgrounds and Borders 3 parsing tests | 12 April 2018, 16:12:55 UTC |
940c743 | Eric Willigers | 12 April 2018, 14:56:39 UTC | Update by testing Firefox nightly 61.01a | 12 April 2018, 15:25:12 UTC |
a5bb6d2 | Anne van Kesteren | 12 April 2018, 15:15:45 UTC | Rename cakey.pem to cacert.key for consistency And add a README with some basic instructions for newcomers. | 12 April 2018, 15:15:45 UTC |
0ac0ee7 | pyup.io bot | 12 April 2018, 14:35:14 UTC | Update marionette_driver from 2.5.0 to 2.6.0 (#10437) | 12 April 2018, 14:35:14 UTC |
e965af7 | Daniel Cheng | 12 April 2018, 12:08:45 UTC | Return null from contentDocument/getSVGDocument() for cross-origin documents. Change-Id: I1e66f2cdc50be889b697b54401be6352607fa649 Reviewed-on: https://chromium-review.googlesource.com/1006528 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#550152} | 12 April 2018, 12:36:50 UTC |
976e2c1 | Ian Kilpatrick | 12 April 2018, 12:08:38 UTC | [css-layout-api] Fix DCHECK with the custom layout and multicol. There are probably larger changes that need to happen to ensure that the custom-layout and multicol play nicely together, but this removes a DCHECK crash for now. Bug: 823074 Change-Id: I98f4a34bd0c35e8cd3d23501ca64f38b96be9e7d Reviewed-on: https://chromium-review.googlesource.com/990780 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550148} | 12 April 2018, 12:27:52 UTC |
19a42b9 | Emilio Cobos Álvarez | 11 April 2018, 13:23:42 UTC | followup: Remove a explicit testharness.css link to appease wptlint. on a CLOSED TREE bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 gecko-commit: e90ac14a383f2a3ae97358d68dfcfc47f68e60c2 gecko-integration-branch: central gecko-reviewers: me | 12 April 2018, 09:54:31 UTC |
13758ad | Emilio Cobos Álvarez | 11 April 2018, 13:23:39 UTC | css-align] Upstream our shorthand serialization tests. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 gecko-commit: 4ac4932953254018e6fbd110ab8ab5ca76885069 gecko-integration-branch: central gecko-reviewers: mats | 12 April 2018, 09:54:31 UTC |
b3a9b56 | Emilio Cobos Álvarez | 11 April 2018, 13:23:36 UTC | css-align] Don't restrict shorthand parsing now that's not ambiguous. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 gecko-commit: 91ae8e15b175edc6e6e74b99f68fc155438b20ef gecko-integration-branch: central gecko-reviewers: mats | 12 April 2018, 09:54:31 UTC |
1dcdb61 | Kenichi Ishibashi | 12 April 2018, 07:12:22 UTC | S13nSW: Update wpt/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https.html Before this CL, the test expected that preloadResponse is rejected when decoding a chunked body is failed. However preloadResponse is supposed to be resolved once the headers are arrived. It should be resolved instead of rejected. Update the test to expect that preloadResponse is resolved even for broken chunked body. With S13nSW enabled, this test will start passing but it wouldn't pass w/o S13nSW. This CL also adds a test case where broken chunked body is transfered with delays. Bug: 830472 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibc2909dfc4537f209417a13cff63898ad39229a7 Reviewed-on: https://chromium-review.googlesource.com/1004562 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550061} | 12 April 2018, 07:31:12 UTC |
0060eb4 | Darren Shen | 12 April 2018, 07:12:11 UTC | [css-typed-om] Support remaining multi-col properties. To support column-count which takes <integer>s, we had implement integer handling as resolved by: https://github.com/w3c/css-houdini-drafts/issues/574#issuecomment-366845604 Basically, a non-integer passed to <integer> is 'out of range', so we wrap it in a calc(). Coincidentally, column-count also needs to be positive, so we had to change ComputedStyle::SetColumnCount to clamp. Note that this doesn't change CSSOM behaviour, as the parser would've rejected non-positive values so ComputedStyle only gets positive values. Since Typed OM skips parsing, we have to clamp in ComputedStyle as well. Bug: 820299 Change-Id: Ia56e4bdb55826e72d46c66666addda168dea3d2a Reviewed-on: https://chromium-review.googlesource.com/1001084 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#550058} | 12 April 2018, 07:22:00 UTC |
2d4fbd4 | kaixinjxq | 12 April 2018, 02:28:33 UTC | Add tests for liveness of NodeLists/HTMLCollections (#8993) * Add tests for liveness of NodeLists/HTMLCollections - Node#childNodes - ParentNode#children - {Document,Element}#getElementsByTagName - {Document,Element}#getElementsByTagNameNS - {Document,Element}#getElementsByClassName - Document#images - Document#embeds - Document#plugins - Document#links - Document#forms - Document#scripts - Document#getElementsByName * Move liveness tests to each of API test files * Fixed a nit issue * Modify the test description | 12 April 2018, 02:28:33 UTC |
7bbb8d0 | Emilio Cobos Álvarez | 11 April 2018, 13:24:18 UTC | Stop generating stylo expectations. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452113 gecko-commit: ea3453cc7d92df2539adeb45f390b9dfece2c4e6 gecko-integration-branch: central gecko-reviewers: jgraham | 11 April 2018, 23:58:17 UTC |
c5c79bb | Xidorn Quan | 07 April 2018, 06:37:41 UTC | Add test for checking property order after setting property on CSSStyleDeclaration | 11 April 2018, 22:47:46 UTC |
6003ea3 | Andreas Tolfsen | 11 April 2018, 14:51:35 UTC | Add webdriver.Element string representation. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453084 gecko-commit: bdb78cb3d6d3cd0a5ebc31ee91a3c2590f54bb17 gecko-integration-branch: central gecko-reviewers: whimboo | 11 April 2018, 21:38:48 UTC |
7f13995 | Andreas Tolfsen | 11 April 2018, 14:51:32 UTC | Add webdriver.Session string representation. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453084 gecko-commit: 097b57bbeb46b0f3abc2b6fcec1c41a42d87f5da gecko-integration-branch: central gecko-reviewers: whimboo | 11 April 2018, 21:38:48 UTC |
5a0d559 | jgraham | 11 April 2018, 20:20:17 UTC | Stop running tests on pypy (#10435) I don't recall ever finding a real issue with these tests, but they are flaky and take up valuable machine time in CI. | 11 April 2018, 20:20:17 UTC |
292f368 | Emilio Cobos Álvarez | 11 April 2018, 18:35:20 UTC | Remove usage of setTimeout to appease lint. | 11 April 2018, 18:35:20 UTC |
a747b36 | Emilio Cobos Álvarez | 11 April 2018, 18:28:04 UTC | [cssom] Add tests for removeProperty in its various ways. | 11 April 2018, 18:28:04 UTC |
03d76cc | jgraham | 11 April 2018, 18:24:29 UTC | Don't store logger on the Config object (#10430) Config objects are shared between processes and so must be pickleable. Loggers contain locks and so are not. Instead of storing the logger on the config directly, store the logger name and level and get the logger from the logging module each time. | 11 April 2018, 18:24:29 UTC |
4cf7a66 | joanmarie | 11 April 2018, 17:42:30 UTC | accname: Updated tests (#10433) * Add missing "hidden" style from several tests * Fix expectations for several tests with presentation role used on img * Fix bogus expectations on name and description calculations with combobox * Fix incorrect whitespace in expectations for name from content with spans * Add test for which coverage was missing | 11 April 2018, 17:42:30 UTC |
4b3342e | James Graham | 11 April 2018, 14:49:07 UTC | s/host/browser_host/ in wdspec fixture | 11 April 2018, 16:48:12 UTC |
ddcc729 | James Graham | 11 April 2018, 13:58:30 UTC | Add support for serializing the config as a dictionary. This is required to pass the config into the wdspec tests. | 11 April 2018, 16:48:12 UTC |
a31d306 | Brad Werth | 11 April 2018, 09:35:18 UTC | Part 9: Fix wpt reftest shape-image-025.html to make every frame of the animated GIF use a green box in the lower-left quadrant. This test is designed to check that the float area is calculated from the first frame of an animated GIF. The reference rendering is a solid green square with the lower-left of the square supplied by the pixels in the GIF. Frame 2 of the GIF has white pixels in that quadrant. If layout is completed and onload is fired while frame 2 is showing, the test will fail even though the float area has been correctly calculated. This change puts green in the lower-left quadrant of all frames of the GIF so that the test is only testing the float area and not also testing that onload fires while a certain frame is showing. Note that this change doesn't impact the thoroughness of how we're testing shape-outside because it changes only the color of the pixels and not their opacity, and the float area is calculated from the alpha of the pixels. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404222 gecko-commit: 491be7851cfc3e4959af6e22a1adf70d5f7bb168 gecko-integration-branch: central | 11 April 2018, 16:39:02 UTC |
6b2fe34 | Brad Werth | 11 April 2018, 09:35:15 UTC | Part 8: Fix wpt reftest shape-image-001.html to correct a too-wide container. The test currently stretches a 100 x 100 image to 150 pixels wide, which makes the shaded region of the png stretch to 75 pixels. None of the math in the rest of the test accounts for this stretching, and the test fails on all browsers. It seems clear that the intention was to use an unstretched, 100 pixel wide image, which makes the test pass. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404222 gecko-commit: 1c17b43d22afbd5e25f6d29c9168f2316b36103b gecko-integration-branch: central gecko-reviewers: dholbert | 11 April 2018, 16:39:02 UTC |
ccd2afa | Ting-Yu Lin | 11 April 2018, 09:35:12 UTC | Part 5: Add web-platform-tests for linear-gradient with writing-modes. There's no shape-outside: <image> test with writing-modes on web-platform-tests, so I added some. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404222 gecko-commit: c489650a973000342cb667442321900d904e049e gecko-integration-branch: central gecko-reviewers: dholbert | 11 April 2018, 16:39:02 UTC |
1cda980 | Ting-Yu Lin | 11 April 2018, 09:35:09 UTC | Part 4: Replace hash '#' with %23 in SVG data URIs, to fix XML parse errors. The hash symbol '#' is reserved as fragment identifier per bug 1430526 comment 1, so fix the test cases. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1404222 gecko-commit: bd731b1a68618f1cbce43ce8f46711fafe08fb6e gecko-integration-branch: central gecko-reviewers: dholbert | 11 April 2018, 16:39:02 UTC |