Skip to main content

Browse the archive

Revision fb09ef05dcee8fa0ccaebf88ef1992858ea5a083 authored by Yanqin Jin on 21 March 2020, 02:17:54 UTC, committed by Facebook GitHub Bot on 21 March 2020, 02:30:48 UTC 
Attempt to recover from db with missing table files (#6334)
 
Summary:
There are situations when RocksDB tries to recover, but the db is in an inconsistent state due to SST files referenced in the MANIFEST being missing. In this case, previous RocksDB will just fail the recovery and return a non-ok status.
This PR enables another possibility. During recovery, RocksDB checks possible MANIFEST files, and try to recover to the most recent state without missing table file. `VersionSet::Recover()` applies version edits incrementally and "materializes" a version only when this version does not reference any missing table file. After processing the entire MANIFEST, the version created last will be the latest version.
`DBImpl::Recover()` calls `VersionSet::Recover()`. Afterwards, WAL replay will *not* be performed.
To use this capability, set `options.best_efforts_recovery = true` when opening the db. Best-efforts recovery is currently incompatible with atomic flush.

Test plan (on devserver):
```
$make check
$COMPILE_WITH_ASAN=1 make all && make check
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6334

Reviewed By: anand1976

Differential Revision: D19778960

Pulled By: riversand963

fbshipit-source-id: c27ea80f29bc952e7d3311ecf5ee9c54393b40a8
1 parent 4fc2166
Raw File
transaction_notifier_jnicallback.cc 
// Copyright (c) 2011-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under both the GPLv2 (found in the
//  COPYING file in the root directory) and Apache 2.0 License
//  (found in the LICENSE.Apache file in the root directory).
//
// This file implements the callback "bridge" between Java and C++ for
// ROCKSDB_NAMESPACE::TransactionNotifier.

#include "rocksjni/transaction_notifier_jnicallback.h"
#include "rocksjni/portal.h"

namespace ROCKSDB_NAMESPACE {

TransactionNotifierJniCallback::TransactionNotifierJniCallback(JNIEnv* env,
    jobject jtransaction_notifier) : JniCallback(env, jtransaction_notifier) {
  // we cache the method id for the JNI callback
  m_jsnapshot_created_methodID =
      AbstractTransactionNotifierJni::getSnapshotCreatedMethodId(env);
}

void TransactionNotifierJniCallback::SnapshotCreated(
    const Snapshot* newSnapshot) {
  jboolean attached_thread = JNI_FALSE;
  JNIEnv* env = getJniEnv(&attached_thread);
  assert(env != nullptr);

  env->CallVoidMethod(m_jcallback_obj,
      m_jsnapshot_created_methodID, reinterpret_cast<jlong>(newSnapshot));

  if(env->ExceptionCheck()) {
    // exception thrown from CallVoidMethod
    env->ExceptionDescribe();  // print out exception to stderr
    releaseJniEnv(attached_thread);
    return;
  }

  releaseJniEnv(attached_thread);
}
}  // namespace ROCKSDB_NAMESPACE
back to top