Revision - fb97c82 - Move `libstdc++` path into `LOADER_*_DEP_LIBS` - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

19 April 2024, 06:28:37 UTC

Revision fb97c8287f0bdaef5b9345dcd4dac6e2201fd09b authored by Elliot Saba on 19 January 2023, 04:25:15 UTC, committed by Elliot Saba on 19 January 2023, 18:15:34 UTC

Move `libstdc++` path into `LOADER_*_DEP_LIBS`

After adding `libstdc++` probing into the Julia loader [0], we
originally made the assumption that the `libstdc++` that is shipped with
`julia` would always be co-located with `libjulia.so` [1].  This is not
the case when building with `USE_SYSTEM_CSL=1`, however, where we
sequester system libraries in `usr/lib/julia`, even at build-time.

The path to `libstdc++.so` has already been getting altered when moving
from build-time to install time via `stringreplace` [2], but after
further thought, I decided that it would be better to just use the
pre-existing `LOADER_*_DEP_LIBS` mechanism to communicate to the loader
what the correct relative path to `libstdc++.so` is.  This also allows
the single `stringreplace` to update all of our "special" library paths.

[0] https://github.com/JuliaLang/julia/pull/46976
[1] https://github.com/JuliaLang/julia/pull/46976/files#diff-8c5c98f26f3f7aac8905a1074c5bec11a57e9b9c7c556791deac5a3b27cc096fR379
[2] https://github.com/JuliaLang/julia/blob/master/Makefile#L430

1 parent 1c5fa2b

Files
Changes

Permalinks

Tip revision: fb97c8287f0bdaef5b9345dcd4dac6e2201fd09b authored by Elliot Saba on 19 January 2023, 04:25:15 UTC
Move `libstdc++` path into `LOADER_*_DEP_LIBS`

Tip revision: fb97c82

File	Mode	Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version	-rw-r--r--	5 bytes
.clang-format	-rw-r--r--	3.3 KB
.codecov.yml	-rw-r--r--	52 bytes
.git-blame-ignore-revs	-rw-r--r--	294 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	507 bytes
.mailmap	-rw-r--r--	12.1 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	940 bytes
CONTRIBUTING.md	-rw-r--r--	23.1 KB
HISTORY.md	-rw-r--r--	363.4 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	52.3 KB
Makefile	-rw-r--r--	29.7 KB
NEWS.md	-rw-r--r--	1.5 KB
README.md	-rw-r--r--	7.3 KB
THIRDPARTY.md	-rw-r--r--	3.7 KB
VERSION	-rw-r--r--	11 bytes
julia.spdx.json	-rw-r--r--	35.8 KB
sysimage.mk	-rw-r--r--	4.1 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

Move `libstdc++` path into `LOADER_*_DEP_LIBS`

README.md