Skip to main content

Browse the archive

Revision fc7af09fb3eea0ef511a061e5734c1dc8e539b0d authored by Rob Buis on 12 April 2018, 16:14:10 UTC, committed by Blink WPT Bot on 12 April 2018, 16:51:35 UTC 
Fix regression allowing text value for -webkit-background-origin
 
Fix regression allowing text value for -webkit-background-origin that
was caused by r514365.

Code change implemented by Bugs Nash, testcase by Rob Buis.

Bug: 802256

Change-Id: I11e2b1b19a374e9f6b9c1091d82882ef526bc63c
Reviewed-on: https://chromium-review.googlesource.com/1008102
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550221}
1 parent 56a257e
Raw File
idbfactory-open-request-error.html 
<!DOCTYPE html>
<meta charset=utf-8>
<title>IDBFactory open(): request properties on error</title>
<link rel="help" href="https://w3c.github.io/IndexedDB/#dom-idbfactory-open">
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src=support.js></script>
<script>

let saw_abort = false;

indexeddb_test(
  (t, db, tx, rq) => {
    const store = db.createObjectStore('store');
    store.put({name: 'a'}, 1);
    store.put({name: 'a'}, 2);
    store.createIndex('index', 'name', {unique: true});

    assert_equals(
      rq.readyState, 'done',
      'request done flag should be set during upgradeneeded');
    assert_equals(
      rq.result, db,
      'request result should be set (to connection) during upgradeneeded');
    assert_equals(
      rq.error, null,
      'request result should be null during upgradeneeded');

    tx.oncomplete = t.unreached_func('transaction should abort');
    tx.onabort = t.step_func(() => {
      saw_abort = true;

      assert_equals(
        rq.readyState, 'done',
        'request done flag should still be set during abort');

      // Chrome is flaky here. See: https://crbug.com/723846
      /*
      assert_equals(
        rq.result, db,
        'request result should still be set (to connection) during abort');
      assert_equals(
        rq.error, null,
        'request result should still be null during abort');
      */
    });

    rq.onerror = t.step_func(() => {
      assert_true(saw_abort, 'abort event should fire before error');
      assert_equals(
        rq.readyState, 'done',
        'request done flag should be set on error');
      assert_equals(
        rq.result, undefined,
        'request result should be undefined on error');
      assert_equals(
        rq.error.name, 'AbortError',
        'request error should be AbortError on error');
      t.done();
    });
  },
  (t, db) => {},
  'Properties of IDBOpenDBRequest during failed IDBFactory open()',
  {upgrade_will_abort: true});

</script>
back to top