Skip to main content

Browse the archive

swh:1:snp:a274b44111f777209556e94920b7e71cf5c305cd
Revision fd72a1cb3741ffc029d46da6e4830b04f5bedc06 authored by Paolo Amadini on 28 November 2017, 16:53:42 UTC, committed by Paolo Amadini on 28 November 2017, 16:53:42 UTC 
Bug 1392340 - Height jumps when opening subviews of different lengths. r=Gijs
 
The height of the subview being opened was supposedly calculated using an off-screen container independent from the currently displayed views, but this didn't work as expected because of the incorrect box alignment. This is now fixed and the correct minimum and maximum heights are set on the container separately, also preventing the current view from flickering before the transition in case the subview was taller.

With this issue fixed, the height can now be recalculated each time the subview is opened, without the caching that caused incorrect results when the same view was reopened with different elements or text.

Jumping could also occur because of a border applied only during the transition, which could influence the subview height in the presence of wrapping text.

MozReview-Commit-ID: EWHs1hFKXT4

--HG--
extra : rebase_source : 5b0bc4e5d4d2d10d684c2c2bf94a9030aadd09bd
1 parent 224d94c
History
Tip revision: 676235b3bbf9ca366d6d5e735cf3a1e49db861e3 authored by Noemi Erli on 02 December 2017, 21:41:02 UTC
Merge inbound to mozilla-central r=merge a=merge
Tip revision: 676235b
File Mode Size
.cargo
.vscode
accessible
browser
build
caps
chrome
config
db
devtools
docshell
dom
editor
embedding
extensions
gfx
gradle
hal
image
intl
ipc
js
layout
media
memory
mfbt
mobile
modules
mozglue
netwerk
nsprpub
other-licenses
parser
python
rdf
security
services
servo
startupcache
storage
taskcluster
testing
third_party
toolkit
tools
uriloader
view
widget
xpcom
xpfe
.clang-format -rw-r--r-- 811 bytes
.clang-format-ignore -rw-r--r-- 3.3 KB
.cron.yml -rw-r--r-- 3.3 KB
.eslintignore -rw-r--r-- 11.6 KB
.eslintrc.js -rw-r--r-- 847 bytes
.flake8 -rw-r--r-- 217 bytes
.gdbinit -rw-r--r-- 5.2 KB
.gdbinit_python -rw-r--r-- 80 bytes
.gitignore -rw-r--r-- 3.0 KB
.hgignore -rw-r--r-- 3.9 KB
.hgtags -rw-r--r-- 8.6 KB
.inferconfig -rw-r--r-- 228 bytes
.lldbinit -rw-r--r-- 1.6 KB
.taskcluster.yml -rw-r--r-- 7.7 KB
.yamllint -rw-r--r-- 49 bytes
.ycm_extra_conf.py -rw-r--r-- 1.6 KB
AUTHORS -rw-r--r-- 33.6 KB
CLOBBER -rw-r--r-- 1.1 KB
GNUmakefile -rw-r--r-- 261 bytes
LEGAL -rw-r--r-- 2.5 KB
LICENSE -rw-r--r-- 389 bytes
Makefile.in -rw-r--r-- 11.7 KB
README.txt -rw-r--r-- 1.2 KB
aclocal.m4 -rw-r--r-- 1.6 KB
build.gradle -rw-r--r-- 4.7 KB
client.mk -rw-r--r-- 5.2 KB
client.py -rwxr-xr-x 6.9 KB
configure.in -rw-r--r-- 1.1 KB
configure.py -rw-r--r-- 5.0 KB
gradle.properties -rw-r--r-- 77 bytes
gradlew -rwxr-xr-x 4.8 KB
mach -rwxr-xr-x 3.1 KB
moz.build -rw-r--r-- 2.5 KB
moz.configure -rwxr-xr-x 18.2 KB
mozilla-config.h.in -rw-r--r-- 2.1 KB
npm-shrinkwrap.json -rw-r--r-- 55.0 KB
old-configure.in -rw-r--r-- 167.3 KB
package.json -rw-r--r-- 527 bytes
settings.gradle -rw-r--r-- 2.4 KB
test.mozbuild -rw-r--r-- 429 bytes

README.txt

back to top