sort by:
Revision Author Date Message Commit Date
fd7ed33 More logging for performance 28 February 2020, 20:23:25 UTC
d10eede Log the cancellation request responses. 28 February 2020, 20:19:34 UTC
f1457c1 office-ui-fabric: silence progress counter again 27 February 2020, 23:29:09 UTC
f4e371c Harden findAllReferences.ts against `symbol.declarations = undefined` cases (#37088) Fixes #37086 27 February 2020, 22:55:49 UTC
241b3b9 Forcibly remove _the other_ submodules 27 February 2020, 22:36:08 UTC
a792fbb Forcibly remove submodules 27 February 2020, 22:30:50 UTC
0326534 Update LKG (#37087) 27 February 2020, 22:24:21 UTC
d0c1a52 LEGO: Merge pull request 37089 LEGO: Merge pull request 37089 27 February 2020, 22:11:21 UTC
3d23f08 LEGO: check in for master to temporary branch. 27 February 2020, 22:10:46 UTC
5c85feb Fix Get/Set being enumerable (#32264) * Fix Get/Set being enumerable fixes #3610 * fix tests Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> 27 February 2020, 22:08:20 UTC
e7c578a Reapply contextual type when recalculating array literals as tuples (#37071) 27 February 2020, 22:02:28 UTC
e71614a Proper treatment of splicing tuples in array literals Fixes #32465. After this was done, I continued to extend the implementation to handle TupleLike types but it'ss broken since JS doesn't allow splicing TupleLike values into array literals so pulled that out, and instead keeping it for reference below. (It Includes tests, which are broken too.) modified src/compiler/checker.ts @@ -22268,6 +22268,21 @@ namespace ts { else hasNonEndingSpreadElement = true; } } + else if (spreadType && isTupleLikeType(spreadType)) { + let i = 0, tupleEltType: Type | undefined; + while (tupleEltType = getTypeOfPropertyOfType(spreadType, "" + i as __String)) { + elementTypes.push(tupleEltType); + i++; + } + const stringIndexInfo = getIndexInfoOfType(spreadType, IndexKind.String); + const numberIndexInfo = getIndexInfoOfType(spreadType, IndexKind.Number); + if (stringIndexInfo || numberIndexInfo) { + if (stringIndexInfo) elementTypes.push(stringIndexInfo.type); + if (numberIndexInfo) elementTypes.push(numberIndexInfo.type); + if (i === elementCount - 1) hasEndingSpreadElement = true; + else hasNonEndingSpreadElement = true; + } + } else { if (inDestructuringPattern && spreadType) { // Given the following situation: new file tests/cases/compiler/spliceTupleLikesWIntegers.ts @@ -0,0 +1,23 @@ +declare const sb: { [0]: string, [1]: boolean }; + +let k1: [number, string, boolean]; +k1 = [1, ...sb]; + +let k2: [number, string, boolean, number]; +k2 = [1, ...sb, 1]; + +// declare const sb_: [string, ...boolean[]]; + +// let k3: [number, string, ...boolean[]]; +// k3 = [1, ...sb_]; + +// declare const sbb_: [string, boolean, ...boolean[]]; + +// let k4: [number, string, ...boolean[]]; +// k4 = [1, ...sbb_]; + +// let k5: [number, string, boolean, ...boolean[]]; +// k5 = [1, ...sbb_]; + +// let k6: [number, string, boolean, boolean, ...boolean[]]; +// k6 = [1, ...sbb_]; new file tests/cases/compiler/spliceTupleLikesWStrings.ts @@ -0,0 +1,23 @@ +declare const sb: { 0: string, 1: boolean }; + +let k1: [number, string, boolean]; +k1 = [1, ...sb]; + +let k2: [number, string, boolean, number]; +k2 = [1, ...sb, 1]; + +declare const sb_: { 0: string, [s: string]: (boolean|string) }; + +let k3: [number, string, ...(boolean|string)[]]; +k3 = [1, ...sb_]; + +declare const sbb_: { 0: string, 1: boolean, [s: string]: (boolean|string) }; + +let k4: [number, string, boolean, ...(boolean|string)[]]; +k4 = [1, ...sbb_]; + +// let k5: [number, string, boolean, ...(boolean|string)[]]; +// k5 = [1, ...sbb_]; + +// let k6: [number, string, boolean, boolean, ...(boolean|string)[]]; +// k6 = [1, ...sbb_]; 27 February 2020, 21:43:29 UTC
6c5c48c Exempt ambient [#]private from unused error (#37050) * Exempt ambient [#]private from unused error These declarations exist to create nominality so they _must_ be unused. There should be no error for them. * Switch to fourslash test I don't know how to baseline suggestion diagnostics in the compiler tests. 27 February 2020, 21:18:43 UTC
35aea8b Remove crashing diagnostic code that wasn't helping us (#36913) 27 February 2020, 20:45:28 UTC
d33fb87 Include input PR title in bot PR title 27 February 2020, 19:07:32 UTC
188c3b7 Measure module and type reference directive times (#37054) 27 February 2020, 18:22:40 UTC
e804dc8 Update the authors script to generate the content of authors.md (#36867) 27 February 2020, 17:47:09 UTC
2c4155c Adds underlines to differences in strings (#36409) 27 February 2020, 17:46:15 UTC
f883bf3 Adding support for @implements. (#36292) * Adding support for @implements. * Fixed code review issues for @implements, added some more tests. * Fixed declaration emit for @interface * Improved getImplementsTypes to not cache the results since it is only used once. * Removed unnecessary checks from getImplementsTypes 27 February 2020, 17:27:37 UTC
e3ec3d1 LEGO: Merge pull request 37080 LEGO: Merge pull request 37080 27 February 2020, 16:11:08 UTC
5d38883 LEGO: check in for master to temporary branch. 27 February 2020, 16:10:31 UTC
a6393b3 LEGO: Merge pull request 37074 LEGO: Merge pull request 37074 27 February 2020, 10:11:09 UTC
97157b4 LEGO: check in for master to temporary branch. 27 February 2020, 10:10:32 UTC
baff821 fix(36989): 'async' modifier cannot be used in an ambient context.ts (#37010) * fix(36989): omit 'async' modifier for methods in declaration files. * remove useless condition 27 February 2020, 08:11:29 UTC
60f50e2 LEGO: Merge pull request 37068 LEGO: Merge pull request 37068 27 February 2020, 04:11:06 UTC
91df1c8 LEGO: check in for master to temporary branch. 27 February 2020, 04:10:29 UTC
d07761f Allow --composite false or --composite null on the command line (#36997) * Add tests for specifying composite as command line option * Allow passing --composite false on commandline * Add test to verify tsc --composite false from command line * Handle "undefined" as option value to be set to undefined for that option * Support "null" as option to be converted to undefined which is normally end result from our config file as well * Support null as option for any tsconfig only option as well, and dont support undefined * Fix public api test case * Validates objects instead of stringify result * Add composite true to base source 26 February 2020, 23:26:26 UTC
05c9ec3 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command (#37059) Fixes #35034 26 February 2020, 23:25:51 UTC
c4e9685 Detect circularities when removing 'undefined' from defaulted params (#37023) Fixes #37008 Note that referencing a variable in its initializer is a TDZ error; the OP report had OOB logic that prevented this in practice (?) 26 February 2020, 22:59:04 UTC
f7d2beb LEGO: Merge pull request 37058 LEGO: Merge pull request 37058 26 February 2020, 22:11:15 UTC
42058a8 LEGO: check in for master to temporary branch. 26 February 2020, 22:10:40 UTC
b424f36 Expose call count for instantiateType in extendedDiagnostics (#36797) * Expose call count for instantiateType in extendedDiagnostics * Update API baselines 26 February 2020, 20:55:28 UTC
3d63401 Update baseline (#37049) 26 February 2020, 18:28:22 UTC
af901ba No error on `this` exprs in static property inits (#36781) No error on `this` expressions in static property declaration initialisers when targetting ESNext and with useDefineForClassFields. In this case the emit is correct and the types are correct, so the error should not be issued. 26 February 2020, 17:07:45 UTC
454cdb8 Retain undefined initializations (#36806) * Emit an export assignment even when the initializer is elided * User a void 0; and elide assignments for enum/namespace-sourced exported variables * HAHA, SIMPLIFY GREATLY 26 February 2020, 16:48:18 UTC
56b6d0d Update user baselines (#37033) 26 February 2020, 01:47:21 UTC
15dd000 Unwrap substitutions both before _and_ after potential simplification (#32116) * Unwrap substitutions both before _and_ after potential simplification * Repeatedly unwrap/simplify until no more can be performed * Use seperate loops for source and target to reduce redundant calls * Move loop into function * Inline worker 26 February 2020, 01:36:56 UTC
4d5464e Revert "Support declaration emit for late bound element accesses assigned to functions in both TS and JS (#36593)" (#37034) This reverts commit 3e4ce4777d382f2f2b49bd2c7a279b068278552a. 26 February 2020, 00:40:38 UTC
9ed73eb Properly handle control flows from returns in try/catch within IIFE (#36901) * Properly handle control flows from returns in try/catch within IIFE * Accept new baselines * Add tests * Accept new baselines * When end of finally is unreachable, end of try statement is too * Add additional test case 26 February 2020, 00:14:00 UTC
e89df5c Handle getScriptVersion correctly to ensure program structure is checked correctly (#36808) * Fix tests when there are project references but has disableSourceOfProjectReferenceRedirect * Handle getScriptVersion correctly to ensure program structure is checked correctly Fixes #36748 * Harness's language service host doesnt have getProjectVersion. This means earlier we were creating fresh program everytime we did LS operation Now we reuse same program, so quick info depends on order of quickinfo demands * Because same program is used, it unvails a bug that if `export=` is evaluated before finding references, it cant find all definitions from the merge * Update src/server/project.ts Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> * Make clearSourceMapperCache required Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> 26 February 2020, 00:11:21 UTC
e99173a Ignore data- props when excess property checking (#36952) 25 February 2020, 23:52:24 UTC
d92aca2 Reduce lerna loglevel (#37024) * Reduce lerna loglevel * Also add silent 25 February 2020, 22:23:55 UTC
8a797ca Adds floating block comments to the outlining spans response (#36880) * Adds floating block comments to the outlining spans response * Only use one route for grabbing outline nodes, which now includes special casing the EOF token 25 February 2020, 22:09:16 UTC
43863ca Check for undefined `source.symbol` (#37021) Fixes #37014 25 February 2020, 21:46:24 UTC
3e4ce47 Support declaration emit for late bound element accesses assigned to functions in both TS and JS (#36593) 25 February 2020, 21:45:27 UTC
7d8dc73 Baseline arity checks for jsx sfc tags (#36643) Finish comment PR feedback 25 February 2020, 21:44:22 UTC
e536c89 Add js-equivalent test for the binary expression stress and introduce trampoline into getJSSyntacticDiagnosticsForFile (#36724) * Add js-equivalent test for the binary expression stress and introduce trampiline into getJSSyntacticDiagnosticsForFile * Update src/compiler/parser.ts Comment text update Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> * Fix lint Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> 25 February 2020, 21:29:34 UTC
01f81df Add helpers to helper list, per comment on #36806 25 February 2020, 19:46:05 UTC
c22cdb4 Harden telemetryOnOpenFile (#36993) 25 February 2020, 19:32:32 UTC
e54b796 Declare dependencies between helpers in the declaritive fashion introduced by #35967 (#37001) 25 February 2020, 19:29:59 UTC
e120762 Remove unneeded branch from getHelperName (#36998) 25 February 2020, 19:29:45 UTC
26184f0 LEGO: Merge pull request 37018 LEGO: Merge pull request 37018 25 February 2020, 16:11:01 UTC
5af94fa LEGO: check in for master to temporary branch. 25 February 2020, 16:10:24 UTC
177713e Switch Debug.assertX functions to use asserts conditions (#36995) * Switch Debug.assertX functions to use asserts conditions * Replace assert functions with ts.noop when assertion level too low 25 February 2020, 02:20:58 UTC
b5bd38b Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags (#36947) ...to save space (and possibly to reduce de-opts, since it appears to be lazily set). 25 February 2020, 02:18:39 UTC
865c120 Use couldContainTypeVariables to short-circuit instantiateType (#36951) This is particularly impactful for large unions of string literals. 25 February 2020, 01:50:44 UTC
6d1361c Add --force to vue-next dockerfile since latest image version errors without it 25 February 2020, 01:38:16 UTC
60e172d Update user baselines (#37003) 25 February 2020, 01:17:07 UTC
544f441 Rescedule nightly publish to 11pm pst, (7am ust) So a nightly publish actually happens at what is night for most of the team. 25 February 2020, 01:13:00 UTC
8fe8284 Update user baselines (#36999) 25 February 2020, 00:18:18 UTC
3e3df87 Fix crash on aliased,exported @enum tag in jsdoc (#36996) THe code to bind `@enum` and `@typedef` didn't handle the case that the `@enum` was on a property assignment to an alias of module.exports. Specifically, `x` needs to be correctly aliased to the file's symbol in the example below: ``` var x = module.exports = {}; /** @enum {string} */ x.E = { A: "A" }; ``` 25 February 2020, 00:13:18 UTC
65e7acc Use getters to define live export bindings refresh (#35967) * use getters to define live export bindings * fix scoping in export* helper * Object.defineProperty cannot be used in ES3 target * Accept changed baselines * Use function expression, not arrow function * Update importStarHelper to match export helper in binding-making * Fix whitespace * Adjust whitespace in edited helpers * Use new helper for setting bindings, use unscoped __exportStar helper for exports so helpers get reused more * Accept updated baselines * Use __createBinding for individual reexports when target is es3 * Remove unneeded type assertion * Singeline the helpers * Add check for createBinding helper, accept updated baselines with shortened helper Co-authored-by: Michael Rawlings <mirawlings@ebay.com> 24 February 2020, 23:36:14 UTC
7a3b6b4 Update user baselines (#36992) 24 February 2020, 22:27:34 UTC
4e16be6 LEGO: Merge pull request 36991 LEGO: Merge pull request 36991 24 February 2020, 22:11:09 UTC
9ec9d94 LEGO: check in for master to temporary branch. 24 February 2020, 22:10:34 UTC
3edf5f5 Update user baselines (#36973) 24 February 2020, 21:46:59 UTC
2b69b22 Properly handle both special export forms when renaming (#36914) * Properly handle both special export forms when renaming Fixes #36713 * Lint 24 February 2020, 21:17:02 UTC
3bec9ad Set CI=true in the office-ui-fabric docker test so it doesnt use a progress indicator (#36982) 24 February 2020, 20:45:14 UTC
fd8000d Fix class emit in converted loop body (#36795) 24 February 2020, 18:55:13 UTC
fcd55c2 Update CONTRIBUTING.md (#36553) 24 February 2020, 17:00:24 UTC
a707800 LEGO: Merge pull request 36980 LEGO: Merge pull request 36980 24 February 2020, 16:10:59 UTC
a2bb27c LEGO: check in for master to temporary branch. 24 February 2020, 16:10:23 UTC
c6cdc63 sanitize yarn-node path in output (#36953) * sanitize yarn-node path in output * Update user baselines (#58) Co-authored-by: Wesley Wigham <wwigham@gmail.com> Co-authored-by: TypeScript Bot <ts_bot@rcavanaugh.com> 22 February 2020, 00:38:00 UTC
ebca423 Add elaboration & quickfix for async-able arrow function (#36342) 21 February 2020, 23:51:02 UTC
6b645f5 Fix find-refs crash on JSDocNamepath (#36941) JSDocNamepaths span a lot of identifiers that we don't actually care about, so it's incorrect for createChildren to add its children as synthetic nodes. 21 February 2020, 23:37:11 UTC
7bcb723 Name workflow 21 February 2020, 22:52:57 UTC
83271b7 Probably dont need artifact drops on release branch PRs 21 February 2020, 22:49:47 UTC
b5cb71a Add task mirroring devops release branch artifact building pipeline 21 February 2020, 22:49:00 UTC
c550c7e Update user baselines (#36942) 21 February 2020, 22:42:27 UTC
9190fac Some would say it's trigger'd 21 February 2020, 22:20:19 UTC
57df466 Publishing to npm isnt the default on github for reasons 21 February 2020, 18:43:02 UTC
5c7ef4c Make the nightly publish cron task also respond to a publish-nightly event 21 February 2020, 18:40:05 UTC
d95942b Port nightly publish task to actions 21 February 2020, 18:35:44 UTC
a5061ef Update scripts for octokit 17 (#36915) * Update scripts for octokit 17 Also put playwright in alphabetical order, npm seems to like that. * back to passing auth in the ctor I GUESS 21 February 2020, 17:49:02 UTC
24dd93f Fix access of protected members on generic this-type (#36928) Fixes: #36926 21 February 2020, 17:33:21 UTC
ab1b17b LEGO: Merge pull request 36934 LEGO: Merge pull request 36934 21 February 2020, 16:11:07 UTC
4bf28cb LEGO: check in for master to temporary branch. 21 February 2020, 16:10:25 UTC
17e9b76 LEGO: Merge pull request 36923 LEGO: Merge pull request 36923 21 February 2020, 10:11:05 UTC
219f6d7 LEGO: check in for master to temporary branch. 21 February 2020, 10:10:25 UTC
cf24c4f Fix copy-paste error in navigateToItemIsEqualTo (#36912) * Fix copy-paste error in navigateToItemIsEqualTo It was preventing de-duping of items found in multiple projects. * Add de-duping test 21 February 2020, 01:30:50 UTC
d0c961e Try removing fetch-depth 0 config to improve speed, add sync-branch workflow 20 February 2020, 23:06:58 UTC
7ee1ef0 Cast version result so it isnt declaration emitted as a literal type once it has a wellknown value 20 February 2020, 22:49:04 UTC
f80c0c1 Add set-version workflow 20 February 2020, 22:19:08 UTC
4d1a1b8 Expose importModuleSpecifierEnding to protocol (#36725) * Expose importModuleSpecifierEnding to protocol * Update API baselines * Add explicit auto setting 20 February 2020, 21:59:56 UTC
7f02927 use const instead of let for new class iife assignments (#36907) 20 February 2020, 20:48:02 UTC
2c16ee3 Copy diagnostic messages to built/local to fix localization process (#36903) * Copy diagnostic messages to built/local * Add description for built/local/diagnosticMessages.generated.json 20 February 2020, 19:41:53 UTC
f10c9ea azure-sdk test: move typescript location (#36902) 20 February 2020, 18:09:37 UTC
cb90dc0 Remove trailing whitespace from copyright notice (#36886) * Remove trailing whitespace from copyright notice How long has this been here for, wow. * Accept updated whitespace-free API baselines 20 February 2020, 17:46:50 UTC
bf6be75 feat(36048): handle uncalled function checks in ternaries (#36402) 20 February 2020, 17:29:41 UTC
c8147cb fix(33377): use quoteStyle option for string literals completions (#36720) 20 February 2020, 16:45:07 UTC
back to top