Skip to main content

Browse the archive

https://github.com/postgres/postgres
07 April 2024, 13:56:23 UTC
Revision fd90f6ba7a75f51d14dac27219bb3755b893e251 authored by Fujii Masao on 27 July 2021, 16:20:16 UTC, committed by Fujii Masao on 27 July 2021, 16:21:35 UTC 
Avoid using ambiguous word "non-negative" in error messages.
 
The error messages using the word "non-negative" are confusing
because it's ambiguous about whether it accepts zero or not.
This commit improves those error messages by replacing it with
less ambiguous word like "greater than zero" or
"greater than or equal to zero".

Also this commit added the note about the word "non-negative" to
the error message style guide, to help writing the new error messages.

When postgres_fdw option fetch_size was set to zero, previously
the error message "fetch_size requires a non-negative integer value"
was reported. This error message was outright buggy. Therefore
back-patch to all supported versions where such buggy error message
could be thrown.

Reported-by: Hou Zhijie
Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com
1 parent 5a353a2
History
Tip revision: fd90f6ba7a75f51d14dac27219bb3755b893e251 authored by Fujii Masao on 27 July 2021, 16:20:16 UTC
Avoid using ambiguous word "non-negative" in error messages.
Tip revision: fd90f6b
File Mode Size
config
contrib
doc
src
.dir-locals.el -rw-r--r-- 730 bytes
.editorconfig -rw-r--r-- 183 bytes
.git-blame-ignore-revs -rw-r--r-- 8.6 KB
.gitattributes -rw-r--r-- 1.5 KB
.gitignore -rw-r--r-- 504 bytes
COPYRIGHT -rw-r--r-- 1.2 KB
GNUmakefile.in -rw-r--r-- 4.2 KB
HISTORY -rw-r--r-- 277 bytes
Makefile -rw-r--r-- 1.6 KB
README -rw-r--r-- 1.2 KB
README.git -rw-r--r-- 721 bytes
aclocal.m4 -rw-r--r-- 490 bytes
configure -rwxr-xr-x 567.2 KB
configure.ac -rw-r--r-- 81.3 KB

README

back to top