Revision fdad35ef6c5839d50dfc14073364ac893afebc30 authored by Eric Blake on 22 November 2017, 22:25:16 UTC, committed by Eric Blake on 28 November 2017, 12:42:26 UTC
The NBD spec gives us permission to abruptly disconnect on clients
that send outrageously large option requests, rather than having
to spend the time reading to the end of the option.  No real
option request requires that much data anyways; and meanwhile, we
already have the practice of abruptly dropping the connection on
any client that sends NBD_CMD_WRITE with a payload larger than 32M.

For comparison, nbdkit drops the connection on any request with
more than 4096 bytes; however, that limit is probably too low
(as the NBD spec states an export name can theoretically be up
to 4096 bytes, which means a valid NBD_OPT_INFO could be even
longer) - even if qemu doesn't permit exports longer than 256
bytes.

It could be argued that a malicious client trying to get us to
read nearly 4G of data on a bad request is a form of denial of
service.  In particular, if the server requires TLS, but a client
that does not know the TLS credentials sends any option (other
than NBD_OPT_STARTTLS or NBD_OPT_EXPORT_NAME) with a stated
payload of nearly 4G, then the server was keeping the connection
alive trying to read all the payload, tying up resources that it
would rather be spending on a client that can get past the TLS
handshake.  Hence, this warranted a CVE.

Present since at least 2.5 when handling known options, and made
worse in 2.6 when fixing support for NBD_FLAG_C_FIXED_NEWSTYLE
to handle unknown options.

CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
1 parent c7e1f82
History
File Mode Size
accel
audio
backends
block
bsd-user
capstone @ 22ead3e
chardev
contrib
crypto
default-configs
disas
docs
dtc @ 558cd81
fpu
fsdev
gdb-xml
hw
include
io
libdecnumber
linux-headers
linux-user
migration
nbd
net
pc-bios
po
qapi
qga
qobject
qom
replay
roms
scripts
scsi
slirp
stubs
target
tcg
tests
trace
ui
util
.dir-locals.el -rw-r--r-- 75 bytes
.editorconfig -rw-r--r-- 200 bytes
.exrc -rw-r--r-- 220 bytes
.gdbinit -rw-r--r-- 326 bytes
.gitignore -rw-r--r-- 2.5 KB
.gitmodules -rw-r--r-- 1.3 KB
.mailmap -rw-r--r-- 1.4 KB
.shippable.yml -rw-r--r-- 1.9 KB
.travis.yml -rw-r--r-- 6.4 KB
CODING_STYLE -rw-r--r-- 5.7 KB
COPYING -rw-r--r-- 17.6 KB
COPYING.LIB -rw-r--r-- 25.8 KB
COPYING.PYTHON -rw-r--r-- 13.3 KB
Changelog -rw-r--r-- 22.6 KB
HACKING -rw-r--r-- 9.9 KB
LICENSE -rw-r--r-- 840 bytes
MAINTAINERS -rw-r--r-- 40.5 KB
Makefile -rw-r--r-- 32.9 KB
Makefile.objs -rw-r--r-- 5.7 KB
Makefile.target -rw-r--r-- 6.4 KB
README -rw-r--r-- 3.5 KB
VERSION -rw-r--r-- 8 bytes
arch_init.c -rw-r--r-- 3.1 KB
balloon.c -rw-r--r-- 3.4 KB
block.c -rw-r--r-- 151.2 KB
blockdev-nbd.c -rw-r--r-- 5.1 KB
blockdev.c -rw-r--r-- 121.0 KB
blockjob.c -rw-r--r-- 24.4 KB
bootdevice.c -rw-r--r-- 9.2 KB
bt-host.c -rw-r--r-- 5.2 KB
bt-vhci.c -rw-r--r-- 4.5 KB
configure -rwxr-xr-x 174.4 KB
cpus-common.c -rw-r--r-- 10.1 KB
cpus.c -rw-r--r-- 54.4 KB
device-hotplug.c -rw-r--r-- 2.6 KB
device_tree.c -rw-r--r-- 12.9 KB
disas.c -rw-r--r-- 17.7 KB
dma-helpers.c -rw-r--r-- 7.9 KB
dump.c -rw-r--r-- 59.5 KB
exec.c -rw-r--r-- 107.8 KB
gdbstub.c -rw-r--r-- 52.1 KB
hmp-commands-info.hx -rw-r--r-- 18.0 KB
hmp-commands.hx -rw-r--r-- 52.9 KB
hmp.c -rw-r--r-- 89.4 KB
hmp.h -rw-r--r-- 7.9 KB
ioport.c -rw-r--r-- 9.0 KB
iothread.c -rw-r--r-- 10.3 KB
memory.c -rw-r--r-- 98.8 KB
memory_ldst.inc.c -rw-r--r-- 20.1 KB
memory_mapping.c -rw-r--r-- 10.5 KB
module-common.c -rw-r--r-- 113 bytes
monitor.c -rw-r--r-- 111.8 KB
numa.c -rw-r--r-- 22.5 KB
os-posix.c -rw-r--r-- 7.9 KB
os-win32.c -rw-r--r-- 3.7 KB
qapi-schema.json -rw-r--r-- 81.6 KB
qdev-monitor.c -rw-r--r-- 26.4 KB
qdict-test-data.txt -rw-r--r-- 88.4 KB
qemu-bridge-helper.c -rw-r--r-- 11.0 KB
qemu-doc.texi -rw-r--r-- 75.7 KB
qemu-ga.texi -rw-r--r-- 3.2 KB
qemu-img-cmds.hx -rw-r--r-- 5.2 KB
qemu-img.c -rw-r--r-- 137.2 KB
qemu-img.texi -rw-r--r-- 29.3 KB
qemu-io-cmds.c -rw-r--r-- 59.1 KB
qemu-io.c -rw-r--r-- 16.6 KB
qemu-keymap.c -rw-r--r-- 7.4 KB
qemu-nbd.c -rw-r--r-- 32.8 KB
qemu-nbd.texi -rw-r--r-- 4.3 KB
qemu-option-trace.texi -rw-r--r-- 1021 bytes
qemu-options-wrapper.h -rw-r--r-- 1.0 KB
qemu-options.h -rw-r--r-- 1.4 KB
qemu-options.hx -rw-r--r-- 175.2 KB
qemu-seccomp.c -rw-r--r-- 5.4 KB
qemu-tech.texi -rw-r--r-- 12.3 KB
qemu.nsi -rw-r--r-- 7.1 KB
qemu.sasl -rw-r--r-- 1.8 KB
qmp.c -rw-r--r-- 19.5 KB
qtest.c -rw-r--r-- 20.2 KB
replication.c -rw-r--r-- 2.5 KB
replication.h -rw-r--r-- 5.2 KB
rules.mak -rw-r--r-- 14.1 KB
thunk.c -rw-r--r-- 9.1 KB
tpm.c -rw-r--r-- 5.7 KB
trace-events -rw-r--r-- 5.3 KB
version.rc -rw-r--r-- 790 bytes
vl.c -rw-r--r-- 144.7 KB

README

back to top