Revision - fe3e4d6 - fix(compiler-cli): Handle `ng-template` with structural [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

19 April 2024, 08:24:33 UTC

Revision fe3e4d6865c1e760be0511cfd757b4574a67fa5b authored by Andrew Scott on 21 January 2022, 19:51:40 UTC, committed by Andrew Kushnir on 25 January 2022, 22:15:45 UTC

fix(compiler-cli): Handle `ng-template` with structural directive in indexer (#44788)

An `ng-template` with an inline template (i.e. has a structural
directive) would previously not get an `undefined` `tagName` because the
logic assumed the element would be `t.Element` or `t.Content` and read
the tag name from the `name` property. For a `t.Template`, this exists
instead on the `t.tagName`. The final result would be an `tagName` of `undefined`
for the parent `t.Template`, causing failures in the indexer downstream.

This `undefined` value is actually expected in the renderer code, even
though the type does not specify this possibility. This change updates
the type of `tagName` to be `string|null` and explicitly handles the
case where there is a structural directive on an `ng-template`. You can
see how the two are differentiated in the compliance code that was
modified in this commit.

PR Close #44788

1 parent 6cb7c3e

Files
Changes

Permalinks

Tip revision: fe3e4d6865c1e760be0511cfd757b4574a67fa5b authored by Andrew Scott on 21 January 2022, 19:51:40 UTC
fix(compiler-cli): Handle `ng-template` with structural directive in indexer (#44788)

Tip revision: fe3e4d6

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
aio
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	2.8 KB
.bazelrc	-rw-r--r--	6.7 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	240 bytes
.gitignore	-rw-r--r--	797 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	157 bytes
.pullapprove.yml	-rw-r--r--	47.8 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.0 KB
CHANGELOG.md	-rw-r--r--	984.8 KB
CODE_OF_CONDUCT.md	-rw-r--r--	1.1 KB
CONTRIBUTING.md	-rw-r--r--	15.8 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	4.7 KB
WORKSPACE	-rw-r--r--	2.8 KB
browser-providers.conf.js	-rw-r--r--	1.8 KB
gulpfile.js	-rw-r--r--	631 bytes
karma-js.conf.js	-rw-r--r--	6.0 KB
package.json	-rw-r--r--	8.4 KB
renovate.json	-rw-r--r--	2.5 KB
test-events.js	-rw-r--r--	259 bytes
tsconfig-tslint.json	-rw-r--r--	149 bytes
tslint.json	-rw-r--r--	4.9 KB
yarn.lock	-rw-r--r--	662.5 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

fix(compiler-cli): Handle `ng-template` with structural directive in indexer (#44788)

README.md