Revision fe5fbe32cb56c5c0990b843572112e963e17af5f authored by Andrew Kryczka on 04 September 2022, 21:55:09 UTC, committed by Facebook GitHub Bot on 04 September 2022, 21:55:09 UTC
Summary:
Previously, automatic compaction could be triggered prior to the test invoking CompactRange(). It could lead to the following flaky failure:
```
/root/project/db/db_block_cache_test.cc:753: Failure
Expected equality of these values:
1 + kNumBlocks
Which is: 11
options.statistics->getTickerCount(BLOCK_CACHE_INDEX_ADD)
Which is: 10
```
A sequence leading to this failure was:
* Automatic compaction
* files [1] [2] trivially moved
* files [3] [4] [5] [6] trivially moved
* CompactRange()
* files [7] [8] [9] trivially moved
* file [10] trivially moved
In such a case, the index/filter block adds that the test expected did not happen since there were no new files.
This PR just tweaks settings to ensure the `CompactRange()` produces one new file.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10635
Reviewed By: cbi42
Differential Revision: D39250869
Pulled By: ajkr
fbshipit-source-id: a3c94c49069e28c49c40b4b80dae0059739d19fd
1 parent 30bc495
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .github | ||
| buckifier | ||
| build_tools | ||
| cache | ||
| cmake | ||
| coverage | ||
| db | ||
| db_stress_tool | ||
| docs | ||
| env | ||
| examples | ||
| file | ||
| fuzz | ||
| include | ||
| java | ||
| logging | ||
| memory | ||
| memtable | ||
| microbench | ||
| monitoring | ||
| options | ||
| plugin | ||
| port | ||
| table | ||
| test_util | ||
| third-party | ||
| tools | ||
| trace_replay | ||
| util | ||
| utilities | ||
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 1017 bytes |
| .lgtm.yml | -rw-r--r-- | 67 bytes |
| .watchmanconfig | -rw-r--r-- | 130 bytes |
| AUTHORS | -rw-r--r-- | 322 bytes |
| CMakeLists.txt | -rw-r--r-- | 53.7 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.3 KB |
| CONTRIBUTING.md | -rw-r--r-- | 706 bytes |
| COPYING | -rw-r--r-- | 17.7 KB |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.5 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 253.0 KB |
| INSTALL.md | -rw-r--r-- | 7.9 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 1.3 KB |
| LICENSE.Apache | -rw-r--r-- | 11.1 KB |
| LICENSE.leveldb | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 95.0 KB |
| PLUGINS.md | -rw-r--r-- | 705 bytes |
| README.md | -rw-r--r-- | 2.0 KB |
| ROCKSDB_LITE.md | -rw-r--r-- | 1.0 KB |
| TARGETS | -rw-r--r-- | 658.0 KB |
| USERS.md | -rw-r--r-- | 8.3 KB |
| Vagrantfile | -rw-r--r-- | 1017 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| common.mk | -rw-r--r-- | 963 bytes |
| crash_test.mk | -rw-r--r-- | 4.1 KB |
| issue_template.md | -rw-r--r-- | 294 bytes |
| rocksdb.pc.in | -rw-r--r-- | 292 bytes |
| src.mk | -rw-r--r-- | 45.5 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
