Revision fec59a711eef002d4ef9eb8de09dd0a26986eb77 authored by John W. Linville on 05 August 2005, 01:06:10 UTC, committed by Linus Torvalds on 05 August 2005, 04:32:46 UTC
Some PCI devices (e.g. 3c905B, 3c556B) lose all configuration
(including BARs) when transitioning from D3hot->D0.  This leaves such
a device in an inaccessible state.  The patch below causes the BARs
to be restored when enabling such a device, so that its driver will
be able to access it.

The patch also adds pci_restore_bars as a new global symbol, and adds a
correpsonding EXPORT_SYMBOL_GPL for that.

Some firmware (e.g. Thinkpad T21) leaves devices in D3hot after a
(re)boot.  Most drivers call pci_enable_device very early, so devices
left in D3hot that lose configuration during the D3hot->D0 transition
will be inaccessible to their drivers.

Drivers could be modified to account for this, but it would
be difficult to know which drivers need modification.  This is
especially true since often many devices are covered by the same
driver.  It likely would be necessary to replicate code across dozens
of drivers.

The patch below should trigger only when transitioning from D3hot->D0
(or at boot), and only for devices that have the "no soft reset" bit
cleared in the PM control register.  I believe it is safe to include
this patch as part of the PCI infrastructure.

The cleanest implementation of pci_restore_bars was to call
pci_update_resource.  Unfortunately, that does not currently exist
for the sparc64 architecture.  The patch below includes a null
implemenation of pci_update_resource for sparc64.

Some have expressed interest in making general use of the the
pci_restore_bars function, so that has been exported to GPL licensed
modules.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent c306895
History
File Mode Size
ac97
ali5451
au88x0
ca0106
cs46xx
emu10k1
hda
ice1712
korg1212
mixart
nm256
rme9652
trident
vx222
ymfpci
Kconfig -rw-r--r-- 14.9 KB
Makefile -rw-r--r-- 1.7 KB
als4000.c -rw-r--r-- 22.5 KB
atiixp.c -rw-r--r-- 43.9 KB
atiixp_modem.c -rw-r--r-- 35.3 KB
azt3328.c -rw-r--r-- 50.5 KB
azt3328.h -rw-r--r-- 8.1 KB
bt87x.c -rw-r--r-- 27.3 KB
cmipci.c -rw-r--r-- 90.3 KB
cs4281.c -rw-r--r-- 64.8 KB
ens1370.c -rw-r--r-- 77.2 KB
ens1371.c -rw-r--r-- 38 bytes
es1938.c -rw-r--r-- 51.0 KB
es1968.c -rw-r--r-- 74.9 KB
fm801.c -rw-r--r-- 42.3 KB
intel8x0.c -rw-r--r-- 81.1 KB
intel8x0m.c -rw-r--r-- 38.9 KB
maestro3.c -rw-r--r-- 92.4 KB
rme32.c -rw-r--r-- 58.0 KB
rme96.c -rw-r--r-- 67.1 KB
sonicvibes.c -rw-r--r-- 51.1 KB
via82xx.c -rw-r--r-- 70.8 KB
via82xx_modem.c -rw-r--r-- 34.0 KB

back to top