Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 287 bytes |
| acl.c | -rw-r--r-- | 7.8 KB |
| acl.h | -rw-r--r-- | 1.3 KB |
| cache.c | -rw-r--r-- | 1.7 KB |
| cache.h | -rw-r--r-- | 573 bytes |
| fid.c | -rw-r--r-- | 7.3 KB |
| fid.h | -rw-r--r-- | 928 bytes |
| v9fs.c | -rw-r--r-- | 16.0 KB |
| v9fs.h | -rw-r--r-- | 7.2 KB |
| v9fs_vfs.h | -rw-r--r-- | 3.6 KB |
| vfs_addr.c | -rw-r--r-- | 9.3 KB |
| vfs_dentry.c | -rw-r--r-- | 2.5 KB |
| vfs_dir.c | -rw-r--r-- | 5.2 KB |
| vfs_file.c | -rw-r--r-- | 16.9 KB |
| vfs_inode.c | -rw-r--r-- | 34.4 KB |
| vfs_inode_dotl.c | -rw-r--r-- | 25.4 KB |
| vfs_super.c | -rw-r--r-- | 8.1 KB |
| xattr.c | -rw-r--r-- | 4.9 KB |
| xattr.h | -rw-r--r-- | 1018 bytes |
Computing file changes ...
